* [PATCH v3] ARM: S3C24XX DMA resume regression fix [not found] <077201ccf767c6d1ec05475c40$%kim@samsung.com> @ 2012-03-01 13:53 ` Gusakov Andrey 0 siblings, 0 replies; 4+ messages in thread From: Gusakov Andrey @ 2012-03-01 13:53 UTC (permalink / raw) To: Ben Dooks, Kukjin Kim Cc: linux-arm-kernel, linux-samsung-soc, heiko, Gusakov Andrey s3c2410_dma_suspend suspends channels from 0 to dma_channels. s3c2410_dma_resume resumes channels in reverse order. So pointer should be decremented instead of being incremented. Signed-off-by: Gusakov Andrey <dron0gus@gmail.com> Reviewed-by: Heiko Stuebner <heiko@sntech.de> --- arch/arm/plat-s3c24xx/dma.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index 57abec9..16510d5 100644 --- a/arch/arm/plat-s3c24xx/dma.c +++ b/arch/arm/plat-s3c24xx/dma.c @@ -1249,7 +1249,7 @@ static void s3c2410_dma_resume(void) struct s3c2410_dma_chan *cp = s3c2410_chans + dma_channels - 1; int channel; - for (channel = dma_channels - 1; channel >= 0; cp++, channel--) + for (channel = dma_channels - 1; channel >= 0; cp--, channel--) s3c2410_dma_resume_chan(cp); } -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3] ARM: S3C24XX DMA resume regression fix @ 2012-03-01 13:53 ` Gusakov Andrey 0 siblings, 0 replies; 4+ messages in thread From: Gusakov Andrey @ 2012-03-01 13:53 UTC (permalink / raw) To: linux-arm-kernel s3c2410_dma_suspend suspends channels from 0 to dma_channels. s3c2410_dma_resume resumes channels in reverse order. So pointer should be decremented instead of being incremented. Signed-off-by: Gusakov Andrey <dron0gus@gmail.com> Reviewed-by: Heiko Stuebner <heiko@sntech.de> --- arch/arm/plat-s3c24xx/dma.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index 57abec9..16510d5 100644 --- a/arch/arm/plat-s3c24xx/dma.c +++ b/arch/arm/plat-s3c24xx/dma.c @@ -1249,7 +1249,7 @@ static void s3c2410_dma_resume(void) struct s3c2410_dma_chan *cp = s3c2410_chans + dma_channels - 1; int channel; - for (channel = dma_channels - 1; channel >= 0; cp++, channel--) + for (channel = dma_channels - 1; channel >= 0; cp--, channel--) s3c2410_dma_resume_chan(cp); } -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] ARM: S3C24XX DMA resume regression fix 2012-03-01 13:53 ` Gusakov Andrey @ 2012-03-02 23:57 ` Kukjin Kim -1 siblings, 0 replies; 4+ messages in thread From: Kukjin Kim @ 2012-03-02 23:57 UTC (permalink / raw) To: Gusakov Andrey Cc: Ben Dooks, Kukjin Kim, linux-arm-kernel, linux-samsung-soc, heiko On 03/01/12 22:53, Gusakov Andrey wrote: > s3c2410_dma_suspend suspends channels from 0 to dma_channels. > s3c2410_dma_resume resumes channels in reverse order. So > pointer should be decremented instead of being incremented. > > Signed-off-by: Gusakov Andrey<dron0gus@gmail.com> > Reviewed-by: Heiko Stuebner<heiko@sntech.de> > --- > arch/arm/plat-s3c24xx/dma.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c > index 57abec9..16510d5 100644 > --- a/arch/arm/plat-s3c24xx/dma.c > +++ b/arch/arm/plat-s3c24xx/dma.c > @@ -1249,7 +1249,7 @@ static void s3c2410_dma_resume(void) > struct s3c2410_dma_chan *cp = s3c2410_chans + dma_channels - 1; > int channel; > > - for (channel = dma_channels - 1; channel>= 0; cp++, channel--) > + for (channel = dma_channels - 1; channel>= 0; cp--, channel--) > s3c2410_dma_resume_chan(cp); > } > Applied, thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3] ARM: S3C24XX DMA resume regression fix @ 2012-03-02 23:57 ` Kukjin Kim 0 siblings, 0 replies; 4+ messages in thread From: Kukjin Kim @ 2012-03-02 23:57 UTC (permalink / raw) To: linux-arm-kernel On 03/01/12 22:53, Gusakov Andrey wrote: > s3c2410_dma_suspend suspends channels from 0 to dma_channels. > s3c2410_dma_resume resumes channels in reverse order. So > pointer should be decremented instead of being incremented. > > Signed-off-by: Gusakov Andrey<dron0gus@gmail.com> > Reviewed-by: Heiko Stuebner<heiko@sntech.de> > --- > arch/arm/plat-s3c24xx/dma.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c > index 57abec9..16510d5 100644 > --- a/arch/arm/plat-s3c24xx/dma.c > +++ b/arch/arm/plat-s3c24xx/dma.c > @@ -1249,7 +1249,7 @@ static void s3c2410_dma_resume(void) > struct s3c2410_dma_chan *cp = s3c2410_chans + dma_channels - 1; > int channel; > > - for (channel = dma_channels - 1; channel>= 0; cp++, channel--) > + for (channel = dma_channels - 1; channel>= 0; cp--, channel--) > s3c2410_dma_resume_chan(cp); > } > Applied, thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-02 23:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <077201ccf767c6d1ec05475c40$%kim@samsung.com>
2012-03-01 13:53 ` [PATCH v3] ARM: S3C24XX DMA resume regression fix Gusakov Andrey
2012-03-01 13:53 ` Gusakov Andrey
2012-03-02 23:57 ` Kukjin Kim
2012-03-02 23:57 ` Kukjin Kim
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.