From: "H. Peter Anvin" <hpa@zytor.com>
To: wharms@bfs.de
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Matt Fleming <matt.fleming@intel.com>,
Maarten Lankhorst <m.b.lankhorst@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] x86, efi: fix pointer math issue in handle_ramdisks()
Date: Mon, 05 Mar 2012 19:33:24 +0000 [thread overview]
Message-ID: <4F551504.5010401@zytor.com> (raw)
In-Reply-To: <4F550917.9020508@bfs.de>
On 03/05/2012 10:42 AM, walter harms wrote:
>
>
> Am 05.03.2012 19:06, schrieb Dan Carpenter:
>> "filename" is a efi_char16_t string so this check for reaching the end
>> of the array doesn't work. We need to cast the pointer to (u8 *) before
>> doing the math.
>>
>> This patch changes the "filename" to "filename_16" to avoid confusion in
>> the future.
>>
>
> maybe it is a bit late, but ...
> is efi_char16_t a generic requirement for EFI ? perhaps we can use wchar_t
> since it is intended for such cases. additional we would get an api for free.
>
wchar_t is typically 32 bits on Linux. 16-bit anything is a major fail
since Unicode doesn't actually fit in 16 bits.
-hpa
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: wharms@bfs.de
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Matt Fleming <matt.fleming@intel.com>,
Maarten Lankhorst <m.b.lankhorst@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] x86, efi: fix pointer math issue in handle_ramdisks()
Date: Mon, 05 Mar 2012 11:33:24 -0800 [thread overview]
Message-ID: <4F551504.5010401@zytor.com> (raw)
In-Reply-To: <4F550917.9020508@bfs.de>
On 03/05/2012 10:42 AM, walter harms wrote:
>
>
> Am 05.03.2012 19:06, schrieb Dan Carpenter:
>> "filename" is a efi_char16_t string so this check for reaching the end
>> of the array doesn't work. We need to cast the pointer to (u8 *) before
>> doing the math.
>>
>> This patch changes the "filename" to "filename_16" to avoid confusion in
>> the future.
>>
>
> maybe it is a bit late, but ...
> is efi_char16_t a generic requirement for EFI ? perhaps we can use wchar_t
> since it is intended for such cases. additional we would get an api for free.
>
wchar_t is typically 32 bits on Linux. 16-bit anything is a major fail
since Unicode doesn't actually fit in 16 bits.
-hpa
next prev parent reply other threads:[~2012-03-05 19:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 19:01 [patch] x86, efi: fix pointer math issue in handle_ramdisks() Dan Carpenter
2012-03-02 19:01 ` Dan Carpenter
2012-03-03 7:54 ` Ingo Molnar
2012-03-03 7:54 ` Ingo Molnar
2012-03-05 18:06 ` [patch v2] " Dan Carpenter
2012-03-05 18:06 ` Dan Carpenter
2012-03-05 18:42 ` walter harms
2012-03-05 18:42 ` walter harms
2012-03-05 19:33 ` H. Peter Anvin [this message]
2012-03-05 19:33 ` H. Peter Anvin
2012-03-06 8:44 ` walter harms
2012-03-06 8:44 ` walter harms
2012-03-16 19:55 ` H. Peter Anvin
2012-03-16 19:55 ` H. Peter Anvin
2012-03-18 14:33 ` walter harms
2012-03-18 14:33 ` walter harms
2012-03-16 15:20 ` Matt Fleming
2012-03-16 21:27 ` [tip:x86/urgent] x86, efi: Fix " tip-bot for Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F551504.5010401@zytor.com \
--to=hpa@zytor.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.b.lankhorst@gmail.com \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=wharms@bfs.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.