From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: split pincontrol states into its own header
Date: Tue, 06 Mar 2012 14:21:43 -0700 [thread overview]
Message-ID: <4F567FE7.4020507@wwwdotorg.org> (raw)
In-Reply-To: <1331068552-16988-1-git-send-email-linus.walleij@stericsson.com>
On 03/06/2012 02:15 PM, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> Move the pin control state defines into its own header file,
> since it is used both by machine.h which is facing the platform
> and by consumer.h which is facing the drivers, and pinctrl.h
> which is pinctrl-driver internal, let's not have each and every
> .h file include all others, then isolation is moot.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Sure. I'm not quite sure how many (or how many standardized) states we
expect to have such that it warrants 'pinctrl-state.h' vs. say
'pinctrl-common.h', but it's probably fine.
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Stephen Warren <swarren@nvidia.com>,
Shawn Guo <shawn.guo@freescale.com>,
Thomas Abraham <thomas.abraham@linaro.org>,
Dong Aisheng <dong.aisheng@linaro.org>,
Rajendra Nayak <rajendra.nayak@linaro.org>,
Haojian Zhuang <haojian.zhuang@marvell.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] pinctrl: split pincontrol states into its own header
Date: Tue, 06 Mar 2012 14:21:43 -0700 [thread overview]
Message-ID: <4F567FE7.4020507@wwwdotorg.org> (raw)
In-Reply-To: <1331068552-16988-1-git-send-email-linus.walleij@stericsson.com>
On 03/06/2012 02:15 PM, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> Move the pin control state defines into its own header file,
> since it is used both by machine.h which is facing the platform
> and by consumer.h which is facing the drivers, and pinctrl.h
> which is pinctrl-driver internal, let's not have each and every
> .h file include all others, then isolation is moot.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Sure. I'm not quite sure how many (or how many standardized) states we
expect to have such that it warrants 'pinctrl-state.h' vs. say
'pinctrl-common.h', but it's probably fine.
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
next prev parent reply other threads:[~2012-03-06 21:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 21:15 [PATCH] pinctrl: split pincontrol states into its own header Linus Walleij
2012-03-06 21:15 ` Linus Walleij
2012-03-06 21:21 ` Stephen Warren [this message]
2012-03-06 21:21 ` Stephen Warren
2012-03-06 22:09 ` Linus Walleij
2012-03-06 22:09 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F567FE7.4020507@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.