From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: unlisted-recipients:; Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: fill in padding to help valgrind
Date: Wed, 07 Mar 2012 12:31:59 +0200 [thread overview]
Message-ID: <4F57391F.1000101@redhat.com> (raw)
In-Reply-To: <20120229155428.GA8413@redhat.com>
On 02/29/2012 05:54 PM, Michael S. Tsirkin wrote:
> valgrind warns about padding fields which are passed
> to vcpu ioctls uninitialized.
> This is not an error in practice because kvm ignored padding.
> Since the ioctls in question are off data path and
> the cost is zero anyway, initialize padding to 0
> to suppress these errors.
>
Applied to uq/master, thanks.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] kvm: fill in padding to help valgrind
Date: Wed, 07 Mar 2012 12:31:59 +0200 [thread overview]
Message-ID: <4F57391F.1000101@redhat.com> (raw)
In-Reply-To: <20120229155428.GA8413@redhat.com>
On 02/29/2012 05:54 PM, Michael S. Tsirkin wrote:
> valgrind warns about padding fields which are passed
> to vcpu ioctls uninitialized.
> This is not an error in practice because kvm ignored padding.
> Since the ioctls in question are off data path and
> the cost is zero anyway, initialize padding to 0
> to suppress these errors.
>
Applied to uq/master, thanks.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-03-07 10:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 15:54 [PATCH] kvm: fill in padding to help valgrind Michael S. Tsirkin
2012-02-29 15:54 ` [Qemu-devel] " Michael S. Tsirkin
2012-03-07 10:31 ` Avi Kivity [this message]
2012-03-07 10:31 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F57391F.1000101@redhat.com \
--to=avi@redhat.com \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.