From: Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Quote the configure args printed in config.log
Date: Wed, 07 Mar 2012 19:14:32 +0200 [thread overview]
Message-ID: <4F579778.5010609@redhat.com> (raw)
In-Reply-To: <1331122589-15717-1-git-send-email-peter.maydell@linaro.org>
On 03/07/2012 02:16 PM, Peter Maydell wrote:
> Use the same mechanism we use for printing the configure command
> line to config-host.mak to print it to config.log. This fixes a
> bug where the config.log version didn't quote arguments with spaces.
>
> # Print a helpful header at the top of config.log
> echo "# QEMU configure log $(date)" >> config.log
> -echo "# produced by $0 $*" >> config.log
> +printf "# Configured with:" >> config.log
> +printf " '%s'" "$0" "$@" >> config.log
> +echo >> config.log
> echo "#" >> config.log
>
This still breaks if an argument has a single quote. bash's printf's %q
deals with this correctly, but not sure how portable it is.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: Quote the configure args printed in config.log
Date: Wed, 07 Mar 2012 19:14:32 +0200 [thread overview]
Message-ID: <4F579778.5010609@redhat.com> (raw)
In-Reply-To: <1331122589-15717-1-git-send-email-peter.maydell@linaro.org>
On 03/07/2012 02:16 PM, Peter Maydell wrote:
> Use the same mechanism we use for printing the configure command
> line to config-host.mak to print it to config.log. This fixes a
> bug where the config.log version didn't quote arguments with spaces.
>
> # Print a helpful header at the top of config.log
> echo "# QEMU configure log $(date)" >> config.log
> -echo "# produced by $0 $*" >> config.log
> +printf "# Configured with:" >> config.log
> +printf " '%s'" "$0" "$@" >> config.log
> +echo >> config.log
> echo "#" >> config.log
>
This still breaks if an argument has a single quote. bash's printf's %q
deals with this correctly, but not sure how portable it is.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-03-07 17:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 12:16 [Qemu-trivial] [PATCH] configure: Quote the configure args printed in config.log Peter Maydell
2012-03-07 12:16 ` [Qemu-devel] " Peter Maydell
2012-03-07 12:40 ` [Qemu-trivial] " Stefan Hajnoczi
2012-03-07 12:40 ` Stefan Hajnoczi
2012-03-07 17:06 ` [Qemu-trivial] " Eric Blake
2012-03-07 17:06 ` Eric Blake
2012-03-07 17:08 ` [Qemu-trivial] " Peter Maydell
2012-03-07 17:08 ` Peter Maydell
2012-03-07 17:17 ` [Qemu-trivial] " Eric Blake
2012-03-07 17:17 ` Eric Blake
2012-03-07 17:09 ` [Qemu-trivial] " Peter Maydell
2012-03-07 17:09 ` Peter Maydell
2012-03-07 17:14 ` Avi Kivity [this message]
2012-03-07 17:14 ` Avi Kivity
2012-03-07 17:21 ` [Qemu-trivial] " Peter Maydell
2012-03-07 17:21 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F579778.5010609@redhat.com \
--to=avi@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.