All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Quote the configure args printed in config.log
Date: Wed, 07 Mar 2012 10:17:44 -0700	[thread overview]
Message-ID: <4F579838.8050701@redhat.com> (raw)
In-Reply-To: <CAFEAcA8_dGFsB0x9gb97S15Mj=BdxuN=Q8u=vbCCkDEPLxhofA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]

On 03/07/2012 10:08 AM, Peter Maydell wrote:
> If you look at the whole change, rather than just the
> fragment Stefan quoted to comment on:
> 
>  # Print a helpful header at the top of config.log
>  echo "# QEMU configure log $(date)" >> config.log
> -echo "# produced by $0 $*" >> config.log
> +printf "# Configured with:" >> config.log
> +printf " '%s'" "$0" "$@" >> config.log
> +echo >> config.log
>  echo "#" >> config.log
> 
> ...you'll see that it does exactly what you suggest.

Good to hear!  Serves me right for not paying attention to the thread
until my personal keyword of 'opengroup' appeared mid-stream, at which
point I'd already deleted your original message to see the full context.

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: Quote the configure args printed in config.log
Date: Wed, 07 Mar 2012 10:17:44 -0700	[thread overview]
Message-ID: <4F579838.8050701@redhat.com> (raw)
In-Reply-To: <CAFEAcA8_dGFsB0x9gb97S15Mj=BdxuN=Q8u=vbCCkDEPLxhofA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]

On 03/07/2012 10:08 AM, Peter Maydell wrote:
> If you look at the whole change, rather than just the
> fragment Stefan quoted to comment on:
> 
>  # Print a helpful header at the top of config.log
>  echo "# QEMU configure log $(date)" >> config.log
> -echo "# produced by $0 $*" >> config.log
> +printf "# Configured with:" >> config.log
> +printf " '%s'" "$0" "$@" >> config.log
> +echo >> config.log
>  echo "#" >> config.log
> 
> ...you'll see that it does exactly what you suggest.

Good to hear!  Serves me right for not paying attention to the thread
until my personal keyword of 'opengroup' appeared mid-stream, at which
point I'd already deleted your original message to see the full context.

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]

  reply	other threads:[~2012-03-07 17:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07 12:16 [Qemu-trivial] [PATCH] configure: Quote the configure args printed in config.log Peter Maydell
2012-03-07 12:16 ` [Qemu-devel] " Peter Maydell
2012-03-07 12:40 ` [Qemu-trivial] " Stefan Hajnoczi
2012-03-07 12:40   ` Stefan Hajnoczi
2012-03-07 17:06   ` [Qemu-trivial] " Eric Blake
2012-03-07 17:06     ` Eric Blake
2012-03-07 17:08     ` [Qemu-trivial] " Peter Maydell
2012-03-07 17:08       ` Peter Maydell
2012-03-07 17:17       ` Eric Blake [this message]
2012-03-07 17:17         ` Eric Blake
2012-03-07 17:09   ` [Qemu-trivial] " Peter Maydell
2012-03-07 17:09     ` Peter Maydell
2012-03-07 17:14 ` [Qemu-trivial] " Avi Kivity
2012-03-07 17:14   ` Avi Kivity
2012-03-07 17:21   ` [Qemu-trivial] " Peter Maydell
2012-03-07 17:21     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F579838.8050701@redhat.com \
    --to=eblake@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.