From: Zach Sadecki <zsadecki@itwatchdogs.com>
To: Rob Herring <robherring2@gmail.com>
Cc: vinod.koul@linux.intel.com, devicetree-discuss@lists.ozlabs.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
rob.herring@calxeda.com, grant.likely@secretlab.ca,
rdunlap@xenotime.net, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de, cjb@laptop.org,
Dong Aisheng <b29396@freescale.com>,
s.hauer@pengutronix.de, shawn.guo@freescale.com
Subject: Re: [PATCH v1 1/5] ARM: imx28: add basic dt support
Date: Tue, 13 Mar 2012 09:59:39 -0500 [thread overview]
Message-ID: <4F5F60DB.9090801@itwatchdogs.com> (raw)
In-Reply-To: <4F5F5B3F.2000303@gmail.com>
On 03/13/2012 09:35 AM, Rob Herring wrote:
> + ahb@80080000 {
> + fec@800f0000 {
> Use generic names: ethernet@800f0000
Generic is good, but consistency is better, IMHO. grepping existing dts
files in 3.2.9 finds 6 instances of "fec@" and 0 instances of "ethernet@"
>> + uart1: uart@80074000 {
> Use generic names: uart1: serial@...
Same comment here, but unfortunately there is already inconsistency in
existing files... 25 instances of "serial@" and 35 instances of "uart@"
WARNING: multiple messages have this Message-ID (diff)
From: zsadecki@itwatchdogs.com (Zach Sadecki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 1/5] ARM: imx28: add basic dt support
Date: Tue, 13 Mar 2012 09:59:39 -0500 [thread overview]
Message-ID: <4F5F60DB.9090801@itwatchdogs.com> (raw)
In-Reply-To: <4F5F5B3F.2000303@gmail.com>
On 03/13/2012 09:35 AM, Rob Herring wrote:
> + ahb at 80080000 {
> + fec at 800f0000 {
> Use generic names: ethernet at 800f0000
Generic is good, but consistency is better, IMHO. grepping existing dts
files in 3.2.9 finds 6 instances of "fec@" and 0 instances of "ethernet@"
>> + uart1: uart at 80074000 {
> Use generic names: uart1: serial at ...
Same comment here, but unfortunately there is already inconsistency in
existing files... 25 instances of "serial@" and 35 instances of "uart@"
WARNING: multiple messages have this Message-ID (diff)
From: Zach Sadecki <zsadecki@itwatchdogs.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Dong Aisheng <b29396@freescale.com>, <vinod.koul@linux.intel.com>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<rob.herring@calxeda.com>, <grant.likely@secretlab.ca>,
<rdunlap@xenotime.net>, <shawn.guo@freescale.com>,
<kernel@pengutronix.de>, <cjb@laptop.org>,
<s.hauer@pengutronix.de>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 1/5] ARM: imx28: add basic dt support
Date: Tue, 13 Mar 2012 09:59:39 -0500 [thread overview]
Message-ID: <4F5F60DB.9090801@itwatchdogs.com> (raw)
In-Reply-To: <4F5F5B3F.2000303@gmail.com>
On 03/13/2012 09:35 AM, Rob Herring wrote:
> + ahb@80080000 {
> + fec@800f0000 {
> Use generic names: ethernet@800f0000
Generic is good, but consistency is better, IMHO. grepping existing dts
files in 3.2.9 finds 6 instances of "fec@" and 0 instances of "ethernet@"
>> + uart1: uart@80074000 {
> Use generic names: uart1: serial@...
Same comment here, but unfortunately there is already inconsistency in
existing files... 25 instances of "serial@" and 35 instances of "uart@"
next prev parent reply other threads:[~2012-03-13 14:59 UTC|newest]
Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 8:47 [PATCH v1 0/5] dt: add basic imx28 support Dong Aisheng
2012-03-13 8:47 ` Dong Aisheng
2012-03-13 8:47 ` Dong Aisheng
2012-03-13 8:47 ` [PATCH v1 1/5] ARM: imx28: add basic dt support Dong Aisheng
2012-03-13 8:47 ` Dong Aisheng
2012-03-13 8:47 ` Dong Aisheng
2012-03-13 14:35 ` Rob Herring
2012-03-13 14:35 ` Rob Herring
2012-03-13 14:59 ` Zach Sadecki [this message]
2012-03-13 14:59 ` Zach Sadecki
2012-03-13 14:59 ` Zach Sadecki
2012-03-13 17:28 ` Grant Likely
2012-03-13 17:28 ` Grant Likely
2012-03-14 5:38 ` Shawn Guo
2012-03-14 5:38 ` Shawn Guo
2012-03-14 6:23 ` Dong Aisheng
2012-03-14 6:23 ` Dong Aisheng
2012-03-14 6:23 ` Dong Aisheng
2012-03-14 6:51 ` Marek Vasut
2012-03-14 6:51 ` Marek Vasut
2012-03-14 13:05 ` Rob Herring
2012-03-14 13:05 ` Rob Herring
2012-03-15 2:57 ` Dong Aisheng
2012-03-15 2:57 ` Dong Aisheng
2012-03-13 17:23 ` Grant Likely
2012-03-13 17:23 ` Grant Likely
2012-03-14 5:41 ` Shawn Guo
2012-03-14 5:41 ` Shawn Guo
2012-03-14 5:56 ` Marek Vasut
2012-03-14 5:56 ` Marek Vasut
2012-03-14 6:30 ` Dong Aisheng
2012-03-14 6:30 ` Dong Aisheng
2012-03-14 6:30 ` Dong Aisheng
2012-03-14 12:45 ` Dong Aisheng
2012-03-14 12:45 ` Dong Aisheng
2012-03-14 14:16 ` s.hauer
2012-03-14 14:16 ` s.hauer at pengutronix.de
2012-03-15 3:02 ` Dong Aisheng
2012-03-15 3:02 ` Dong Aisheng
2012-03-15 6:53 ` Lothar Waßmann
2012-03-15 6:53 ` Lothar Waßmann
2012-03-15 6:53 ` Lothar Waßmann
2012-03-15 10:59 ` Dong Aisheng
2012-03-15 10:59 ` Dong Aisheng
[not found] ` <20120315105927.GE13022-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-03-15 11:22 ` Lothar Waßmann
2012-03-15 11:22 ` Lothar Waßmann
2012-03-15 11:22 ` Lothar Waßmann
2012-03-16 3:01 ` Dong Aisheng
2012-03-16 3:01 ` Dong Aisheng
2012-03-16 7:48 ` Lothar Waßmann
2012-03-16 7:48 ` Lothar Waßmann
2012-03-16 7:48 ` Lothar Waßmann
2012-03-16 8:22 ` Dong Aisheng
2012-03-16 8:22 ` Dong Aisheng
[not found] ` <20120316030134.GA5161-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-03-18 18:47 ` Grant Likely
2012-03-18 18:47 ` Grant Likely
2012-03-19 6:54 ` Lothar Waßmann
2012-03-19 6:54 ` Lothar Waßmann
2012-03-19 6:54 ` Lothar Waßmann
[not found] ` <20326.55337.249575.289067-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>
2012-03-19 15:06 ` Grant Likely
2012-03-19 15:06 ` Grant Likely
2012-03-19 16:49 ` Lothar Waßmann
2012-03-19 16:49 ` Lothar Waßmann
2012-03-19 16:49 ` Lothar Waßmann
[not found] ` <20327.25470.723875.916422-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>
2012-03-19 22:02 ` Grant Likely
2012-03-19 22:02 ` Grant Likely
2012-03-20 12:49 ` Dong Aisheng
2012-03-20 12:49 ` Dong Aisheng
2012-03-20 13:17 ` Lothar Waßmann
2012-03-20 13:17 ` Lothar Waßmann
2012-03-20 13:17 ` Lothar Waßmann
2012-03-21 11:06 ` Dong Aisheng
2012-03-21 11:06 ` Dong Aisheng
2012-03-16 8:49 ` Shawn Guo
2012-03-16 8:49 ` Shawn Guo
2012-03-15 11:24 ` s.hauer
2012-03-15 11:24 ` s.hauer at pengutronix.de
2012-03-16 3:05 ` Dong Aisheng
2012-03-16 3:05 ` Dong Aisheng
2012-03-14 19:41 ` Sascha Hauer
2012-03-14 19:41 ` Sascha Hauer
2012-03-15 3:05 ` Dong Aisheng
2012-03-15 3:05 ` Dong Aisheng
2012-03-13 8:47 ` [PATCH v1 2/5] mmc: mxs-mmc: add dt probe support Dong Aisheng
2012-03-13 8:47 ` Dong Aisheng
2012-03-13 8:47 ` Dong Aisheng
2012-03-13 17:42 ` Grant Likely
2012-03-13 17:42 ` Grant Likely
2012-03-14 6:42 ` Dong Aisheng
2012-03-14 6:42 ` Dong Aisheng
2012-03-14 5:58 ` Marek Vasut
2012-03-14 5:58 ` Marek Vasut
2012-03-14 6:55 ` Dong Aisheng
2012-03-14 6:55 ` Dong Aisheng
2012-03-14 7:09 ` Marek Vasut
2012-03-14 7:09 ` Marek Vasut
2012-03-14 7:13 ` s.hauer
2012-03-14 7:13 ` s.hauer at pengutronix.de
2012-03-14 7:26 ` Dong Aisheng
2012-03-14 7:26 ` Dong Aisheng
2012-03-14 11:17 ` Marek Vasut
2012-03-14 11:17 ` Marek Vasut
2012-03-14 11:17 ` Marek Vasut
2012-03-14 7:23 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-14 7:23 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-14 8:09 ` Dong Aisheng
2012-03-14 8:09 ` Dong Aisheng
[not found] ` <20120314080939.GA1180-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-03-14 8:52 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-14 8:52 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-14 8:52 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-13 8:47 ` [PATCH v1 3/5] ARM: imx28evk: add mmc dt support Dong Aisheng
2012-03-13 8:47 ` Dong Aisheng
2012-03-13 8:47 ` Dong Aisheng
2012-03-13 14:39 ` Rob Herring
2012-03-13 14:39 ` Rob Herring
2012-03-13 16:52 ` Sascha Hauer
2012-03-13 16:52 ` Sascha Hauer
2012-03-13 17:45 ` Rob Herring
2012-03-13 17:45 ` Rob Herring
2012-03-14 7:30 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-14 7:30 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-14 8:20 ` Dong Aisheng
2012-03-14 8:20 ` Dong Aisheng
2012-03-14 8:54 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-14 8:54 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-14 7:28 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-14 7:28 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-13 8:47 ` [PATCH v1 4/5] dma: mxs-dma: add dt probe support Dong Aisheng
2012-03-13 8:47 ` Dong Aisheng
2012-03-13 8:47 ` Dong Aisheng
2012-03-14 7:54 ` Huang Shijie
2012-03-14 7:54 ` Huang Shijie
2012-03-14 7:54 ` Huang Shijie
2012-03-14 8:23 ` Dong Aisheng
2012-03-14 8:23 ` Dong Aisheng
2012-03-13 8:47 ` [PATCH v1 5/5] ARM: mxs: add mxs dma dt support Dong Aisheng
2012-03-13 8:47 ` Dong Aisheng
2012-03-13 8:47 ` Dong Aisheng
2012-03-14 7:58 ` Huang Shijie
2012-03-14 7:58 ` Huang Shijie
2012-03-14 7:58 ` Huang Shijie
2012-03-14 8:30 ` Dong Aisheng
2012-03-14 8:30 ` Dong Aisheng
2012-03-14 8:43 ` Huang Shijie
2012-03-14 8:43 ` Huang Shijie
2012-03-14 6:01 ` [PATCH v1 0/5] dt: add basic imx28 support Marek Vasut
2012-03-14 6:01 ` Marek Vasut
2012-03-14 7:34 ` Dong Aisheng
2012-03-14 7:34 ` Dong Aisheng
2012-03-14 7:34 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5F60DB.9090801@itwatchdogs.com \
--to=zsadecki@itwatchdogs.com \
--cc=b29396@freescale.com \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@freescale.com \
--cc=vinod.koul@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.