From: Kukjin Kim <kgene.kim@samsung.com>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, arnd@arndb.de, olof@lixom.net
Subject: Re: [PATCH v3 07/12] ARM: EXYNOS: add interrupt definitions for EXYNOS5250
Date: Tue, 13 Mar 2012 23:32:14 -0700 [thread overview]
Message-ID: <4F603B6E.7000103@samsung.com> (raw)
In-Reply-To: <CAJuYYwTFEV06C+gWEoXDtKoqhujA8HphNuLLJs3EBzaKnTvcfQ@mail.gmail.com>
On 03/13/12 22:27, Thomas Abraham wrote:
> On 13 March 2012 21:00, Kukjin Kim<kgene.kim@samsung.com> wrote:
>> ARM: EXYNOS: irqs.h for exynos4 and exynos5 - WIP
>> This patch adds the interrupt definitions for EXYNOS5250 at
>> <mach/irqs.h> file. Basically, now it is needed for EXYNOS5250
>> interrupt and will be updated for single zImage next time.
>>
>> Signed-off-by: Kukjin Kim<kgene.kim@samsung.com>
>> ---
>> arch/arm/mach-exynos/common.c | 97 ++++--
>> arch/arm/mach-exynos/dev-ahci.c | 4 +-
>> arch/arm/mach-exynos/dev-audio.c | 4 +-
>> arch/arm/mach-exynos/include/mach/irqs.h | 580 ++++++++++++++++++++++--------
>> arch/arm/mach-exynos/mct.c | 23 +-
>> arch/arm/plat-s5p/irq-pm.c | 25 +-
>> arch/arm/plat-samsung/irq-vic-timer.c | 16 +
>> 7 files changed, 548 insertions(+), 201 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
>> index 7fdb139..0b53018 100644
>> --- a/arch/arm/mach-exynos/common.c
>
>
> [...]
>
>> for (irq = 0 ; irq<= 15 ; irq++) {
>> eint0_15_data[irq] = IRQ_EINT(irq);
>>
>> - irq_set_handler_data(exynos4_get_irq_nr(irq),
>> -&eint0_15_data[irq]);
>> - irq_set_chained_handler(exynos4_get_irq_nr(irq),
>> + if (soc_is_exynos5250()) {
>> + irq_set_handler_data(exynos4_eint0_15_src_int[irq],
>> +&eint0_15_data[irq]);
>> + irq_set_chained_handler(exynos4_eint0_15_src_int[irq],
>> + exynos4_irq_eint0_15);
>> + } else {
>> + irq_set_handler_data(exynos5_eint0_15_src_int[irq],
>> +&eint0_15_data[irq]);
>> + irq_set_chained_handler(exynos5_eint0_15_src_int[irq],
>> exynos4_irq_eint0_15);
>> + }
>> }
>
> The external interrupt numbers for Exynos4 and Exynos5 have been
> swapped. This needs to be fixed.
>
Oops again :-( let me fix it.
Thanks, Thomas.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 07/12] ARM: EXYNOS: add interrupt definitions for EXYNOS5250
Date: Tue, 13 Mar 2012 23:32:14 -0700 [thread overview]
Message-ID: <4F603B6E.7000103@samsung.com> (raw)
In-Reply-To: <CAJuYYwTFEV06C+gWEoXDtKoqhujA8HphNuLLJs3EBzaKnTvcfQ@mail.gmail.com>
On 03/13/12 22:27, Thomas Abraham wrote:
> On 13 March 2012 21:00, Kukjin Kim<kgene.kim@samsung.com> wrote:
>> ARM: EXYNOS: irqs.h for exynos4 and exynos5 - WIP
>> This patch adds the interrupt definitions for EXYNOS5250 at
>> <mach/irqs.h> file. Basically, now it is needed for EXYNOS5250
>> interrupt and will be updated for single zImage next time.
>>
>> Signed-off-by: Kukjin Kim<kgene.kim@samsung.com>
>> ---
>> arch/arm/mach-exynos/common.c | 97 ++++--
>> arch/arm/mach-exynos/dev-ahci.c | 4 +-
>> arch/arm/mach-exynos/dev-audio.c | 4 +-
>> arch/arm/mach-exynos/include/mach/irqs.h | 580 ++++++++++++++++++++++--------
>> arch/arm/mach-exynos/mct.c | 23 +-
>> arch/arm/plat-s5p/irq-pm.c | 25 +-
>> arch/arm/plat-samsung/irq-vic-timer.c | 16 +
>> 7 files changed, 548 insertions(+), 201 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
>> index 7fdb139..0b53018 100644
>> --- a/arch/arm/mach-exynos/common.c
>
>
> [...]
>
>> for (irq = 0 ; irq<= 15 ; irq++) {
>> eint0_15_data[irq] = IRQ_EINT(irq);
>>
>> - irq_set_handler_data(exynos4_get_irq_nr(irq),
>> -&eint0_15_data[irq]);
>> - irq_set_chained_handler(exynos4_get_irq_nr(irq),
>> + if (soc_is_exynos5250()) {
>> + irq_set_handler_data(exynos4_eint0_15_src_int[irq],
>> +&eint0_15_data[irq]);
>> + irq_set_chained_handler(exynos4_eint0_15_src_int[irq],
>> + exynos4_irq_eint0_15);
>> + } else {
>> + irq_set_handler_data(exynos5_eint0_15_src_int[irq],
>> +&eint0_15_data[irq]);
>> + irq_set_chained_handler(exynos5_eint0_15_src_int[irq],
>> exynos4_irq_eint0_15);
>> + }
>> }
>
> The external interrupt numbers for Exynos4 and Exynos5 have been
> swapped. This needs to be fixed.
>
Oops again :-( let me fix it.
Thanks, Thomas.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-03-14 6:32 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 15:30 [PATCH v3 00/12] ARM: EXYNOS: add support new EXYNOS5250 Kukjin Kim
2012-03-13 15:30 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 01/12] ARM: EXYNOS: to declare static for mach-exynos/common.c Kukjin Kim
2012-03-13 15:30 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 02/12] ARM: EXYNOS: use exynos_init_uarts() instead of exynos4_init_uarts() Kukjin Kim
2012-03-13 15:30 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 03/12] ARM: EXYNOS: add clock part for EXYNOS5250 SoC Kukjin Kim
2012-03-13 15:30 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 04/12] ARM: EXYNOS: add initial setup-i2c0 for EXYNOS5 Kukjin Kim
2012-03-13 15:30 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 05/12] ARM: EXYNOS: add support uart for EXYNOS4 and EXYNOS5 Kukjin Kim
2012-03-13 15:30 ` Kukjin Kim
2012-03-13 16:13 ` Arnd Bergmann
2012-03-13 16:13 ` Arnd Bergmann
2012-03-14 7:06 ` Kukjin Kim
2012-03-14 7:06 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 06/12] ARM: EXYNOS: add support for EXYNOS5250 SoC Kukjin Kim
2012-03-13 15:30 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 07/12] ARM: EXYNOS: add interrupt definitions for EXYNOS5250 Kukjin Kim
2012-03-13 15:30 ` Kukjin Kim
2012-03-14 3:42 ` Olof Johansson
2012-03-14 3:42 ` Olof Johansson
2012-03-14 6:30 ` Kukjin Kim
2012-03-14 6:30 ` Kukjin Kim
2012-03-14 5:27 ` Thomas Abraham
2012-03-14 5:27 ` Thomas Abraham
2012-03-14 6:32 ` Kukjin Kim [this message]
2012-03-14 6:32 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 08/12] ARM: EXYNOS: support EINT for EXYNOS4 and EXYNOS5 Kukjin Kim
2012-03-13 15:30 ` Kukjin Kim
2012-03-14 3:52 ` Olof Johansson
2012-03-14 3:52 ` Olof Johansson
2012-03-14 6:33 ` Kukjin Kim
2012-03-14 6:33 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 09/12] ARM: EXYNOS: add support get_core_count() for EXYNOS5250 Kukjin Kim
2012-03-13 15:30 ` Kukjin Kim
2012-03-13 16:15 ` Arnd Bergmann
2012-03-13 16:15 ` Arnd Bergmann
2012-03-14 6:49 ` Kukjin Kim
2012-03-14 6:49 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 10/12] ARM: EXYNOS: add support ARCH_EXYNOS5 for EXYNOS5 SoCs Kukjin Kim
2012-03-13 15:30 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 11/12] ARM: EXYNOS: add support device tree enabled board file for EXYNOS5 Kukjin Kim
2012-03-13 15:30 ` Kukjin Kim
2012-03-13 15:30 ` [PATCH v3 12/12] ARM: dts: add initial dts file for EXYNOS5250, SMDK5250 Kukjin Kim
2012-03-13 15:30 ` Kukjin Kim
2012-03-14 3:56 ` Olof Johansson
2012-03-14 3:56 ` Olof Johansson
2012-03-14 6:43 ` Kukjin Kim
2012-03-14 6:43 ` Kukjin Kim
2012-03-13 16:22 ` [PATCH v3 00/12] ARM: EXYNOS: add support new EXYNOS5250 Arnd Bergmann
2012-03-13 16:22 ` Arnd Bergmann
2012-03-14 3:57 ` Olof Johansson
2012-03-14 3:57 ` Olof Johansson
2012-03-14 7:08 ` Kukjin Kim
2012-03-14 7:08 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F603B6E.7000103@samsung.com \
--to=kgene.kim@samsung.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.