From: Glauber Costa <glommer@parallels.com>
To: Suleiman Souhlal <suleiman@google.com>
Cc: Suleiman Souhlal <ssouhlal@freebsd.org>,
cgroups@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com,
penberg@kernel.org, cl@linux.com, yinghan@google.com,
hughd@google.com, gthelen@google.com, peterz@infradead.org,
dan.magenheimer@oracle.com, hannes@cmpxchg.org, mgorman@suse.de,
James.Bottomley@hansenpartnership.com, linux-mm@kvack.org,
devel@openvz.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 03/13] memcg: Uncharge all kmem when deleting a cgroup.
Date: Wed, 14 Mar 2012 15:59:28 +0400 [thread overview]
Message-ID: <4F608820.8080006@parallels.com> (raw)
In-Reply-To: <CABCjUKBUQ7QS-pJbzrN=8_AFj20uP+dgOH44AWfK4ZecpprybA@mail.gmail.com>
>>> @@ -3719,6 +3721,8 @@ move_account:
>>> /* This is for making all *used* pages to be on LRU. */
>>> lru_add_drain_all();
>>> drain_all_stock_sync(memcg);
>>> + if (!free_all)
>>> + memcg_kmem_move(memcg);
>>
>> Any reason we're not moving kmem charges when free_all is set as well?
>
> Because the slab moving code expects to be synchronized with
> allocations (and itself). We can't call it when there are still tasks
> in the cgroup.
Ok.
Please add an explanation about that.
Oh boy, reading it all now, I started to believe that "free_all" is a
really poor name =(
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Suleiman Souhlal <suleiman@google.com>
Cc: Suleiman Souhlal <ssouhlal@freebsd.org>,
<cgroups@vger.kernel.org>, <kamezawa.hiroyu@jp.fujitsu.com>,
<penberg@kernel.org>, <cl@linux.com>, <yinghan@google.com>,
<hughd@google.com>, <gthelen@google.com>, <peterz@infradead.org>,
<dan.magenheimer@oracle.com>, <hannes@cmpxchg.org>,
<mgorman@suse.de>, <James.Bottomley@hansenpartnership.com>,
<linux-mm@kvack.org>, <devel@openvz.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 03/13] memcg: Uncharge all kmem when deleting a cgroup.
Date: Wed, 14 Mar 2012 15:59:28 +0400 [thread overview]
Message-ID: <4F608820.8080006@parallels.com> (raw)
In-Reply-To: <CABCjUKBUQ7QS-pJbzrN=8_AFj20uP+dgOH44AWfK4ZecpprybA@mail.gmail.com>
>>> @@ -3719,6 +3721,8 @@ move_account:
>>> /* This is for making all *used* pages to be on LRU. */
>>> lru_add_drain_all();
>>> drain_all_stock_sync(memcg);
>>> + if (!free_all)
>>> + memcg_kmem_move(memcg);
>>
>> Any reason we're not moving kmem charges when free_all is set as well?
>
> Because the slab moving code expects to be synchronized with
> allocations (and itself). We can't call it when there are still tasks
> in the cgroup.
Ok.
Please add an explanation about that.
Oh boy, reading it all now, I started to believe that "free_all" is a
really poor name =(
next prev parent reply other threads:[~2012-03-14 11:59 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 20:39 [PATCH v2 00/13] Memcg Kernel Memory Tracking Suleiman Souhlal
2012-03-09 20:39 ` Suleiman Souhlal
2012-03-09 20:39 ` Suleiman Souhlal
2012-03-09 20:39 ` [PATCH v2 01/13] memcg: Consolidate various flags into a single flags field Suleiman Souhlal
2012-03-09 20:39 ` Suleiman Souhlal
2012-03-11 7:50 ` Glauber Costa
2012-03-11 7:50 ` Glauber Costa
2012-03-09 20:39 ` [PATCH v2 02/13] memcg: Kernel memory accounting infrastructure Suleiman Souhlal
2012-03-09 20:39 ` Suleiman Souhlal
[not found] ` <1331325556-16447-3-git-send-email-ssouhlal-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org>
2012-03-11 8:12 ` Glauber Costa
2012-03-11 8:12 ` Glauber Costa
2012-03-11 8:12 ` Glauber Costa
2012-03-13 6:24 ` KAMEZAWA Hiroyuki
2012-03-13 6:24 ` KAMEZAWA Hiroyuki
2012-03-13 10:37 ` Glauber Costa
2012-03-13 10:37 ` Glauber Costa
2012-03-13 17:00 ` Greg Thelen
2012-03-13 17:00 ` Greg Thelen
[not found] ` <xr93d38g77w5.fsf-aSPv4SP+Du0KgorLzL7FmE7CuiCeIGUxQQ4Iyu8u01E@public.gmane.org>
2012-03-13 17:31 ` Glauber Costa
2012-03-13 17:31 ` Glauber Costa
2012-03-13 17:31 ` Glauber Costa
2012-03-14 0:15 ` KAMEZAWA Hiroyuki
2012-03-14 0:15 ` KAMEZAWA Hiroyuki
2012-03-14 12:29 ` Glauber Costa
2012-03-14 12:29 ` Glauber Costa
2012-03-15 0:48 ` KAMEZAWA Hiroyuki
2012-03-15 0:48 ` KAMEZAWA Hiroyuki
[not found] ` <4F613C5B.8030304-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-03-15 11:07 ` Glauber Costa
2012-03-15 11:07 ` Glauber Costa
2012-03-15 11:07 ` Glauber Costa
2012-03-15 11:13 ` Peter Zijlstra
2012-03-15 11:13 ` Peter Zijlstra
2012-03-15 11:21 ` Glauber Costa
2012-03-15 11:21 ` Glauber Costa
2012-03-12 12:38 ` Glauber Costa
2012-03-12 12:38 ` Glauber Costa
2012-03-12 12:38 ` Glauber Costa
2012-03-09 20:39 ` [PATCH v2 03/13] memcg: Uncharge all kmem when deleting a cgroup Suleiman Souhlal
2012-03-09 20:39 ` Suleiman Souhlal
2012-03-11 8:19 ` Glauber Costa
2012-03-11 8:19 ` Glauber Costa
2012-03-13 23:16 ` Suleiman Souhlal
2012-03-13 23:16 ` Suleiman Souhlal
2012-03-14 11:59 ` Glauber Costa [this message]
2012-03-14 11:59 ` Glauber Costa
[not found] ` <1331325556-16447-4-git-send-email-ssouhlal-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org>
2012-03-13 6:27 ` KAMEZAWA Hiroyuki
2012-03-13 6:27 ` KAMEZAWA Hiroyuki
2012-03-13 6:27 ` KAMEZAWA Hiroyuki
2012-03-09 20:39 ` [PATCH v2 04/13] memcg: Make it possible to use the stock for more than one page Suleiman Souhlal
2012-03-09 20:39 ` Suleiman Souhlal
[not found] ` <1331325556-16447-5-git-send-email-ssouhlal-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org>
2012-03-11 10:49 ` Glauber Costa
2012-03-11 10:49 ` Glauber Costa
2012-03-11 10:49 ` Glauber Costa
2012-03-09 20:39 ` [PATCH v2 05/13] memcg: Reclaim when more than one page needed Suleiman Souhlal
2012-03-09 20:39 ` Suleiman Souhlal
2012-03-09 20:39 ` [PATCH v2 06/13] slab: Add kmem_cache_gfp_flags() helper function Suleiman Souhlal
2012-03-09 20:39 ` Suleiman Souhlal
2012-03-11 10:53 ` Glauber Costa
2012-03-11 10:53 ` Glauber Costa
[not found] ` <4F5C8414.5090800-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-03-13 23:21 ` Suleiman Souhlal
2012-03-13 23:21 ` Suleiman Souhlal
2012-03-13 23:21 ` Suleiman Souhlal
[not found] ` <CABCjUKCioWO-F7k=hVs_18B3uyL4zG3-krPFDh++YAnmejKKdg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-14 11:48 ` Glauber Costa
2012-03-14 11:48 ` Glauber Costa
2012-03-14 11:48 ` Glauber Costa
[not found] ` <4F608579.5090109-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-03-14 22:08 ` Suleiman Souhlal
2012-03-14 22:08 ` Suleiman Souhlal
2012-03-14 22:08 ` Suleiman Souhlal
2012-03-09 20:39 ` [PATCH v2 07/13] memcg: Slab accounting Suleiman Souhlal
2012-03-09 20:39 ` Suleiman Souhlal
[not found] ` <1331325556-16447-8-git-send-email-ssouhlal-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org>
2012-03-11 10:25 ` Glauber Costa
2012-03-11 10:25 ` Glauber Costa
2012-03-11 10:25 ` Glauber Costa
2012-03-13 22:50 ` Suleiman Souhlal
2012-03-13 22:50 ` Suleiman Souhlal
2012-03-14 10:47 ` Glauber Costa
2012-03-14 10:47 ` Glauber Costa
[not found] ` <4F60775F.20709-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-03-14 22:04 ` Suleiman Souhlal
2012-03-14 22:04 ` Suleiman Souhlal
2012-03-14 22:04 ` Suleiman Souhlal
[not found] ` <CABCjUKCWaXTzsVaFHG57ELWV4Yk15vt=Ei8tvbsxpQKnxTmksg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-15 11:40 ` Glauber Costa
2012-03-15 11:40 ` Glauber Costa
2012-03-15 11:40 ` Glauber Costa
2012-03-09 20:39 ` [PATCH v2 08/13] memcg: Make dentry slab memory accounted in kernel memory accounting Suleiman Souhlal
2012-03-09 20:39 ` Suleiman Souhlal
2012-03-09 20:39 ` [PATCH v2 09/13] memcg: Account for kmalloc " Suleiman Souhlal
2012-03-09 20:39 ` Suleiman Souhlal
2012-03-11 12:21 ` Glauber Costa
2012-03-11 12:21 ` Glauber Costa
2012-03-09 20:39 ` [PATCH v2 10/13] memcg: Track all the memcg children of a kmem_cache Suleiman Souhlal
2012-03-09 20:39 ` Suleiman Souhlal
2012-03-09 20:39 ` [PATCH v2 11/13] memcg: Handle bypassed kernel memory charges Suleiman Souhlal
2012-03-09 20:39 ` Suleiman Souhlal
2012-03-09 20:39 ` [PATCH v2 12/13] memcg: Per-memcg memory.kmem.slabinfo file Suleiman Souhlal
2012-03-09 20:39 ` Suleiman Souhlal
2012-03-11 10:35 ` Glauber Costa
2012-03-11 10:35 ` Glauber Costa
2012-03-09 20:39 ` [PATCH v2 13/13] memcg: Document kernel memory accounting Suleiman Souhlal
2012-03-09 20:39 ` Suleiman Souhlal
[not found] ` <1331325556-16447-14-git-send-email-ssouhlal-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org>
2012-03-11 10:42 ` Glauber Costa
2012-03-11 10:42 ` Glauber Costa
2012-03-11 10:42 ` Glauber Costa
[not found] ` <1331325556-16447-1-git-send-email-ssouhlal-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org>
2012-03-10 6:25 ` [PATCH v2 00/13] Memcg Kernel Memory Tracking Suleiman Souhlal
2012-03-10 6:25 ` Suleiman Souhlal
2012-03-10 6:25 ` Suleiman Souhlal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F608820.8080006@parallels.com \
--to=glommer@parallels.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=dan.magenheimer@oracle.com \
--cc=devel@openvz.org \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=ssouhlal@freebsd.org \
--cc=suleiman@google.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.