drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205

drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205

[Vaclav Mocek]

Hi all,

I am an unhappy owner of Lenovo Ideapad S205 and the drivers in the 
current development kernel (2f1c2b8) soft-blocks its Wi-Fi. S205 loads 
two kernel modules - ideapad-laptop.c and acer-wmi.c. The rfkill is 
controlled by acer-wmi.c and there is already a support for S205:

     {
         .callback = dmi_matched,
         .ident = "Lenovo Ideapad S205",
         .matches = {
             DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
             DMI_MATCH(DMI_PRODUCT_NAME, "10382LG"),
         },
         .driver_data = &quirk_lenovo_ideapad_s205,
     },

Unfortunately, my netbook has a different DMI_PRODUCT_NAME - "Brazos" 
instead of "10382LG" and there are at least eighteen possibilities [1]. 
I spent some time Googling, comparing Smolt profiles, reading S205 
Hardware Maintenance Manual [2]  and analysing the BIOS updates. It 
seems, that all S205 are based on AMD platform called "Inagua" (E300, 
E350, E450), use two types of Wi-Fi cards (RaLink RT3090 and AR9285), 
various combination of SO DIMMs (2 x 1GB, 1 x 2GB, 2 x 2GB), different 
sizes of hardrives and different keyboard layouts; so overall there are 
pretty much the same.

There is a rare netbook called Lenovo Ideapad S205s ("s" at the end), 
but this one is based on Intel's processors [3].

My proposal is very simple:

     {
          .callback = dmi_matched,
          .ident = "Lenovo Ideapad S205",
          .matches = {
              DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-            DMI_MATCH(DMI_PRODUCT_NAME, "10382LG"),
+            DMI_MATCH(DMI_PRODUCT_VERSION, "Ideapad S205"),
          },
          .driver_data = &quirk_lenovo_ideapad_s205,
      },

It works. We are not able to test all product names and if the checking 
of DMI_PRODUCT_NAME is really required, it should be done in an 
additional step. The current situation is pretty bad - problems with 
UEFI booting (the only possibility)[4], impossibility to switch the 
power off, failing brightness control - and without a functional network 
connection for a start, it is better to throw it out of the window.

[1] 
http://smolt.fedoraproject.org/reports/view_profiles?profile=Ideapad+S205&search=Submit+Query
[2] http://www.manualowl.com/m/Lenovo/IdeaPad-S205/Manual/192357
[3] http://www.manualowl.com/m/Lenovo/IdeaPad-S205s/Manual/227621
[4] 
http://fedoraproject.org/wiki/Common_F16_bugs#UEFI_install_to_Lenovo_Ideapad_S205_fails_to_boot


Best Regards

Vaclav Mocek

Re: drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205

[Ike Panhc]

Hi Vaclav,

Could you try this just-merged patch and see if it fix your problem?

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=461e74377cfcfc2c0d6bbdfa8fc5fbc21b052c2a

On 03/14/2012 11:01 AM, Vaclav Mocek wrote:
> Hi all,
> 
> I am an unhappy owner of Lenovo Ideapad S205 and the drivers in the current development kernel (2f1c2b8) soft-blocks its Wi-Fi. S205 loads two kernel modules - ideapad-laptop.c and acer-wmi.c. The rfkill is controlled by acer-wmi.c and there is already a support for S205:
> 
>     {
>         .callback = dmi_matched,
>         .ident = "Lenovo Ideapad S205",
>         .matches = {
>             DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>             DMI_MATCH(DMI_PRODUCT_NAME, "10382LG"),
>         },
>         .driver_data = &quirk_lenovo_ideapad_s205,
>     },
> 
> Unfortunately, my netbook has a different DMI_PRODUCT_NAME - "Brazos" instead of "10382LG" and there are at least eighteen possibilities [1]. I spent some time Googling, comparing Smolt profiles, reading S205 Hardware Maintenance Manual [2]  and analysing the BIOS updates. It seems, that all S205 are based on AMD platform called "Inagua" (E300, E350, E450), use two types of Wi-Fi cards (RaLink RT3090 and AR9285), various combination of SO DIMMs (2 x 1GB, 1 x 2GB, 2 x 2GB), different sizes of hardrives and different keyboard layouts; so overall there are pretty much the same.
> 
> There is a rare netbook called Lenovo Ideapad S205s ("s" at the end), but this one is based on Intel's processors [3].
> 
> My proposal is very simple:
> 
>     {
>          .callback = dmi_matched,
>          .ident = "Lenovo Ideapad S205",
>          .matches = {
>              DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> -            DMI_MATCH(DMI_PRODUCT_NAME, "10382LG"),
> +            DMI_MATCH(DMI_PRODUCT_VERSION, "Ideapad S205"),
>          },
>          .driver_data = &quirk_lenovo_ideapad_s205,
>      },
> 
> It works. We are not able to test all product names and if the checking of DMI_PRODUCT_NAME is really required, it should be done in an additional step. The current situation is pretty bad - problems with UEFI booting (the only possibility)[4], impossibility to switch the power off, failing brightness control - and without a functional network connection for a start, it is better to throw it out of the window.
> 
> [1] http://smolt.fedoraproject.org/reports/view_profiles?profile=Ideapad+S205&search=Submit+Query
> [2] http://www.manualowl.com/m/Lenovo/IdeaPad-S205/Manual/192357
> [3] http://www.manualowl.com/m/Lenovo/IdeaPad-S205s/Manual/227621
> [4] http://fedoraproject.org/wiki/Common_F16_bugs#UEFI_install_to_Lenovo_Ideapad_S205_fails_to_boot
> 
> 
> Best Regards
> 
> Vaclav Mocek
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205

[Vaclav Mocek]

On 03/14/2012 06:16 AM, Ike Panhc wrote:
> Hi Vaclav,
>
> Could you try this just-merged patch and see if it fix your problem?
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=461e74377cfcfc2c0d6bbdfa8fc5fbc21b052c2a

Hi Ike,

It looks like your patch effectively removes rfkill for all Lenovo's 
machines, except few hardcoded in acer_quirks[]. When I used F16 kernel 
and blacklisted acer-wmi module, it  didn't work; I am going to patch it 
and I will let you know.

Thanks.

Vaclav Mocek

Re: drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205

[Vaclav Mocek]

On 03/14/2012 06:16 AM, Ike Panhc wrote:
> Hi Vaclav,
>
> Could you try this just-merged patch and see if it fix your problem?
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=461e74377cfcfc2c0d6bbdfa8fc5fbc21b052c2a
Hi Ike,

tested, it doesn't work, basically it behaves as without your patch; my 
simple patch still works. If I understand correctly, you want to offload 
handling of rfkill to ideapad-laptop module. I will look into it during 
the weekend, any hint, what should I focus on? I am fairly new to this 
subsystem, it is quite complex and most of time I am spending studying 
how things work, which is nice, but it doesn't lead to immediate results.

BR

Vaclav M.

Re: drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205

[Ike Panhc]

On 03/16/2012 07:09 AM, Vaclav Mocek wrote:
> On 03/14/2012 06:16 AM, Ike Panhc wrote:
>> Hi Vaclav,
>>
>> Could you try this just-merged patch and see if it fix your problem?
>>
>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=461e74377cfcfc2c0d6bbdfa8fc5fbc21b052c2a
> Hi Ike,
> 
> tested, it doesn't work, basically it behaves as without your patch; my simple patch still works. If I understand correctly, you want to offload handling of rfkill to ideapad-laptop module. I will look into it during the weekend, any hint, what should I focus on? I am fairly new to this subsystem, it is quite complex and most of time I am spending studying how things work, which is nice, but it doesn't lead to immediate results.
> 
> BR
> 
> Vaclav M.
> -- 
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

What kernel version you use? Checked wiki and it might be 3.1 or 3.2.6. For 3.1 based kernel, you shall also backport this commit

  http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=1709adab0773616da7a8190f2762e599afb0a295

If this patch works properly, you shall see no 'acer-wireless' in `rfkill list` and you can unblock other rfkill for wifi. Then you shall be able to use your wireless.

If all rfkill is unblocked but you still can not use your wifi. Please post dmidecode here, I think, then, a possible approach is to consider to use DMI_PRODUCT_VERSION or add another DMI_PRODUCT_NAME in quirk.

Re: drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205

[Ike Panhc]

On 03/16/2012 11:46 AM, Ike Panhc wrote:
> On 03/16/2012 07:09 AM, Vaclav Mocek wrote:
>> On 03/14/2012 06:16 AM, Ike Panhc wrote:
>>> Hi Vaclav,
>>>
>>> Could you try this just-merged patch and see if it fix your problem?
>>>
>>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=461e74377cfcfc2c0d6bbdfa8fc5fbc21b052c2a
>> Hi Ike,
>>
>> tested, it doesn't work, basically it behaves as without your patch; my simple patch still works. If I understand correctly, you want to offload handling of rfkill to ideapad-laptop module. I will look into it during the weekend, any hint, what should I focus on? I am fairly new to this subsystem, it is quite complex and most of time I am spending studying how things work, which is nice, but it doesn't lead to immediate results.
>>
>> BR
>>
>> Vaclav M.
>> -- 
>> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 
> What kernel version you use? Checked wiki and it might be 3.1 or 3.2.6. For 3.1 based kernel, you shall also backport this commit
> 
>   http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=1709adab0773616da7a8190f2762e599afb0a295
> 
> If this patch works properly, you shall see no 'acer-wireless' in `rfkill list` and you can unblock other rfkill for wifi. Then you shall be able to use your wireless.
> 
> If all rfkill is unblocked but you still can not use your wifi. Please post dmidecode here, I think, then, a possible approach is to consider to use DMI_PRODUCT_VERSION or add another DMI_PRODUCT_NAME in quirk.
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

If you can put the dmidecode and acpidump somewhere I can reach, I can help with analysis the situation.

Re: drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205

[joeyli]

Hi Vaclav, 

於 三，2012-03-14 於 03:01 +0000，Vaclav Mocek 提到：
> Hi all,
> 
> I am an unhappy owner of Lenovo Ideapad S205 and the drivers in the 
> current development kernel (2f1c2b8) soft-blocks its Wi-Fi. S205 loads 
> two kernel modules - ideapad-laptop.c and acer-wmi.c. The rfkill is 
> controlled by acer-wmi.c and there is already a support for S205:
> 
>      {
>          .callback = dmi_matched,
>          .ident = "Lenovo Ideapad S205",
>          .matches = {
>              DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>              DMI_MATCH(DMI_PRODUCT_NAME, "10382LG"),
>          },
>          .driver_data = &quirk_lenovo_ideapad_s205,
>      },
> 
> Unfortunately, my netbook has a different DMI_PRODUCT_NAME - "Brazos" 
> instead of "10382LG" and there are at least eighteen possibilities [1]. 
> I spent some time Googling, comparing Smolt profiles, reading S205 
> Hardware Maintenance Manual [2]  and analysing the BIOS updates. It 
> seems, that all S205 are based on AMD platform called "Inagua" (E300, 
> E350, E450), use two types of Wi-Fi cards (RaLink RT3090 and AR9285), 
> various combination of SO DIMMs (2 x 1GB, 1 x 2GB, 2 x 2GB), different 
> sizes of hardrives and different keyboard layouts; so overall there are 
> pretty much the same.
> 
> There is a rare netbook called Lenovo Ideapad S205s ("s" at the end), 
> but this one is based on Intel's processors [3].
> 
> My proposal is very simple:
> 
>      {
>           .callback = dmi_matched,
>           .ident = "Lenovo Ideapad S205",
>           .matches = {
>               DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> -            DMI_MATCH(DMI_PRODUCT_NAME, "10382LG"),
> +            DMI_MATCH(DMI_PRODUCT_VERSION, "Ideapad S205"),
>           },
>           .driver_data = &quirk_lenovo_ideapad_s205,
>       },
> 
> It works. We are not able to test all product names and if the checking 
> of DMI_PRODUCT_NAME is really required, it should be done in an 
> additional step. The current situation is pretty bad - problems with 
> UEFI booting (the only possibility)[4], impossibility to switch the 
> power off, failing brightness control - and without a functional network 
> connection for a start, it is better to throw it out of the window.
> 
> [1] 
> http://smolt.fedoraproject.org/reports/view_profiles?profile=Ideapad+S205&search=Submit+Query
> [2] http://www.manualowl.com/m/Lenovo/IdeaPad-S205/Manual/192357
> [3] http://www.manualowl.com/m/Lenovo/IdeaPad-S205s/Manual/227621
> [4] 
> http://fedoraproject.org/wiki/Common_F16_bugs#UEFI_install_to_Lenovo_Ideapad_S205_fails_to_boot
> 
> 
> Best Regards
> 
> Vaclav Mocek
> 
> 

Thanks for your investigation!

I don't want change the dmi config for the already works machine, but
add your S205 "Brazos" to table is ok. 
Actually, that will be better ideapad-laptop driver can take care this
machine.

If you want, Please kindly try this patch.


Thanks a lot!
Joey Lee

From 02a341b8142f71190c09a1a4fe509922b8f055c4 Mon Sep 17 00:00:00 2001
From: "Lee, Chun-Yi" <jlee@suse.com>
Date: Fri, 16 Mar 2012 12:31:08 +0800
Subject: [PATCH] acer-wmi: add support Lenovo Ideapad S205 Brazos

acer-wmi: add support Lenovo Ideapad S205 Brazos

Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
 drivers/platform/x86/acer-wmi.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 1e5290b..f158956 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -468,6 +468,15 @@ static struct dmi_system_id acer_quirks[] = {
 	},
 	{
 		.callback = dmi_matched,
+		.ident = "Lenovo Ideapad S205",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Brazos"),
+		},
+		.driver_data = &quirk_lenovo_ideapad_s205,
+	},
+	{
+		.callback = dmi_matched,
 		.ident = "Lenovo 3000 N200",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-- 
1.7.7

Re: drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205

[Vaclav Mocek]

Hi Joey,

>
> If you want, Please kindly try this patch.
[Re]tested, it works. Actually, it was the first thing I tried, but 
after that I found out there are other sixteen known product names.

Vaclav M.
>
> Thanks a lot!
> Joey Lee
>
> > From 02a341b8142f71190c09a1a4fe509922b8f055c4 Mon Sep 17 00:00:00 2001
> From: "Lee, Chun-Yi"<jlee@suse.com>
> Date: Fri, 16 Mar 2012 12:31:08 +0800
> Subject: [PATCH] acer-wmi: add support Lenovo Ideapad S205 Brazos
>
> acer-wmi: add support Lenovo Ideapad S205 Brazos
>
> Signed-off-by: Lee, Chun-Yi<jlee@suse.com>
> ---
>   drivers/platform/x86/acer-wmi.c |    9 +++++++++
>   1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 1e5290b..f158956 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -468,6 +468,15 @@ static struct dmi_system_id acer_quirks[] = {
>   	},
>   	{
>   		.callback = dmi_matched,
> +		.ident = "Lenovo Ideapad S205",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Brazos"),
> +		},
> +		.driver_data =&quirk_lenovo_ideapad_s205,
> +	},
> +	{
> +		.callback = dmi_matched,
>   		.ident = "Lenovo 3000 N200",
>   		.matches = {
>   			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

Re: drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205

[joeyli]

Hi Vaclav, 

於 二，2012-03-20 於 00:45 +0000，Vaclav Mocek 提到：
> Hi Joey,
> 
> >
> > If you want, Please kindly try this patch.
> [Re]tested, it works. Actually, it was the first thing I tried, but 
> after that I found out there are other sixteen known product names.
> 
> Vaclav M.

Great! thanks for your testing.


Hi Ike, 

Do you want to handle this machine in ideapad-laptop driver? or I just
direct put this quirk to acer-wmi for wifi support?


Thanks
Joey Lee

> >
> > Thanks a lot!
> > Joey Lee
> >
> > > From 02a341b8142f71190c09a1a4fe509922b8f055c4 Mon Sep 17 00:00:00 2001
> > From: "Lee, Chun-Yi"<jlee@suse.com>
> > Date: Fri, 16 Mar 2012 12:31:08 +0800
> > Subject: [PATCH] acer-wmi: add support Lenovo Ideapad S205 Brazos
> >
> > acer-wmi: add support Lenovo Ideapad S205 Brazos
> >
> > Signed-off-by: Lee, Chun-Yi<jlee@suse.com>
> > ---
> >   drivers/platform/x86/acer-wmi.c |    9 +++++++++
> >   1 files changed, 9 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> > index 1e5290b..f158956 100644
> > --- a/drivers/platform/x86/acer-wmi.c
> > +++ b/drivers/platform/x86/acer-wmi.c
> > @@ -468,6 +468,15 @@ static struct dmi_system_id acer_quirks[] = {
> >   	},
> >   	{
> >   		.callback = dmi_matched,
> > +		.ident = "Lenovo Ideapad S205",
> > +		.matches = {
> > +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "Brazos"),
> > +		},
> > +		.driver_data =&quirk_lenovo_ideapad_s205,
> > +	},
> > +	{
> > +		.callback = dmi_matched,
> >   		.ident = "Lenovo 3000 N200",
> >   		.matches = {
> >   			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> 
> 

Re: drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205

[Ike Panhc]

On 03/20/2012 10:05 AM, joeyli wrote:
> Hi Vaclav, 
> 
> 於 二，2012-03-20 於 00:45 +0000，Vaclav Mocek 提到：
>> Hi Joey,
>>
>>>
>>> If you want, Please kindly try this patch.
>> [Re]tested, it works. Actually, it was the first thing I tried, but 
>> after that I found out there are other sixteen known product names.
>>
>> Vaclav M.
> 
> Great! thanks for your testing.
> 
> 
> Hi Ike, 
> 
> Do you want to handle this machine in ideapad-laptop driver? or I just
> direct put this quirk to acer-wmi for wifi support?
> 
> 
> Thanks
> Joey Lee
> 

ideapad-laptop has its own way to query soft block status, and it is not
to query from ec bits.

Please put this quirk in acer-wmi so that acer-wireless will report
correct soft block status.



>>>
>>> Thanks a lot!
>>> Joey Lee
>>>
>>>> From 02a341b8142f71190c09a1a4fe509922b8f055c4 Mon Sep 17 00:00:00 2001
>>> From: "Lee, Chun-Yi"<jlee@suse.com>
>>> Date: Fri, 16 Mar 2012 12:31:08 +0800
>>> Subject: [PATCH] acer-wmi: add support Lenovo Ideapad S205 Brazos
>>>
>>> acer-wmi: add support Lenovo Ideapad S205 Brazos
>>>
>>> Signed-off-by: Lee, Chun-Yi<jlee@suse.com>
>>> ---
>>>   drivers/platform/x86/acer-wmi.c |    9 +++++++++
>>>   1 files changed, 9 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>>> index 1e5290b..f158956 100644
>>> --- a/drivers/platform/x86/acer-wmi.c
>>> +++ b/drivers/platform/x86/acer-wmi.c
>>> @@ -468,6 +468,15 @@ static struct dmi_system_id acer_quirks[] = {
>>>   	},
>>>   	{
>>>   		.callback = dmi_matched,
>>> +		.ident = "Lenovo Ideapad S205",
>>> +		.matches = {
>>> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>>> +			DMI_MATCH(DMI_PRODUCT_NAME, "Brazos"),
>>> +		},
>>> +		.driver_data =&quirk_lenovo_ideapad_s205,
>>> +	},
>>> +	{
>>> +		.callback = dmi_matched,
>>>   		.ident = "Lenovo 3000 N200",
>>>   		.matches = {
>>>   			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>>
>>
> 
> 

Re: drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205

[joeyli]

Hi Vaclav, 

於 二，2012-03-20 於 11:03 +0800，Ike Panhc 提到：
> On 03/20/2012 10:05 AM, joeyli wrote:
> > Hi Vaclav, 
> > 
> > 於 二，2012-03-20 於 00:45 +0000，Vaclav Mocek 提到：
> >> Hi Joey,
> >>
> >>>
> >>> If you want, Please kindly try this patch.
> >> [Re]tested, it works. Actually, it was the first thing I tried, but 
> >> after that I found out there are other sixteen known product names.
> >>
> >> Vaclav M.
> > 
> > Great! thanks for your testing.
> > 

Because this quirk related to EC register, that's more safe we test then
put the machine to quirk one by one, even those machines have similar
product names.

Still very appreciate for your bug report and kindly testing. I will
send out patch, also add Cc. to you and Ike.


Thanks a lot!
Joey Lee

> > 
> > Hi Ike, 
> > 
> > Do you want to handle this machine in ideapad-laptop driver? or I just
> > direct put this quirk to acer-wmi for wifi support?
> > 
> > 
> > Thanks
> > Joey Lee
> > 
> 
> ideapad-laptop has its own way to query soft block status, and it is not
> to query from ec bits.
> 
> Please put this quirk in acer-wmi so that acer-wireless will report
> correct soft block status.
> 
> 
> 
> >>>
> >>> Thanks a lot!
> >>> Joey Lee
> >>>
> >>>> From 02a341b8142f71190c09a1a4fe509922b8f055c4 Mon Sep 17 00:00:00 2001
> >>> From: "Lee, Chun-Yi"<jlee@suse.com>
> >>> Date: Fri, 16 Mar 2012 12:31:08 +0800
> >>> Subject: [PATCH] acer-wmi: add support Lenovo Ideapad S205 Brazos
> >>>
> >>> acer-wmi: add support Lenovo Ideapad S205 Brazos
> >>>
> >>> Signed-off-by: Lee, Chun-Yi<jlee@suse.com>
> >>> ---
> >>>   drivers/platform/x86/acer-wmi.c |    9 +++++++++
> >>>   1 files changed, 9 insertions(+), 0 deletions(-)
> >>>
> >>> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> >>> index 1e5290b..f158956 100644
> >>> --- a/drivers/platform/x86/acer-wmi.c
> >>> +++ b/drivers/platform/x86/acer-wmi.c
> >>> @@ -468,6 +468,15 @@ static struct dmi_system_id acer_quirks[] = {
> >>>   	},
> >>>   	{
> >>>   		.callback = dmi_matched,
> >>> +		.ident = "Lenovo Ideapad S205",
> >>> +		.matches = {
> >>> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> >>> +			DMI_MATCH(DMI_PRODUCT_NAME, "Brazos"),
> >>> +		},
> >>> +		.driver_data =&quirk_lenovo_ideapad_s205,
> >>> +	},
> >>> +	{
> >>> +		.callback = dmi_matched,
> >>>   		.ident = "Lenovo 3000 N200",
> >>>   		.matches = {
> >>>   			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> >>
> >>
> > 
> > 
> 
>