From: "Andreas Färber" <andreas.faerber@web.de>
To: Lee Essen <lee.essen@nowonline.co.uk>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool
Date: Fri, 16 Mar 2012 13:44:05 +0100 [thread overview]
Message-ID: <4F633595.5060608@web.de> (raw)
In-Reply-To: <541C8B7E-1E25-479E-B69E-A4B58BFA45F3@nowonline.co.uk>
Am 16.03.2012 13:29, schrieb Lee Essen:
> Signed-off-by: Lee Essen <lee.essen@nowonline.co.uk>
>
> ---
>
> scripts/tracetool | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/tracetool b/scripts/tracetool
> index 65bd0a1..2e43d05 100755
> --- a/scripts/tracetool
> +++ b/scripts/tracetool
> @@ -123,7 +123,7 @@ get_argc()
> # Get the format string including double quotes for a trace event
> get_fmt()
> {
> - puts "${1#*)}"
> + puts "${1#*}"
> }
>
> linetoh_begin_nop()
>
Cc'ing the trace maintainer. I assume Lee forgot to look up the
maintainer, but Stefan, my checking MAINTAINERS indicates tracetool is
missing in the Tracing section too. Could you add it please?
Not being a shell expert I can't judge what this is actually trying to
do. Note that there is also an effort underway to rewrite tracetool as
tracetool.py.
Andreas
next prev parent reply other threads:[~2012-03-16 12:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 12:29 [Qemu-devel] [PATCH] fix incorrect bracket in tracetool Lee Essen
2012-03-16 12:44 ` Andreas Färber [this message]
2012-03-16 13:00 ` Lee Essen
2012-03-16 13:19 ` Paolo Bonzini
2012-03-16 13:28 ` Andreas Färber
2012-03-16 13:21 ` Andreas Färber
2012-03-16 13:18 ` Paolo Bonzini
2012-03-16 14:56 ` Eric Blake
2012-03-19 11:59 ` Stefan Hajnoczi
2012-03-19 12:05 ` Lee Essen
2012-03-19 12:32 ` Stefan Hajnoczi
2012-03-19 12:32 ` Andreas Färber
2012-03-19 13:35 ` Lee Essen
2012-03-20 16:59 ` Stefan Hajnoczi
2012-03-20 17:11 ` Lee Essen
2012-03-21 9:52 ` Stefan Hajnoczi
2012-03-19 12:40 ` Stefan Weil
2012-03-19 12:49 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F633595.5060608@web.de \
--to=andreas.faerber@web.de \
--cc=lee.essen@nowonline.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.