From: Lee Essen <lee.essen@nowonline.co.uk>
To: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool
Date: Tue, 20 Mar 2012 17:11:18 +0000 [thread overview]
Message-ID: <4F68BA36.8010203@nowonline.co.uk> (raw)
In-Reply-To: <CAJSP0QWHjXEgCCrtwvfzTFaje2jg1t3HF8xBFm132kVXXQJKJg@mail.gmail.com>
On 20/03/2012 16:59, Stefan Hajnoczi wrote:
> On Mon, Mar 19, 2012 at 1:35 PM, Lee Essen<lee.essen@nowonline.co.uk> wrote:
>> On 19 Mar 2012, at 12:32, Andreas Färber wrote:
>>
>>> Am 19.03.2012 13:05, schrieb Lee Essen:
>>> In my original (way-too-long) patch for Illumos I included fixes for
>>> both of the above, the approach I took was to map "bool" to "int"
>>> and "self" to "_self" in the dtrace part of tracetool. So it should
>>> have had no impact on any non-dtrace stuff. If that seems like a
>>> sensible approach I will look again, and at the linking issues.
> That sounds like it can work.
>
> Stefan
There are only 5 bool's and 4 self's in the whole of the trace-events
file ... is it easier to "fix" in there, or do you think a change to
tracetool is the most appropriate way?
Lee.
next prev parent reply other threads:[~2012-03-20 17:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 12:29 [Qemu-devel] [PATCH] fix incorrect bracket in tracetool Lee Essen
2012-03-16 12:44 ` Andreas Färber
2012-03-16 13:00 ` Lee Essen
2012-03-16 13:19 ` Paolo Bonzini
2012-03-16 13:28 ` Andreas Färber
2012-03-16 13:21 ` Andreas Färber
2012-03-16 13:18 ` Paolo Bonzini
2012-03-16 14:56 ` Eric Blake
2012-03-19 11:59 ` Stefan Hajnoczi
2012-03-19 12:05 ` Lee Essen
2012-03-19 12:32 ` Stefan Hajnoczi
2012-03-19 12:32 ` Andreas Färber
2012-03-19 13:35 ` Lee Essen
2012-03-20 16:59 ` Stefan Hajnoczi
2012-03-20 17:11 ` Lee Essen [this message]
2012-03-21 9:52 ` Stefan Hajnoczi
2012-03-19 12:40 ` Stefan Weil
2012-03-19 12:49 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F68BA36.8010203@nowonline.co.uk \
--to=lee.essen@nowonline.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.