* + drivers-platform-x86-samsung-laptopc-fix-build.patch added to -mm tree
@ 2012-03-16 22:53 akpm
2012-03-17 3:41 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: akpm @ 2012-03-16 22:53 UTC (permalink / raw)
To: mm-commits; +Cc: akpm, corentincj, mjg
The patch titled
Subject: drivers/platform/x86/samsung-laptop.c: fix build
has been added to the -mm tree. Its filename is
drivers-platform-x86-samsung-laptopc-fix-build.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: drivers/platform/x86/samsung-laptop.c: fix build
gcc-4.4.4:
drivers/platform/x86/samsung-laptop.c: In function 'sabi_set_commandb':
drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd0' specified in initializer
drivers/platform/x86/samsung-laptop.c:433: warning: missing braces around initializer
drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in.<anonymous>')
drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd1' specified in initializer
drivers/platform/x86/samsung-laptop.c:433: warning: excess elements in struct initializer
drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in')
drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd2' specified in initializer
drivers/platform/x86/samsung-laptop.c:433: warning: excess elements in struct initializer
drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in')
drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd3' specified in initializer
drivers/platform/x86/samsung-laptop.c:433: warning: excess elements in struct initializer
drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in')
drivers/platform/x86/samsung-laptop.c: At top level:
drivers/platform/x86/samsung-laptop.c:1108: warning: initialization from incompatible pointer type
Cc: Corentin Chary <corentincj@iksaif.net>
Cc: Matthew Garrett <mjg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/platform/x86/samsung-laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/platform/x86/samsung-laptop.c~drivers-platform-x86-samsung-laptopc-fix-build drivers/platform/x86/samsung-laptop.c
--- a/drivers/platform/x86/samsung-laptop.c~drivers-platform-x86-samsung-laptopc-fix-build
+++ a/drivers/platform/x86/samsung-laptop.c
@@ -430,7 +430,7 @@ exit:
static int sabi_set_commandb(struct samsung_laptop *samsung,
u16 command, u8 data)
{
- struct sabi_data in = { .d0 = 0, .d1 = 0, .d2 = 0, .d3 = 0 };
+ struct sabi_data in = { { { .d0 = 0, .d1 = 0, .d2 = 0, .d3 = 0 } } };
in.data[0] = data;
return sabi_command(samsung, command, &in, NULL);
_
Subject: Subject: drivers/platform/x86/samsung-laptop.c: fix build
Patches currently in -mm which might be from akpm@linux-foundation.org are
origin.patch
linux-next.patch
linux-next-git-rejects.patch
i-need-old-gcc.patch
arch-alpha-kernel-systblss-remove-debug-check.patch
drivers-block-nvmec-stop-breaking-my-i386-build.patch
drivers-mfd-twl-corec-wtf-isnt-this-fixed-yet.patch
drivers-mfd-twl-corec-unbork.patch
drivers-staging-zsmalloc-zsmalloc-mainc-unbork.patch
mm-thp-fix-pmd_bad-triggering-in-code-paths-holding-mmap_sem-read-mode-checkpatch-fixes.patch
arch-x86-platform-iris-irisc-register-a-platform-device-and-a-platform-driver.patch
x86-use-this_cpu_xxx-to-replace-percpu_xxx-funcs.patch
percpu-remove-percpu_xxx-functions-fix.patch
drivers-media-video-uvc-uvc_driverc-use-linux-atomich.patch
thermal-thermal_sys-fix-build-warning.patch
thermal-add-support-for-thermal-sensor-present-on-spear13xx-machines.patch
net-netfilter-nfnetlink_acctc-use-linux-atomich.patch
brlocks-lglocks-cleanups.patch
fs-symlink-restrictions-on-sticky-directories.patch
fs-hardlink-creation-restrictions-fix.patch
mm.patch
make-swapin-readahead-skip-over-holes-fix.patch
vmscan-kswapd-carefully-call-compaction-fix.patch
mm-compaction-make-compact_control-order-signed-fix.patch
hugetlb-try-to-search-again-if-it-is-really-needed-fix.patch
thp-optimize-away-unnecessary-page-table-locking-fix-checkpatch-fixes.patch
mm-vmscan-forcibly-scan-highmem-if-there-are-too-many-buffer_heads-pinning-highmem-fix-fix.patch
procfs-mark-thread-stack-correctly-in-proc-pid-maps.patch
procfs-mark-thread-stack-correctly-in-proc-pid-maps-v3-checkpatch-fixes.patch
mm-fix-move-migrate_pages-race-on-task-struct-checkpatch-fixes.patch
bootmem-sparsemem-remove-limit-constraint-in-alloc_bootmem_section-fix.patch
hugetlbfs-return-error-code-when-initializing-module-fix.patch
mm-add-extra-free-kbytes-tunable-update-checkpatch-fixes.patch
memcg-remove-pcg_cache-page_cgroup-flag-checkpatch-fixes.patch
memcg-simplify-move_account-check-fix.patch
memcg-use-new-logic-for-page-stat-accounting-fix.patch
memcg-fix-performance-of-mem_cgroup_begin_update_page_stat-fix.patch
mm-memcontrolc-s-stealed-stolen.patch
cpuidle-add-a-sysfs-entry-to-disable-specific-c-state-for-debug-purpose-fix.patch
prctl-add-pr_setget_child_subreaper-to-allow-simple-process-supervision-fix.patch
prctl-add-pr_setget_child_subreaper-to-allow-simple-process-supervision-fix-fix.patch
kernel-exitc-if-init-dies-log-a-signal-which-killed-it-if-any-fix.patch
arch-powerpc-platforms-pseries-eeh_eventc-slightly-fix-set_current_state-wart.patch
kernel-watchdogc-convert-to-pr_foo.patch
smp-start-up-non-boot-cpus-asynchronously-fix.patch
backlight-add-driver-for-bachmanns-ot200-fix.patch
leds-lp5521-support-led-pattern-data-checkpatch-fixes.patch
drivers-leds-leds-lp5523c-constify-some-data.patch
drivers-leds-add-driver-for-pca9663-i2c-chip-fix.patch
leds-lm3530-replace-i2c_client-with-led_classdev-fix.patch
drivers-leds-leds-lm3530c-move-the-code-setting-gen_config-to-one-place-fix.patch
crc32-move-long-comment-about-crc32-fundamentals-to-documentation-fix.patch
rtc-rtc-driver-for-da9052-53-pmic-v1-fix.patch
kmod-avoid-deadlock-by-recursive-kmod-call-fix.patch
coredump-add-vm_nodump-madv_nodump-madv_clear_nodump-fix.patch
procfs-add-num_to_str-to-speed-up-proc-stat-fix.patch
procfs-speed-up-proc-pid-stat-statm-checkpatch-fixes.patch
seq_file-add-seq_set_overflow-seq_overflow-fix.patch
smp-add-func-to-ipi-cpus-based-on-parameter-func-fix.patch
smp-add-func-to-ipi-cpus-based-on-parameter-func-update-fix.patch
smp-add-func-to-ipi-cpus-based-on-parameter-func-v9.patch
smp-add-func-to-ipi-cpus-based-on-parameter-func-v9-fix.patch
pidns-add-reboot_pid_ns-to-handle-the-reboot-syscall-fix.patch
pidns-add-reboot_pid_ns-to-handle-the-reboot-syscall-checkpatch-fixes.patch
fs-proc-namespacesc-prevent-crash-when-ns_entries-is-empty.patch
radix-tree-introduce-bit-optimized-iterator-checkpatch-fixes.patch
selftests-makefile-make-run_tests-depend-on-all.patch
move-hugepage-test-examples-to-tools-testing-selftests-vm-fix.patch
move-hugepage-test-examples-to-tools-testing-selftests-vm-fix-fix.patch
syscalls-x86-add-__nr_kcmp-syscall-v8.patch
syscalls-x86-add-__nr_kcmp-syscall-v8-fix.patch
syscalls-x86-add-__nr_kcmp-syscall-v8-fix-2.patch
notify_change-check-that-i_mutex-is-held.patch
journal_add_journal_head-debug.patch
mutex-subsystem-synchro-test-module-fix.patch
slab-leaks3-default-y.patch
put_bh-debug.patch
drivers-platform-x86-samsung-laptopc-fix-build.patch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: + drivers-platform-x86-samsung-laptopc-fix-build.patch added to -mm tree
2012-03-16 22:53 + drivers-platform-x86-samsung-laptopc-fix-build.patch added to -mm tree akpm
@ 2012-03-17 3:41 ` Randy Dunlap
2012-03-17 3:44 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2012-03-17 3:41 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, mm-commits, corentincj, mjg, reintjes
On 03/16/2012 03:53 PM, akpm@linux-foundation.org wrote:
> The patch titled
> Subject: drivers/platform/x86/samsung-laptop.c: fix build
> has been added to the -mm tree. Its filename is
> drivers-platform-x86-samsung-laptopc-fix-build.patch
>
See https://lkml.org/lkml/2012/3/14/25
and https://lkml.org/lkml/2012/3/14/27
from David Reintjes.
>
> ------------------------------------------------------
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: drivers/platform/x86/samsung-laptop.c: fix build
>
> gcc-4.4.4:
>
> drivers/platform/x86/samsung-laptop.c: In function 'sabi_set_commandb':
> drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd0' specified in initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: missing braces around initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in.<anonymous>')
> drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd1' specified in initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: excess elements in struct initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in')
> drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd2' specified in initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: excess elements in struct initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in')
> drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd3' specified in initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: excess elements in struct initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in')
> drivers/platform/x86/samsung-laptop.c: At top level:
> drivers/platform/x86/samsung-laptop.c:1108: warning: initialization from incompatible pointer type
>
> Cc: Corentin Chary <corentincj@iksaif.net>
> Cc: Matthew Garrett <mjg@redhat.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/platform/x86/samsung-laptop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/platform/x86/samsung-laptop.c~drivers-platform-x86-samsung-laptopc-fix-build drivers/platform/x86/samsung-laptop.c
> --- a/drivers/platform/x86/samsung-laptop.c~drivers-platform-x86-samsung-laptopc-fix-build
> +++ a/drivers/platform/x86/samsung-laptop.c
> @@ -430,7 +430,7 @@ exit:
> static int sabi_set_commandb(struct samsung_laptop *samsung,
> u16 command, u8 data)
> {
> - struct sabi_data in = { .d0 = 0, .d1 = 0, .d2 = 0, .d3 = 0 };
> + struct sabi_data in = { { { .d0 = 0, .d1 = 0, .d2 = 0, .d3 = 0 } } };
>
> in.data[0] = data;
> return sabi_command(samsung, command, &in, NULL);
> _
> Subject: Subject: drivers/platform/x86/samsung-laptop.c: fix build
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: + drivers-platform-x86-samsung-laptopc-fix-build.patch added to -mm tree
2012-03-17 3:41 ` Randy Dunlap
@ 2012-03-17 3:44 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2012-03-17 3:44 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, mm-commits, corentincj, mjg, rientjes
On 03/16/2012 08:41 PM, Randy Dunlap wrote:
> On 03/16/2012 03:53 PM, akpm@linux-foundation.org wrote:
>
>> The patch titled
>> Subject: drivers/platform/x86/samsung-laptop.c: fix build
>> has been added to the -mm tree. Its filename is
>> drivers-platform-x86-samsung-laptopc-fix-build.patch
>>
>
>
> See https://lkml.org/lkml/2012/3/14/25
> and https://lkml.org/lkml/2012/3/14/27
> from David Reintjes.
Make that David Rientjes...
>
>
>>
>> ------------------------------------------------------
>> From: Andrew Morton <akpm@linux-foundation.org>
>> Subject: drivers/platform/x86/samsung-laptop.c: fix build
>>
>> gcc-4.4.4:
>>
>> drivers/platform/x86/samsung-laptop.c: In function 'sabi_set_commandb':
>> drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd0' specified in initializer
>> drivers/platform/x86/samsung-laptop.c:433: warning: missing braces around initializer
>> drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in.<anonymous>')
>> drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd1' specified in initializer
>> drivers/platform/x86/samsung-laptop.c:433: warning: excess elements in struct initializer
>> drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in')
>> drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd2' specified in initializer
>> drivers/platform/x86/samsung-laptop.c:433: warning: excess elements in struct initializer
>> drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in')
>> drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd3' specified in initializer
>> drivers/platform/x86/samsung-laptop.c:433: warning: excess elements in struct initializer
>> drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in')
>> drivers/platform/x86/samsung-laptop.c: At top level:
>> drivers/platform/x86/samsung-laptop.c:1108: warning: initialization from incompatible pointer type
>>
>> Cc: Corentin Chary <corentincj@iksaif.net>
>> Cc: Matthew Garrett <mjg@redhat.com>
>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>> ---
>>
>> drivers/platform/x86/samsung-laptop.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff -puN drivers/platform/x86/samsung-laptop.c~drivers-platform-x86-samsung-laptopc-fix-build drivers/platform/x86/samsung-laptop.c
>> --- a/drivers/platform/x86/samsung-laptop.c~drivers-platform-x86-samsung-laptopc-fix-build
>> +++ a/drivers/platform/x86/samsung-laptop.c
>> @@ -430,7 +430,7 @@ exit:
>> static int sabi_set_commandb(struct samsung_laptop *samsung,
>> u16 command, u8 data)
>> {
>> - struct sabi_data in = { .d0 = 0, .d1 = 0, .d2 = 0, .d3 = 0 };
>> + struct sabi_data in = { { { .d0 = 0, .d1 = 0, .d2 = 0, .d3 = 0 } } };
>>
>> in.data[0] = data;
>> return sabi_command(samsung, command, &in, NULL);
>> _
>> Subject: Subject: drivers/platform/x86/samsung-laptop.c: fix build
>
>
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-17 3:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-16 22:53 + drivers-platform-x86-samsung-laptopc-fix-build.patch added to -mm tree akpm
2012-03-17 3:41 ` Randy Dunlap
2012-03-17 3:44 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.