From: Mark Lord <kernel@teksavvy.com>
To: Shaohua Li <shli@kernel.org>
Cc: NeilBrown <neilb@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [patch 0/7] Add TRIM support for raid linear/0/1/10
Date: Sat, 17 Mar 2012 14:14:43 -0400 [thread overview]
Message-ID: <4F64D493.9010404@teksavvy.com> (raw)
In-Reply-To: <4F6006C3.4010204@kernel.org>
On 12-03-13 10:47 PM, Shaohua Li wrote:
> On 3/14/12 10:24 AM, NeilBrown wrote:
>> On Mon, 12 Mar 2012 11:04:12 +0800 Shaohua Li <shli@fusionio.com> wrote:
..
>> Also I wonder about handling failure in RAID1.
>> I think the code will currently treat it like a write error, and
>> maybe record a bad block (then fail the device is writing the badblock
>> record fails). Is that what were want?
> Mainly to simplify the code. And I thought a normal discard should not fail.
> If it fails, something is wrong, marked it as badblock maybe not bad.
That sounds like a VERY bad idea.
Failures happen for lots of reasons,
but generic comm errors are not an excuse to suddenly mark sectors as bad.
next prev parent reply other threads:[~2012-03-17 18:14 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 3:04 [patch 0/7] Add TRIM support for raid linear/0/1/10 Shaohua Li
2012-03-12 3:04 ` [patch 1/7] block: makes bio_split support bio without data Shaohua Li
2012-03-12 3:04 ` [patch 2/7] md: linear supports TRIM Shaohua Li
2012-03-12 3:04 ` [patch 3/7] md: raid 0 " Shaohua Li
2012-03-12 3:04 ` [patch 4/7] md: raid 1 " Shaohua Li
2012-03-12 3:04 ` [patch 5/7] md: raid 10 " Shaohua Li
2012-03-12 3:04 ` [patch 6/7] blk: add plug for blkdev_issue_discard Shaohua Li
2012-03-13 15:51 ` Vivek Goyal
2012-03-13 15:51 ` Vivek Goyal
2012-03-13 17:04 ` Martin K. Petersen
2012-03-13 17:14 ` Vivek Goyal
2012-03-13 17:19 ` Martin K. Petersen
2012-03-12 3:04 ` [patch 7/7] blk: use correct sectors limitation for discard request Shaohua Li
2012-03-13 16:00 ` Vivek Goyal
2012-03-13 16:00 ` Vivek Goyal
2012-03-12 3:18 ` [patch 0/7] Add TRIM support for raid linear/0/1/10 Roberto Spadim
2012-03-12 3:18 ` Roberto Spadim
2012-03-12 18:22 ` Holger Kiehl
[not found] ` <4F5EFEB6.4060402@kernel.org>
2012-03-13 12:22 ` Holger Kiehl
2012-03-13 14:15 ` Shaohua Li
2012-03-13 14:15 ` Shaohua Li
2012-03-13 14:58 ` Roberto Spadim
2012-03-13 14:58 ` Roberto Spadim
2012-03-13 15:44 ` Holger Kiehl
2012-03-14 1:30 ` Shaohua Li
2012-03-14 10:25 ` Holger Kiehl
2012-03-14 11:14 ` Shaohua Li
2012-03-14 11:14 ` Shaohua Li
2012-03-14 11:32 ` Shaohua Li
2012-03-14 21:01 ` Holger Kiehl
2012-03-14 21:13 ` Holger Kiehl
2012-03-15 2:39 ` Shaohua Li
2012-03-15 9:08 ` Holger Kiehl
2012-03-16 2:19 ` Shaohua Li
[not found] ` <4F5EA8E9.5010502@fusionio.com>
2012-03-14 2:25 ` NeilBrown
2012-03-14 2:25 ` NeilBrown
2012-03-14 2:24 ` NeilBrown
2012-03-14 2:47 ` Shaohua Li
2012-03-17 18:14 ` Mark Lord [this message]
2012-03-18 2:03 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F64D493.9010404@teksavvy.com \
--to=kernel@teksavvy.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.