All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
	neilb@suse.de, axboe@kernel.dk, Shaohua Li <shli@fusionio.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [patch 6/7] blk: add plug for blkdev_issue_discard
Date: Tue, 13 Mar 2012 11:51:20 -0400	[thread overview]
Message-ID: <20120313155120.GG29169@redhat.com> (raw)
In-Reply-To: <20120312031305.946211513@fusionio.com>

On Mon, Mar 12, 2012 at 11:04:18AM +0800, Shaohua Li wrote:
> In raid 0 case, a big discard request is divided into several small requests
> in chunk_size unit. Such requests can be merged in low layer if we have
> correct plug added. This should improve the performance a little bit.

Martin posted a patch to remove the support for allowing merging of discard
requests. But this seems to be a reasonable use case for allowing mering
discard requests. CCing Martin.

Thanks
Vivek

WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Shaohua Li <shli@fusionio.com>
Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
	neilb@suse.de, axboe@kernel.dk, Shaohua Li <shli@fusionio.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [patch 6/7] blk: add plug for blkdev_issue_discard
Date: Tue, 13 Mar 2012 11:51:20 -0400	[thread overview]
Message-ID: <20120313155120.GG29169@redhat.com> (raw)
In-Reply-To: <20120312031305.946211513@fusionio.com>

On Mon, Mar 12, 2012 at 11:04:18AM +0800, Shaohua Li wrote:
> In raid 0 case, a big discard request is divided into several small requests
> in chunk_size unit. Such requests can be merged in low layer if we have
> correct plug added. This should improve the performance a little bit.

Martin posted a patch to remove the support for allowing merging of discard
requests. But this seems to be a reasonable use case for allowing mering
discard requests. CCing Martin.

Thanks
Vivek

  reply	other threads:[~2012-03-13 15:51 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-12  3:04 [patch 0/7] Add TRIM support for raid linear/0/1/10 Shaohua Li
2012-03-12  3:04 ` [patch 1/7] block: makes bio_split support bio without data Shaohua Li
2012-03-12  3:04 ` [patch 2/7] md: linear supports TRIM Shaohua Li
2012-03-12  3:04 ` [patch 3/7] md: raid 0 " Shaohua Li
2012-03-12  3:04 ` [patch 4/7] md: raid 1 " Shaohua Li
2012-03-12  3:04 ` [patch 5/7] md: raid 10 " Shaohua Li
2012-03-12  3:04 ` [patch 6/7] blk: add plug for blkdev_issue_discard Shaohua Li
2012-03-13 15:51   ` Vivek Goyal [this message]
2012-03-13 15:51     ` Vivek Goyal
2012-03-13 17:04     ` Martin K. Petersen
2012-03-13 17:14       ` Vivek Goyal
2012-03-13 17:19         ` Martin K. Petersen
2012-03-12  3:04 ` [patch 7/7] blk: use correct sectors limitation for discard request Shaohua Li
2012-03-13 16:00   ` Vivek Goyal
2012-03-13 16:00     ` Vivek Goyal
2012-03-12  3:18 ` [patch 0/7] Add TRIM support for raid linear/0/1/10 Roberto Spadim
2012-03-12  3:18   ` Roberto Spadim
2012-03-12 18:22 ` Holger Kiehl
     [not found]   ` <4F5EFEB6.4060402@kernel.org>
2012-03-13 12:22     ` Holger Kiehl
2012-03-13 14:15       ` Shaohua Li
2012-03-13 14:15         ` Shaohua Li
2012-03-13 14:58         ` Roberto Spadim
2012-03-13 14:58           ` Roberto Spadim
2012-03-13 15:44         ` Holger Kiehl
2012-03-14  1:30           ` Shaohua Li
2012-03-14 10:25             ` Holger Kiehl
2012-03-14 11:14               ` Shaohua Li
2012-03-14 11:14                 ` Shaohua Li
2012-03-14 11:32                 ` Shaohua Li
2012-03-14 21:01                   ` Holger Kiehl
2012-03-14 21:13                 ` Holger Kiehl
2012-03-15  2:39                   ` Shaohua Li
2012-03-15  9:08                     ` Holger Kiehl
2012-03-16  2:19                       ` Shaohua Li
     [not found]   ` <4F5EA8E9.5010502@fusionio.com>
2012-03-14  2:25     ` NeilBrown
2012-03-14  2:25       ` NeilBrown
2012-03-14  2:24 ` NeilBrown
2012-03-14  2:47   ` Shaohua Li
2012-03-17 18:14     ` Mark Lord
2012-03-18  2:03       ` Shaohua Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120313155120.GG29169@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=neilb@suse.de \
    --cc=shli@fusionio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.