All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Thilo Cestonaro <thilo.cestonaro@ts.fujitsu.com>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH] hwmon/sch56xx: Add support for the integrated watchdog (v2)
Date: Mon, 19 Mar 2012 11:02:08 +0100	[thread overview]
Message-ID: <4F670420.4090906@redhat.com> (raw)
In-Reply-To: <20120318215015.GA28033@ericsson.com>

Hi,

On 03/18/2012 10:50 PM, Guenter Roeck wrote:
> On Sun, Mar 18, 2012 at 08:17:03AM -0400, Guenter Roeck wrote:
>> On Sun, Mar 18, 2012 at 08:05:08AM -0400, Hans de Goede wrote:
>>> Add support for the watchdog integrated into the SMSC SCH5627 and
>>> SCH5636 superio-s. Since the watchdog is part of the hwmon logical device
>>> and thus shares ioports with it, the watchdog driver is integrated into the
>>> existing hwmon drivers for these.
>>>
>>> Note that this version of the watchdog support for sch56xx superio-s
>>> implements the watchdog chardev interface itself, rather then relying on
>>> the recently added watchdog core / watchdog_dev. This is done because
>>> currently some needed functionality is missing from watchdog_dev, as soon
>>> as this functionality is added (which is being discussed on the
>>> linux-watchdog mailinglist), I'll convert this driver over to using
>>> watchdog_dev.
>>>
>>> Changes in v2:
>>> -fix checkpatch complaints
>>> -follow multi-line comment style guidelines
>>>
>>> Signed-off-by: Hans de Goede<hdegoede@redhat.com>
>>
>> You are too fast ;-). Unfortunately, we'll need v3, with the slab.h include.
>>
> Forget v3 - I added the include myself and applied the patch. Not worth missing
> the commit window due to a missing include.

Thanks!

Regards,

Hans

WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Thilo Cestonaro <thilo.cestonaro@ts.fujitsu.com>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH] hwmon/sch56xx: Add support for the integrated watchdog (v2)
Date: Mon, 19 Mar 2012 10:02:08 +0000	[thread overview]
Message-ID: <4F670420.4090906@redhat.com> (raw)
In-Reply-To: <20120318215015.GA28033@ericsson.com>

Hi,

On 03/18/2012 10:50 PM, Guenter Roeck wrote:
> On Sun, Mar 18, 2012 at 08:17:03AM -0400, Guenter Roeck wrote:
>> On Sun, Mar 18, 2012 at 08:05:08AM -0400, Hans de Goede wrote:
>>> Add support for the watchdog integrated into the SMSC SCH5627 and
>>> SCH5636 superio-s. Since the watchdog is part of the hwmon logical device
>>> and thus shares ioports with it, the watchdog driver is integrated into the
>>> existing hwmon drivers for these.
>>>
>>> Note that this version of the watchdog support for sch56xx superio-s
>>> implements the watchdog chardev interface itself, rather then relying on
>>> the recently added watchdog core / watchdog_dev. This is done because
>>> currently some needed functionality is missing from watchdog_dev, as soon
>>> as this functionality is added (which is being discussed on the
>>> linux-watchdog mailinglist), I'll convert this driver over to using
>>> watchdog_dev.
>>>
>>> Changes in v2:
>>> -fix checkpatch complaints
>>> -follow multi-line comment style guidelines
>>>
>>> Signed-off-by: Hans de Goede<hdegoede@redhat.com>
>>
>> You are too fast ;-). Unfortunately, we'll need v3, with the slab.h include.
>>
> Forget v3 - I added the include myself and applied the patch. Not worth missing
> the commit window due to a missing include.

Thanks!

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2012-03-19 10:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-18 12:05 [PATCH] hwmon/sch56xx: Add support for the integrated watchdog (v2) Hans de Goede
2012-03-18 12:05 ` [lm-sensors] " Hans de Goede
2012-03-18 12:17 ` Guenter Roeck
2012-03-18 12:17   ` Guenter Roeck
2012-03-18 21:50   ` Guenter Roeck
2012-03-18 21:50     ` Guenter Roeck
2012-03-19 10:02     ` Hans de Goede [this message]
2012-03-19 10:02       ` Hans de Goede
  -- strict thread matches above, loose matches on Subject: below --
2012-03-17  9:40 [PATCH 0/1] hwmon/sch56xx: Add support for the integrated watchdog Hans de Goede
2012-03-17  9:40 ` [lm-sensors] " Hans de Goede
2012-03-17  9:40 ` [PATCH] " Hans de Goede
2012-03-17  9:40   ` [lm-sensors] " Hans de Goede
2012-03-17 18:58   ` Guenter Roeck
2012-03-17 18:58     ` Guenter Roeck
2012-03-18 12:03     ` Hans de Goede
2012-03-18 12:03       ` Hans de Goede
2012-03-18 12:14       ` Guenter Roeck
2012-03-18 12:14         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F670420.4090906@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=guenter.roeck@ericsson.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=thilo.cestonaro@ts.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.