All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: LM Sensors <lm-sensors@lm-sensors.org>,
	Thilo Cestonaro <thilo.cestonaro@ts.fujitsu.com>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Subject: Re: [lm-sensors] [PATCH] hwmon/sch56xx: Add support for the integrated watchdog
Date: Sun, 18 Mar 2012 05:14:07 -0700	[thread overview]
Message-ID: <20120318121407.GA26167@ericsson.com> (raw)
In-Reply-To: <4F65CF2C.4000205@redhat.com>

Hi Hans,

On Sun, Mar 18, 2012 at 08:03:56AM -0400, Hans de Goede wrote:
[ ... ]
> >> +
> >> +       data = kzalloc(sizeof(struct sch56xx_watchdog_data), GFP_KERNEL);
> >> +       if (!data)
> >> +               return NULL;
> >> +

One more:

You don't include slab.h, which in some configurations results in:

/tmp/linux.15278/drivers/hwmon/sch56xx-common.c: In function 'sch56xx_watchdog_release_resources':
/tmp/linux.15278/drivers/hwmon/sch56xx-common.c:278: error: implicit declaration of function 'kfree'
/tmp/linux.15278/drivers/hwmon/sch56xx-common.c: In function 'sch56xx_watchdog_register':
/tmp/linux.15278/drivers/hwmon/sch56xx-common.c:644: error: implicit declaration of function 'kzalloc'
/tmp/linux.15278/drivers/hwmon/sch56xx-common.c:644: warning: assignment makes pointer from integer without a cast
make[3]: *** [drivers/hwmon/sch56xx-common.o] Error 1
make[3]: *** Waiting for unfinished jobs....

Guenter

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: LM Sensors <lm-sensors@lm-sensors.org>,
	Thilo Cestonaro <thilo.cestonaro@ts.fujitsu.com>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Subject: Re: [lm-sensors] [PATCH] hwmon/sch56xx: Add support for the integrated watchdog
Date: Sun, 18 Mar 2012 12:14:07 +0000	[thread overview]
Message-ID: <20120318121407.GA26167@ericsson.com> (raw)
In-Reply-To: <4F65CF2C.4000205@redhat.com>

Hi Hans,

On Sun, Mar 18, 2012 at 08:03:56AM -0400, Hans de Goede wrote:
[ ... ]
> >> +
> >> +       data = kzalloc(sizeof(struct sch56xx_watchdog_data), GFP_KERNEL);
> >> +       if (!data)
> >> +               return NULL;
> >> +

One more:

You don't include slab.h, which in some configurations results in:

/tmp/linux.15278/drivers/hwmon/sch56xx-common.c: In function 'sch56xx_watchdog_release_resources':
/tmp/linux.15278/drivers/hwmon/sch56xx-common.c:278: error: implicit declaration of function 'kfree'
/tmp/linux.15278/drivers/hwmon/sch56xx-common.c: In function 'sch56xx_watchdog_register':
/tmp/linux.15278/drivers/hwmon/sch56xx-common.c:644: error: implicit declaration of function 'kzalloc'
/tmp/linux.15278/drivers/hwmon/sch56xx-common.c:644: warning: assignment makes pointer from integer without a cast
make[3]: *** [drivers/hwmon/sch56xx-common.o] Error 1
make[3]: *** Waiting for unfinished jobs....

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2012-03-18 12:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-17  9:40 [PATCH 0/1] hwmon/sch56xx: Add support for the integrated watchdog Hans de Goede
2012-03-17  9:40 ` [lm-sensors] " Hans de Goede
2012-03-17  9:40 ` [PATCH] " Hans de Goede
2012-03-17  9:40   ` [lm-sensors] " Hans de Goede
2012-03-17 18:58   ` Guenter Roeck
2012-03-17 18:58     ` Guenter Roeck
2012-03-18 12:03     ` Hans de Goede
2012-03-18 12:03       ` Hans de Goede
2012-03-18 12:14       ` Guenter Roeck [this message]
2012-03-18 12:14         ` Guenter Roeck
  -- strict thread matches above, loose matches on Subject: below --
2012-03-18 12:05 [PATCH] hwmon/sch56xx: Add support for the integrated watchdog (v2) Hans de Goede
2012-03-18 12:05 ` [lm-sensors] " Hans de Goede
2012-03-18 12:17 ` Guenter Roeck
2012-03-18 12:17   ` Guenter Roeck
2012-03-18 21:50   ` Guenter Roeck
2012-03-18 21:50     ` Guenter Roeck
2012-03-19 10:02     ` Hans de Goede
2012-03-19 10:02       ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120318121407.GA26167@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=thilo.cestonaro@ts.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.