From: scottwood@freescale.com (Scott Wood)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 3/3] ARM: kirkwood: Define NAND partitions in dts
Date: Mon, 26 Mar 2012 10:53:29 -0500 [thread overview]
Message-ID: <4F7090F9.5000603@freescale.com> (raw)
In-Reply-To: <1332594876-8673-4-git-send-email-jm@lentin.co.uk>
On 03/24/2012 08:14 AM, Jamie Lentin wrote:
> Use devicetree to define NAND partitions. Use D-link partition scheme by
> default, to be vaguely compatible with their userland.
>
> Signed-off-by: Jamie Lentin <jm@lentin.co.uk>
> ---
> arch/arm/boot/dts/kirkwood-dns320.dts | 35 +++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/kirkwood-dns325.dts | 35 +++++++++++++++++++++++++++++++++
> arch/arm/mach-kirkwood/board-dnskw.c | 31 -----------------------------
> 3 files changed, 70 insertions(+), 31 deletions(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-dns320.dts b/arch/arm/boot/dts/kirkwood-dns320.dts
> index 58de7f2..fbf55ff 100644
> --- a/arch/arm/boot/dts/kirkwood-dns320.dts
> +++ b/arch/arm/boot/dts/kirkwood-dns320.dts
> @@ -25,5 +25,40 @@
> clock-frequency = <166666667>;
> status = "ok";
> };
> +
> + nand at 3000000 {
> + status = "ok";
> +
This should be "okay", not "ok" -- see IEEE1275. Or just leave it out.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Jamie Lentin <jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Jason <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
Subject: Re: [PATCH V2 3/3] ARM: kirkwood: Define NAND partitions in dts
Date: Mon, 26 Mar 2012 10:53:29 -0500 [thread overview]
Message-ID: <4F7090F9.5000603@freescale.com> (raw)
In-Reply-To: <1332594876-8673-4-git-send-email-jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
On 03/24/2012 08:14 AM, Jamie Lentin wrote:
> Use devicetree to define NAND partitions. Use D-link partition scheme by
> default, to be vaguely compatible with their userland.
>
> Signed-off-by: Jamie Lentin <jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
> ---
> arch/arm/boot/dts/kirkwood-dns320.dts | 35 +++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/kirkwood-dns325.dts | 35 +++++++++++++++++++++++++++++++++
> arch/arm/mach-kirkwood/board-dnskw.c | 31 -----------------------------
> 3 files changed, 70 insertions(+), 31 deletions(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-dns320.dts b/arch/arm/boot/dts/kirkwood-dns320.dts
> index 58de7f2..fbf55ff 100644
> --- a/arch/arm/boot/dts/kirkwood-dns320.dts
> +++ b/arch/arm/boot/dts/kirkwood-dns320.dts
> @@ -25,5 +25,40 @@
> clock-frequency = <166666667>;
> status = "ok";
> };
> +
> + nand@3000000 {
> + status = "ok";
> +
This should be "okay", not "ok" -- see IEEE1275. Or just leave it out.
-Scott
next prev parent reply other threads:[~2012-03-26 15:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-24 13:14 [PATCH V2 0/3] Add support for DNS-320 and DNS-325 using devicetree Jamie Lentin
2012-03-24 13:14 ` Jamie Lentin
2012-03-24 13:14 ` [PATCH V2 1/3] ARM: kirkwood: Basic support for DNS-320 and DNS-325 Jamie Lentin
2012-03-24 13:14 ` Jamie Lentin
2012-03-24 19:26 ` Arnd Bergmann
2012-03-24 19:26 ` Arnd Bergmann
2012-03-25 15:05 ` Jason Cooper
2012-03-25 15:05 ` Jason Cooper
2012-03-24 13:14 ` [PATCH V2 2/3] ARM: kirkwood: Convert orion-nand to fdt Jamie Lentin
2012-03-24 13:14 ` Jamie Lentin
2012-03-24 19:01 ` Arnd Bergmann
2012-03-24 19:01 ` Arnd Bergmann
2012-03-25 0:17 ` [PATCH V3 " Jamie Lentin
2012-03-25 0:17 ` Jamie Lentin
2012-03-25 7:52 ` Arnd Bergmann
2012-03-25 7:52 ` Arnd Bergmann
2012-03-25 14:57 ` Jason Cooper
2012-03-25 14:57 ` Jason Cooper
2012-03-24 13:14 ` [PATCH V2 3/3] ARM: kirkwood: Define NAND partitions in dts Jamie Lentin
2012-03-24 13:14 ` Jamie Lentin
2012-03-24 19:01 ` Arnd Bergmann
2012-03-24 19:01 ` Arnd Bergmann
2012-03-26 15:53 ` Scott Wood [this message]
2012-03-26 15:53 ` Scott Wood
2012-03-26 16:20 ` Jason Cooper
2012-03-26 16:20 ` Jason Cooper
2012-03-26 16:28 ` Scott Wood
2012-03-26 16:28 ` Scott Wood
2012-03-26 16:36 ` Jamie Lentin
2012-03-26 16:36 ` Jamie Lentin
2012-03-26 16:43 ` Jason Cooper
2012-03-26 16:43 ` Jason Cooper
2012-03-26 16:52 ` [PATCH] ARM: kirkwood: fdt: use IEEE1275 status = "okay" Jason Cooper
2012-03-26 16:52 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7090F9.5000603@freescale.com \
--to=scottwood@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.