* Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly
@ 2012-03-27 15:43 ` Peter Maydell
0 siblings, 0 replies; 11+ messages in thread
From: Peter Maydell @ 2012-03-27 15:43 UTC (permalink / raw)
To: Meador Inge; +Cc: QEMU Trivial, Paul Brook, qemu-devel, Andreas Färber
This patch is simple enough (and m68k unmaintained enough)
that it could reasonably go through qemu-trivial I think.
-- PMM
On 27 March 2012 16:07, Meador Inge <meadori@codesourcery.com> wrote:
> Ping.
>
> On 02/24/2012 04:53 PM, Andreas Färber wrote:
>> Am 24.02.2012 23:18, schrieb Meador Inge:
>>> Fixing a simple typo, s/errno/err/, that caused
>>> the error status from GDB semihosted system calls
>>> to be returned incorrectly.
>>>
>>> Signed-off-by: Meador Inge <meadori@codesourcery.com>
>>
>> Nice catch!
>>
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>>
>> Andreas
>>
>>> ---
>>> m68k-semi.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/m68k-semi.c b/m68k-semi.c
>>> index bab01ee..6d60ced 100644
>>> --- a/m68k-semi.c
>>> +++ b/m68k-semi.c
>>> @@ -150,7 +150,7 @@ static void m68k_semi_cb(CPUState *env, target_ulong ret, target_ulong err)
>>> }
>>> /* FIXME - handle put_user() failure */
>>> put_user_u32(ret, args);
>>> - put_user_u32(errno, args + 4);
>>> + put_user_u32(err, args + 4);
>>> }
>>>
>>> #define ARG(n) \
>>
>
>
> --
> Meador Inge
> CodeSourcery / Mentor Embedded
> http://www.mentor.com/embedded-software
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly
2012-03-27 15:43 ` Peter Maydell
@ 2012-03-27 15:51 ` Andreas Färber
-1 siblings, 0 replies; 11+ messages in thread
From: Andreas Färber @ 2012-03-27 15:51 UTC (permalink / raw)
To: Peter Maydell, Paul Brook
Cc: QEMU Trivial, Meador Inge, qemu-devel, Anthony Liguori
Am 27.03.2012 17:43, schrieb Peter Maydell:
> This patch is simple enough (and m68k unmaintained enough)
> that it could reasonably go through qemu-trivial I think.
This one's a Mentor-internal issue though - Paul, are you planning to
handle (your colleague's) m68k patches? Or should we downgrade m68k to
S: Orphan and handle them through some other to be defined way?
I'm asking because I have m68k QOM'ification in the queue and Anthony
has set out not to apply patches for which a submaintainer is defined.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly
@ 2012-03-27 15:51 ` Andreas Färber
0 siblings, 0 replies; 11+ messages in thread
From: Andreas Färber @ 2012-03-27 15:51 UTC (permalink / raw)
To: Peter Maydell, Paul Brook
Cc: QEMU Trivial, Meador Inge, qemu-devel, Anthony Liguori
Am 27.03.2012 17:43, schrieb Peter Maydell:
> This patch is simple enough (and m68k unmaintained enough)
> that it could reasonably go through qemu-trivial I think.
This one's a Mentor-internal issue though - Paul, are you planning to
handle (your colleague's) m68k patches? Or should we downgrade m68k to
S: Orphan and handle them through some other to be defined way?
I'm asking because I have m68k QOM'ification in the queue and Anthony
has set out not to apply patches for which a submaintainer is defined.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly
2012-03-27 15:43 ` Peter Maydell
@ 2012-10-29 9:42 ` Peter Maydell
-1 siblings, 0 replies; 11+ messages in thread
From: Peter Maydell @ 2012-10-29 9:42 UTC (permalink / raw)
To: Meador Inge; +Cc: QEMU Trivial, Paul Brook, qemu-devel, Andreas Färber
I just noticed this patch never got applied by anybody
(and alas it now needs a refresh because the file was renamed
in the interim.)
-- PMM
On 27 March 2012 16:43, Peter Maydell <peter.maydell@linaro.org> wrote:
> This patch is simple enough (and m68k unmaintained enough)
> that it could reasonably go through qemu-trivial I think.
>
> -- PMM
>
> On 27 March 2012 16:07, Meador Inge <meadori@codesourcery.com> wrote:
>> Ping.
>>
>> On 02/24/2012 04:53 PM, Andreas Färber wrote:
>>> Am 24.02.2012 23:18, schrieb Meador Inge:
>>>> Fixing a simple typo, s/errno/err/, that caused
>>>> the error status from GDB semihosted system calls
>>>> to be returned incorrectly.
>>>>
>>>> Signed-off-by: Meador Inge <meadori@codesourcery.com>
>>>
>>> Nice catch!
>>>
>>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>>>
>>> Andreas
>>>
>>>> ---
>>>> m68k-semi.c | 2 +-
>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/m68k-semi.c b/m68k-semi.c
>>>> index bab01ee..6d60ced 100644
>>>> --- a/m68k-semi.c
>>>> +++ b/m68k-semi.c
>>>> @@ -150,7 +150,7 @@ static void m68k_semi_cb(CPUState *env, target_ulong ret, target_ulong err)
>>>> }
>>>> /* FIXME - handle put_user() failure */
>>>> put_user_u32(ret, args);
>>>> - put_user_u32(errno, args + 4);
>>>> + put_user_u32(err, args + 4);
>>>> }
>>>>
>>>> #define ARG(n) \
>>>
>>
>>
>> --
>> Meador Inge
>> CodeSourcery / Mentor Embedded
>> http://www.mentor.com/embedded-software
>>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly
@ 2012-10-29 9:42 ` Peter Maydell
0 siblings, 0 replies; 11+ messages in thread
From: Peter Maydell @ 2012-10-29 9:42 UTC (permalink / raw)
To: Meador Inge; +Cc: QEMU Trivial, Paul Brook, qemu-devel, Andreas Färber
I just noticed this patch never got applied by anybody
(and alas it now needs a refresh because the file was renamed
in the interim.)
-- PMM
On 27 March 2012 16:43, Peter Maydell <peter.maydell@linaro.org> wrote:
> This patch is simple enough (and m68k unmaintained enough)
> that it could reasonably go through qemu-trivial I think.
>
> -- PMM
>
> On 27 March 2012 16:07, Meador Inge <meadori@codesourcery.com> wrote:
>> Ping.
>>
>> On 02/24/2012 04:53 PM, Andreas Färber wrote:
>>> Am 24.02.2012 23:18, schrieb Meador Inge:
>>>> Fixing a simple typo, s/errno/err/, that caused
>>>> the error status from GDB semihosted system calls
>>>> to be returned incorrectly.
>>>>
>>>> Signed-off-by: Meador Inge <meadori@codesourcery.com>
>>>
>>> Nice catch!
>>>
>>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>>>
>>> Andreas
>>>
>>>> ---
>>>> m68k-semi.c | 2 +-
>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/m68k-semi.c b/m68k-semi.c
>>>> index bab01ee..6d60ced 100644
>>>> --- a/m68k-semi.c
>>>> +++ b/m68k-semi.c
>>>> @@ -150,7 +150,7 @@ static void m68k_semi_cb(CPUState *env, target_ulong ret, target_ulong err)
>>>> }
>>>> /* FIXME - handle put_user() failure */
>>>> put_user_u32(ret, args);
>>>> - put_user_u32(errno, args + 4);
>>>> + put_user_u32(err, args + 4);
>>>> }
>>>>
>>>> #define ARG(n) \
>>>
>>
>>
>> --
>> Meador Inge
>> CodeSourcery / Mentor Embedded
>> http://www.mentor.com/embedded-software
>>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly
2012-10-29 9:42 ` Peter Maydell
@ 2012-10-29 10:03 ` Stefan Hajnoczi
-1 siblings, 0 replies; 11+ messages in thread
From: Stefan Hajnoczi @ 2012-10-29 10:03 UTC (permalink / raw)
To: Peter Maydell
Cc: QEMU Trivial, Meador Inge, Paul Brook, Andreas Färber,
qemu-devel
On Mon, Oct 29, 2012 at 10:42 AM, Peter Maydell
<peter.maydell@linaro.org> wrote:
> I just noticed this patch never got applied by anybody
> (and alas it now needs a refresh because the file was renamed
> in the interim.)
Merged, thanks!
https://github.com/stefanha/qemu/commits/trivial-patches
Please CC qemu-trivial when suggesting a patch goes through the trivial queue.
Stefan
^ permalink raw reply [flat|nested] 11+ messages in thread