Unmount btrfs when stopping OSD's

Unmount btrfs when stopping OSD's

[Wido den Hollander]

Hi,

It's something I noticed some time ago, but never really paid attention to.

When we start an OSD we automatically mount the btrfs filesystem if 
"btrfs devs" is set, but we do not unmount when we stop the OSD.

I see the init script is prepared for this:

dobtrfsumount=0
..
     --btrfsumount)
	    dobtrfsumount=1
..
if [ $dobtrfsumount -eq 1 ] && [ -n "$btrfs_devs" ]; then

Why would this be set to 0 by default? Any reason?

I like my daemons/init scripts to clean up their 'mess' when they stop.

I'd vote for setting this to 1 by default.

Wido

Re: Unmount btrfs when stopping OSD's

[Tommi Virtanen]

On Tue, Mar 27, 2012 at 07:20, Wido den Hollander <wido@widodh.nl> wrote:
> When we start an OSD we automatically mount the btrfs filesystem if "btrfs
> devs" is set, but we do not unmount when we stop the OSD.
...
> I'd vote for setting this to 1 by default.

btrfs_devs was meant to make Sage's development use easier. We don't
want to support it on actual use (we'd need to expand it to cover all
the filesystems, etc), and intend to remove it. Please do not use it
-- we sure don't.

The proper location for this functionality is in Chef/Puppet/etc automation.

Earlier conversation:
http://marc.info/?l=ceph-devel&m=133044999403426&w=2

Re: Unmount btrfs when stopping OSD's

[Wido den Hollander]

Hi,

On 03/27/2012 08:50 PM, Tommi Virtanen wrote:
> On Tue, Mar 27, 2012 at 07:20, Wido den Hollander<wido@widodh.nl>  wrote:
>> When we start an OSD we automatically mount the btrfs filesystem if "btrfs
>> devs" is set, but we do not unmount when we stop the OSD.
> ...
>> I'd vote for setting this to 1 by default.
>
> btrfs_devs was meant to make Sage's development use easier. We don't
> want to support it on actual use (we'd need to expand it to cover all
> the filesystems, etc), and intend to remove it. Please do not use it
> -- we sure don't.
>
> The proper location for this functionality is in Chef/Puppet/etc automation.

Ah, I think I became a bit rusty with the old configuration :)

>
> Earlier conversation:
> http://marc.info/?l=ceph-devel&m=133044999403426&w=2

I've been following it, but not that closely.

Any plans yet on removing "btrfs devs" from the configuration?

Wido

Re: Unmount btrfs when stopping OSD's

[Tommi Virtanen]

On Tue, Mar 27, 2012 at 12:09, Wido den Hollander <wido@widodh.nl> wrote:
> Any plans yet on removing "btrfs devs" from the configuration?

It's a low-priority cleanup, but it will happen.