All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] qdev property listing broken
Date: Mon, 02 Apr 2012 21:50:23 +0200	[thread overview]
Message-ID: <4F7A02FF.3020802@web.de> (raw)
In-Reply-To: <4F7A0280.6030700@codemonkey.ws>

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

On 2012-04-02 21:48, Anthony Liguori wrote:
> On 04/02/2012 02:44 PM, Jan Kiszka wrote:
>> On 2012-04-02 21:41, Anthony Liguori wrote:
>>> On 04/02/2012 02:33 PM, Jan Kiszka wrote:
>>>> Hi Anthony,
>>>>
>>>> I noticed that only properties with legacy names are printed via info
>>>> qtree.
>>>
>>> Yes.  Is that not what you expect?
>>>
>>> The qom properties and model is not stable for 1.1 so I was very careful
>>> in making sure they didn't leak into info qtree.
>>>
>>>> After digging through the qdev and qom property maze, it turned
>>>> out the property registration in qdev_property_add_legacy and
>>>> qdev_property_add_static is not consistent with the access in
>>>> qdev_print_props.
>>>
>>> qdev_print_props will completely die for 1.2 as will almost everything
>>> related to the human monitor in qdev-monitor.c.
>>>
>>> I just wanted to give us a full release to make sure we were happy with
>>> the various interfaces.
>>
>> This is broken as previously listed qdev properties disappeared.
> 
> Yes, I misunderstood "legacy" names to include static properties too. 
> You meant non-legacy static properties are broken.

Precisely. They are no longer listed.

> 
> Pure qom properties are not displayed and never were displayed.

Yes, I'm interested in those properties I can set on VM creation.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

  reply	other threads:[~2012-04-02 19:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02 19:33 [Qemu-devel] qdev property listing broken Jan Kiszka
2012-04-02 19:40 ` Paolo Bonzini
2012-04-02 19:43   ` Anthony Liguori
2012-04-02 20:07   ` Peter Maydell
2012-04-02 22:03     ` Paolo Bonzini
2012-04-02 22:27       ` Peter Maydell
2012-04-03  7:12         ` Paolo Bonzini
2012-04-02 23:38   ` Jan Kiszka
2012-04-02 19:41 ` Anthony Liguori
2012-04-02 19:44   ` Jan Kiszka
2012-04-02 19:48     ` Anthony Liguori
2012-04-02 19:50       ` Jan Kiszka [this message]
2012-04-02 20:07   ` Jan Kiszka
2012-04-02 20:10     ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7A02FF.3020802@web.de \
    --to=jan.kiszka@web.de \
    --cc=aliguori@us.ibm.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.