Re: [Qemu-devel] qdev property listing broken

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]

On 2012-04-02 21:40, Paolo Bonzini wrote:
> diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
> index a310cc7..923519c 100644
> --- a/hw/qdev-monitor.c
> +++ b/hw/qdev-monitor.c
> @@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts)
>           * for removal.  This conditional should be removed along with
>           * it.
>           */
> -        if (!prop->info->parse) {
> +        if (!prop->info->get) {
>              continue;           /* no way to set it, don't show */
>          }
>          error_printf("%s.%s=%s\n", driver, prop->name,
> @@ -165,7 +165,7 @@ int qdev_device_help(QemuOpts *opts)
>      }
>      if (info->bus_info) {
>          for (prop = info->bus_info->props; prop && prop->name; prop++) {
> -            if (!prop->info->parse) {
> +            if (!prop->info->get) {
>                  continue;           /* no way to set it, don't show */
>              }
>              error_printf("%s.%s=%s\n", driver, prop->name,

[ missed this as CCs were dropped ]

This fixes the -device foo,?, but not the issue I'm seeing. Non-legacy
properties are still not printed in info qtree - which is no surprise
given the inconsistency I pointed out.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]