From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 06/13] USB: ohci-at91: change maximum number of ports
Date: Tue, 03 Apr 2012 17:04:20 +0200 [thread overview]
Message-ID: <4F7B1174.5070300@atmel.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1204030954590.1537-100000@iolanthe.rowland.org>
On 04/03/2012 04:11 PM, Alan Stern :
> On Tue, 3 Apr 2012, Nicolas Ferre wrote:
>
>> Change number of ports to 3 for newer SoCs. Modify pdata structure
>> and ohci-at91 code that was dealing with ports information and check
>> of port indexes.
>>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>> Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>
> Did you run this patch through scripts/checkpatch.pl? I have the
> feeling that it might complain about some of the changes.
Yes, definitively.
I can modify the patch to comply with error issued by checkpatch.pl: several are
due to a bad replacement of previous code with my regular expression but others
where existing before my modifications.
So what do you think about:
- addressing all style errors in this patch (to prevent carrying them)
- merging this one and the following patch:
"[PATCH v2 07/13] USB: ohci-at91: coding style modifications with one-line ifs
- posting a v3 of this patch only if you agree on this...
Best regards,
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Alan Stern <stern@rowland.harvard.edu>, plagnioj@jcrosoft.com
Cc: linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
ludovic.desroches@atmel.com, linux-kernel@vger.kernel.org,
arnd@arndb.de, olof@lixom.net
Subject: Re: [PATCH v2 06/13] USB: ohci-at91: change maximum number of ports
Date: Tue, 03 Apr 2012 17:04:20 +0200 [thread overview]
Message-ID: <4F7B1174.5070300@atmel.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1204030954590.1537-100000@iolanthe.rowland.org>
On 04/03/2012 04:11 PM, Alan Stern :
> On Tue, 3 Apr 2012, Nicolas Ferre wrote:
>
>> Change number of ports to 3 for newer SoCs. Modify pdata structure
>> and ohci-at91 code that was dealing with ports information and check
>> of port indexes.
>>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>> Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>
> Did you run this patch through scripts/checkpatch.pl? I have the
> feeling that it might complain about some of the changes.
Yes, definitively.
I can modify the patch to comply with error issued by checkpatch.pl: several are
due to a bad replacement of previous code with my regular expression but others
where existing before my modifications.
So what do you think about:
- addressing all style errors in this patch (to prevent carrying them)
- merging this one and the following patch:
"[PATCH v2 07/13] USB: ohci-at91: coding style modifications with one-line ifs
- posting a v3 of this patch only if you agree on this...
Best regards,
--
Nicolas Ferre
next prev parent reply other threads:[~2012-04-03 15:04 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 7:32 [PATCH v2 00/13] at91: 3.4-rc1 fixes Nicolas Ferre
2012-04-03 7:32 ` Nicolas Ferre
[not found] ` <cover.1333437885.git.nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-04-03 7:27 ` [PATCH v2 13/13] ARM: at91: dt: remove unit-address part for memory nodes Nicolas Ferre
2012-04-03 7:32 ` Nicolas Ferre
2012-04-03 7:32 ` Nicolas Ferre
[not found] ` <1db62b280314855c35cb7a3188fc9d9cb8501948.1333437885.git.nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-04-03 15:39 ` Grant Likely
2012-04-04 19:17 ` Olof Johansson
2012-04-04 19:17 ` Olof Johansson
2012-04-04 19:17 ` Olof Johansson
2012-04-07 1:43 ` Grant Likely
2012-04-07 1:43 ` Grant Likely
2012-04-03 7:32 ` [PATCH v2 01/13] ARM: at91/at91sam9x5: add clkdev entries for DMA controllers Nicolas Ferre
2012-04-03 7:32 ` Nicolas Ferre
2012-04-03 7:32 ` [PATCH v2 02/13] USB: ohci-at91: fix vbus_pin_active_low handling Nicolas Ferre
2012-04-03 7:32 ` Nicolas Ferre
2012-04-03 7:32 ` [PATCH v2 03/13] ARM: at91/USB host: specify and handle properly vbus_pin_active_low Nicolas Ferre
2012-04-03 7:32 ` Nicolas Ferre
2012-04-03 7:32 ` [PATCH v2 04/13] ARM: at91/dts: USB host vbus is active low Nicolas Ferre
2012-04-03 7:32 ` Nicolas Ferre
2012-04-03 7:32 ` [PATCH v2 05/13] USB: ohci-at91: rework and fix initialization Nicolas Ferre
2012-04-03 7:32 ` Nicolas Ferre
2012-04-03 7:32 ` [PATCH v2 06/13] USB: ohci-at91: change maximum number of ports Nicolas Ferre
2012-04-03 7:32 ` Nicolas Ferre
2012-04-03 14:11 ` Alan Stern
2012-04-03 14:11 ` Alan Stern
2012-04-03 15:04 ` Nicolas Ferre [this message]
2012-04-03 15:04 ` Nicolas Ferre
2012-04-03 15:25 ` Alan Stern
2012-04-03 15:25 ` Alan Stern
2012-04-03 15:30 ` [PATCH v3 06/12] " Nicolas Ferre
2012-04-03 15:30 ` Nicolas Ferre
2012-04-04 16:07 ` Alan Stern
2012-04-04 16:07 ` Alan Stern
2012-04-03 7:32 ` [PATCH v2 07/13] USB: ohci-at91: coding style modifications with one-line ifs Nicolas Ferre
2012-04-03 7:32 ` Nicolas Ferre
2012-04-03 7:32 ` [PATCH v2 08/13] USB: ohci-at91: trivial return code name change Nicolas Ferre
2012-04-03 7:32 ` Nicolas Ferre
2012-04-03 7:32 ` [PATCH v2 09/13] ARM: at91/at91sam9x5.dtsi: fix NAND ale/cle in DT file Nicolas Ferre
2012-04-03 7:32 ` Nicolas Ferre
2012-04-03 7:32 ` [PATCH v2 10/13] ARM: at91/NAND DT bindings: add comments Nicolas Ferre
2012-04-03 7:32 ` Nicolas Ferre
2012-04-03 7:32 ` [PATCH v2 11/13] USB: ehci-atmel: add needed of.h header file Nicolas Ferre
2012-04-03 7:32 ` Nicolas Ferre
2012-04-03 7:32 ` [PATCH v2 12/13] ARM: at91: fix check of valid GPIO for SPI and USB Nicolas Ferre
2012-04-03 7:32 ` Nicolas Ferre
2012-04-03 11:55 ` [PATCH v2 00/13] at91: 3.4-rc1 fixes Nicolas Ferre
2012-04-03 11:55 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7B1174.5070300@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.