From: Ren Mingxin <renmx@cn.fujitsu.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Kay Sievers <kay.sievers@vrfy.org>,
Tokunaga Kei <tokunaga.keiich@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
UDEV <linux-hotplug@vger.kernel.org>
Subject: Re: [RFC PATCH] virtio_blk: Checking "private_data" to avoid kernel panic when hotplugging
Date: Wed, 11 Apr 2012 09:09:52 +0000 [thread overview]
Message-ID: <4F854A60.7010704@cn.fujitsu.com> (raw)
In-Reply-To: <20120411083608.GC8562@redhat.com>
On 04/11/2012 04:36 PM, Michael S. Tsirkin wrote:
> On Wed, Apr 11, 2012 at 11:17:16AM +0800, Ren Mingxin wrote:
>> On 04/09/2012 03:53 PM, Michael S. Tsirkin wrote:
>>
>>> There's a chance you are hitting a race fixed by
>>> 4678d6f970c2f7c0cbfefc0cc666432d153b321b.
>>>
>>> If it's still not fixed it might make sense to enable slab debugging -
>>> we might have a use after free here.
>>>
>> I don't think the below commit has fixed this panic issue, for it is
>> included
>> in my last test environment(3.3-rc7).
>> 4678d6f970c2f7c0cbfefc0cc666432d153b321b
>>
>> Now, I'd find which commit makes sense.
> Great, thanks very much. I do suggest slab debugging if
> the race reproduces for you with it enabled - reducing
> the chance random struct rearrangements hide the bug.
>
Much appreciated for suggesting :-)
I'll try it to locate the commit and backport it into rhel.
--
Thanks,
Ren
WARNING: multiple messages have this Message-ID (diff)
From: Ren Mingxin <renmx@cn.fujitsu.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Kay Sievers <kay.sievers@vrfy.org>,
Tokunaga Kei <tokunaga.keiich@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
UDEV <linux-hotplug@vger.kernel.org>
Subject: Re: [RFC PATCH] virtio_blk: Checking "private_data" to avoid kernel panic when hotplugging
Date: Wed, 11 Apr 2012 17:09:52 +0800 [thread overview]
Message-ID: <4F854A60.7010704@cn.fujitsu.com> (raw)
In-Reply-To: <20120411083608.GC8562@redhat.com>
On 04/11/2012 04:36 PM, Michael S. Tsirkin wrote:
> On Wed, Apr 11, 2012 at 11:17:16AM +0800, Ren Mingxin wrote:
>> On 04/09/2012 03:53 PM, Michael S. Tsirkin wrote:
>>
>>> There's a chance you are hitting a race fixed by
>>> 4678d6f970c2f7c0cbfefc0cc666432d153b321b.
>>>
>>> If it's still not fixed it might make sense to enable slab debugging -
>>> we might have a use after free here.
>>>
>> I don't think the below commit has fixed this panic issue, for it is
>> included
>> in my last test environment(3.3-rc7).
>> 4678d6f970c2f7c0cbfefc0cc666432d153b321b
>>
>> Now, I'd find which commit makes sense.
> Great, thanks very much. I do suggest slab debugging if
> the race reproduces for you with it enabled - reducing
> the chance random struct rearrangements hide the bug.
>
Much appreciated for suggesting :-)
I'll try it to locate the commit and backport it into rhel.
--
Thanks,
Ren
next prev parent reply other threads:[~2012-04-11 9:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 3:40 [RFC PATCH] virtio_blk: Checking "private_data" to avoid kernel panic when hotplugging Ren Mingxin
2012-03-28 3:40 ` Ren Mingxin
2012-03-28 11:11 ` Michael S. Tsirkin
2012-03-28 11:11 ` Michael S. Tsirkin
2012-03-29 4:11 ` Ren Mingxin
2012-03-29 4:11 ` Ren Mingxin
2012-03-29 10:30 ` Michael S. Tsirkin
2012-03-29 10:30 ` Michael S. Tsirkin
2012-04-09 7:53 ` Michael S. Tsirkin
2012-04-09 7:53 ` Michael S. Tsirkin
2012-04-11 3:17 ` Ren Mingxin
2012-04-11 3:17 ` Ren Mingxin
2012-04-11 8:36 ` Michael S. Tsirkin
2012-04-11 8:36 ` Michael S. Tsirkin
2012-04-11 9:09 ` Ren Mingxin [this message]
2012-04-11 9:09 ` Ren Mingxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F854A60.7010704@cn.fujitsu.com \
--to=renmx@cn.fujitsu.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tokunaga.keiich@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.