From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: jic23@cam.ac.uk, gregkh@linuxfoundation.org,
grant.likely@secretlab.ca, rob.herring@calxeda.com,
jbrenner@taosinc.com, rklein@nvidia.com, max@stro.at,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH V4 2/2] staging: iio: add driver for isl29028
Date: Thu, 12 Apr 2012 09:36:37 -0600 [thread overview]
Message-ID: <4F86F685.1090707@wwwdotorg.org> (raw)
In-Reply-To: <1334239266-29505-3-git-send-email-ldewangan@nvidia.com>
On 04/12/2012 08:01 AM, Laxman Dewangan wrote:
> Intersil's ISL29028 is concurrent Ambient Light and
> Proximity Sensor device.
> Add driver to access the light and IR intensity and
> +static const struct regmap_config isl29028_regmap_config = {
...
> + .max_register = ISL29028_MAX_REGS - 1,
> + .num_reg_defaults_raw = ISL29028_MAX_REGS,
This should really be ISL29028_NUM_REGS, since you don't have a maximum
number of registers, just a number of regs.
However, if there's no other reason to respin the patch, don't worry
about it.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
jbrenner-yYKgigLBUwlBDgjK7y7TUQ@public.gmane.org,
rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
max-U9r9yeDMy7A@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH V4 2/2] staging: iio: add driver for isl29028
Date: Thu, 12 Apr 2012 09:36:37 -0600 [thread overview]
Message-ID: <4F86F685.1090707@wwwdotorg.org> (raw)
In-Reply-To: <1334239266-29505-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 04/12/2012 08:01 AM, Laxman Dewangan wrote:
> Intersil's ISL29028 is concurrent Ambient Light and
> Proximity Sensor device.
> Add driver to access the light and IR intensity and
> +static const struct regmap_config isl29028_regmap_config = {
...
> + .max_register = ISL29028_MAX_REGS - 1,
> + .num_reg_defaults_raw = ISL29028_MAX_REGS,
This should really be ISL29028_NUM_REGS, since you don't have a maximum
number of registers, just a number of regs.
However, if there's no other reason to respin the patch, don't worry
about it.
next prev parent reply other threads:[~2012-04-12 15:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 14:01 [PATCH V4 0/2] staging: iio: add isl29028 driver Laxman Dewangan
2012-04-12 14:01 ` Laxman Dewangan
2012-04-12 14:01 ` [PATCH V4 1/2] staging: iio: add channel info for sampling frequency Laxman Dewangan
2012-04-12 14:27 ` Jonathan Cameron
2012-04-12 14:27 ` Jonathan Cameron
2012-04-12 14:01 ` [PATCH V4 2/2] staging: iio: add driver for isl29028 Laxman Dewangan
2012-04-12 14:01 ` Laxman Dewangan
2012-04-12 14:34 ` Jonathan Cameron
2012-04-12 14:34 ` Jonathan Cameron
2012-04-13 9:48 ` Laxman Dewangan
2012-04-13 9:48 ` Laxman Dewangan
2012-04-13 10:05 ` Jonathan Cameron
2012-04-13 10:05 ` Jonathan Cameron
2012-04-13 9:49 ` Laxman Dewangan
2012-04-13 9:49 ` Laxman Dewangan
2012-04-12 15:36 ` Stephen Warren [this message]
2012-04-12 15:36 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F86F685.1090707@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=jbrenner@taosinc.com \
--cc=jic23@cam.ac.uk \
--cc=ldewangan@nvidia.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@stro.at \
--cc=rklein@nvidia.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.