Re: [PATCH 1/2] ARM: OMAP2/3: VENC hwmods: Remove OCPIF_SWSUP_IDLE flag from VENC slave interface

[Archit Taneja <a0393947@ti.com>]

Hi,

On Friday 13 April 2012 04:54 PM, Paul Walmsley wrote:
> On Fri, 13 Apr 2012, Paul Walmsley wrote:
>
>> On Fri, 13 Apr 2012, Archit Taneja wrote:
>>
>>> The clocks for all DSS slave interfaces were recently changed to "dss_ick" on
>>> OMAP2 and OMAP3, this clock can be autoidled by PRCM. The VENC interface
>>> previously had "dss_54m_fck" as it's clock which couldn't be autoidled, and
>>> hence the OCPIF_SWSUP_IDLE flag was needed.
>>>
>>> Remove the OCPIF_SWSUP_IDLE flag from VENC interfaces as it's clock is now
>>> "dss_ick".
>>>
>>> Signed-off-by: Archit Taneja<archit@ti.com>
>>
>> Thanks, queued for 3.4-rc.
>
> By the way, I added another sentence to the commit log to describe what is
> being fixed.  Please let me know if you have any comments.

Thanks for improving the commit. It looks good to me.

Archit


>
>
> - Paul
>
> From: Archit Taneja<archit@ti.com>
> Date: Fri, 13 Apr 2012 13:31:55 +0530
> Subject: [PATCH 3/3] ARM: OMAP2/3: VENC hwmods: Remove OCPIF_SWSUP_IDLE flag
>   from VENC slave interface
>
> The clocks for all DSS slave interfaces were recently changed to "dss_ick" on
> OMAP2 and OMAP3, this clock can be autoidled by PRCM. The VENC interface
> previously had "dss_54m_fck" as it's clock which couldn't be autoidled, and
> hence the OCPIF_SWSUP_IDLE flag was needed.
>
> Remove the OCPIF_SWSUP_IDLE flag from VENC interfaces as it's clock is
> now "dss_ick".  This allows the PRCM hardware to autoidle the VENC
> interface clocks when they are not active, rather than relying on the
> software to do it, which can keep the interface clocks active
> unnecessarily.
>
> Signed-off-by: Archit Taneja<archit@ti.com>
> [paul@pwsan.com: add a short description of the fix to the commit log]
> Signed-off-by: Paul Walmsley<paul@pwsan.com>
> ---
>   arch/arm/mach-omap2/omap_hwmod_2420_data.c |    1 -
>   arch/arm/mach-omap2/omap_hwmod_2430_data.c |    1 -
>   arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |    1 -
>   3 files changed, 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_2420_data.c b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
> index a5409ce..a6bde34 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_2420_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
> @@ -1000,7 +1000,6 @@ static struct omap_hwmod_ocp_if omap2420_l4_core__dss_venc = {
>   			.flags	= OMAP_FIREWALL_L4,
>   		}
>   	},
> -	.flags		= OCPIF_SWSUP_IDLE,
>   	.user		= OCP_USER_MPU | OCP_USER_SDMA,
>   };
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_2430_data.c b/arch/arm/mach-omap2/omap_hwmod_2430_data.c
> index c4f56cb..04a3885 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_2430_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_2430_data.c
> @@ -1049,7 +1049,6 @@ static struct omap_hwmod_ocp_if omap2430_l4_core__dss_venc = {
>   	.slave		=&omap2430_dss_venc_hwmod,
>   	.clk		= "dss_ick",
>   	.addr		= omap2_dss_venc_addrs,
> -	.flags		= OCPIF_SWSUP_IDLE,
>   	.user		= OCP_USER_MPU | OCP_USER_SDMA,
>   };
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> index 34b9766d..db86ce9 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -1676,7 +1676,6 @@ static struct omap_hwmod_ocp_if omap3xxx_l4_core__dss_venc = {
>   			.flags	= OMAP_FIREWALL_L4,
>   		}
>   	},
> -	.flags		= OCPIF_SWSUP_IDLE,
>   	.user		= OCP_USER_MPU | OCP_USER_SDMA,
>   };
>