From: Kukjin Kim <kgene.kim@samsung.com>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
'kgene kim' <kgene.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] ARM: EXYNOS: add the definition for IRQ_DWMCI
Date: Wed, 18 Apr 2012 17:12:08 -0700 [thread overview]
Message-ID: <4F8F5858.4060804@samsung.com> (raw)
In-Reply-To: <4F8E400E.3000300@samsung.com>
Jaehoon Chung wrote:
> In dev-dwmci.c, IRQ_DWMCI is referenced.
> But there is no defined anywhere.
> This patch is added the missing definition for IRQ_DWMCI.
>
> Signed-off-by: Jaehoon Chung<jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park<Kyungmin.park@samsung.com>
> ---
> arch/arm/mach-exynos/include/mach/irqs.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/include/mach/irqs.h b/arch/arm/mach-exynos/include/mach/irqs.h
> index 1161675..ed2295f 100644
> --- a/arch/arm/mach-exynos/include/mach/irqs.h
> +++ b/arch/arm/mach-exynos/include/mach/irqs.h
> @@ -201,6 +201,7 @@
> #define IRQ_HSMMC1 EXYNOS4_IRQ_HSMMC1
> #define IRQ_HSMMC2 EXYNOS4_IRQ_HSMMC2
> #define IRQ_HSMMC3 EXYNOS4_IRQ_HSMMC3
> +#define IRQ_DWMCI EXYNOS4_IRQ_DWMCI
Yeah, we need fix it but I have no idea need re-mapping. Just following
can do it. If you're ok on following, let me pick this up.
---
diff --git a/arch/arm/mach-exynos/dev-dwmci.c
b/arch/arm/mach-exynos/dev-dwmci.c
index b025db4..c78daf2 100644
--- a/arch/arm/mach-exynos/dev-dwmci.c
+++ b/arch/arm/mach-exynos/dev-dwmci.c
@@ -33,16 +31,8 @@ static int exynos4_dwmci_init(u32 slot_id,
irq_handler_t handler, void *data)
}
static struct resource exynos4_dwmci_resource[] = {
- [0] = {
- .start = EXYNOS4_PA_DWMCI,
- .end = EXYNOS4_PA_DWMCI + SZ_4K - 1,
- .flags = IORESOURCE_MEM,
- },
- [1] = {
- .start = IRQ_DWMCI,
- .end = IRQ_DWMCI,
- .flags = IORESOURCE_IRQ,
- }
+ [0] = DEFINE_RES_MEM(EXYNOS4_PA_DWMCI, SZ_4K),
+ [1] = DEFINE_RES_IRQ(EXYNOS4_IRQ_DWMCI),
};
static struct dw_mci_board exynos4_dwci_pdata = {
--
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-04-19 0:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 4:16 [PATCH] ARM: EXYNOS: add the definition for IRQ_DWMCI Jaehoon Chung
2012-04-19 0:12 ` Kukjin Kim [this message]
2012-04-19 1:36 ` Jaehoon Chung
2012-04-19 2:31 ` Kukjin Kim
2012-04-25 0:20 ` Kukjin Kim
2012-04-25 4:49 ` Tushar Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8F5858.4060804@samsung.com \
--to=kgene.kim@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.