Re: [PATCH] ARM: EXYNOS: add the definition for IRQ_DWMCI

[Kukjin Kim <kgene.kim@samsung.com>]

Jaehoon Chung wroteh:
> On 04/19/2012 09:12 AM, Kukjin Kim wrote:
>
>> Jaehoon Chung wrote:
>>> In dev-dwmci.c, IRQ_DWMCI is referenced.
>>> But there is no defined anywhere.
>>> This patch is added the missing definition for IRQ_DWMCI.
>>>
>>> Signed-off-by: Jaehoon Chung<jh80.chung@samsung.com>
>>> Signed-off-by: Kyungmin Park<Kyungmin.park@samsung.com>
>>> ---
>>>    arch/arm/mach-exynos/include/mach/irqs.h |    1 +
>>>    1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-exynos/include/mach/irqs.h b/arch/arm/mach-exynos/include/mach/irqs.h
>>> index 1161675..ed2295f 100644
>>> --- a/arch/arm/mach-exynos/include/mach/irqs.h
>>> +++ b/arch/arm/mach-exynos/include/mach/irqs.h
>>> @@ -201,6 +201,7 @@
>>>    #define IRQ_HSMMC1            EXYNOS4_IRQ_HSMMC1
>>>    #define IRQ_HSMMC2            EXYNOS4_IRQ_HSMMC2
>>>    #define IRQ_HSMMC3            EXYNOS4_IRQ_HSMMC3
>>> +#define IRQ_DWMCI            EXYNOS4_IRQ_DWMCI
>>
>> Yeah, we need fix it but I have no idea need re-mapping. Just following can do it. If you're ok on following, let me pick this up.
>
> If it's working, i don't care..I didn't see the DEFINE_RES_MEM/DEFINE_RES_IRQ.
> But if we can use them, it's more readable.
>
Yes, this should be working fine. And note, need inclusion of 
<linux/ioport.h> for DEFINE_RES_{MEM,IRQ}.

If any problems, please let me know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.