* [PATCH] ARM: EXYNOS: add the definition for IRQ_DWMCI
@ 2012-04-18 4:16 Jaehoon Chung
2012-04-19 0:12 ` Kukjin Kim
0 siblings, 1 reply; 6+ messages in thread
From: Jaehoon Chung @ 2012-04-18 4:16 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: 'kgene kim', Kyungmin Park, Marek Szyprowski
In dev-dwmci.c, IRQ_DWMCI is referenced.
But there is no defined anywhere.
This patch is added the missing definition for IRQ_DWMCI.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Kyungmin Park <Kyungmin.park@samsung.com>
---
arch/arm/mach-exynos/include/mach/irqs.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-exynos/include/mach/irqs.h b/arch/arm/mach-exynos/include/mach/irqs.h
index 1161675..ed2295f 100644
--- a/arch/arm/mach-exynos/include/mach/irqs.h
+++ b/arch/arm/mach-exynos/include/mach/irqs.h
@@ -201,6 +201,7 @@
#define IRQ_HSMMC1 EXYNOS4_IRQ_HSMMC1
#define IRQ_HSMMC2 EXYNOS4_IRQ_HSMMC2
#define IRQ_HSMMC3 EXYNOS4_IRQ_HSMMC3
+#define IRQ_DWMCI EXYNOS4_IRQ_DWMCI
#define IRQ_MIPI_CSIS0 EXYNOS4_IRQ_MIPI_CSIS0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: EXYNOS: add the definition for IRQ_DWMCI
2012-04-18 4:16 [PATCH] ARM: EXYNOS: add the definition for IRQ_DWMCI Jaehoon Chung
@ 2012-04-19 0:12 ` Kukjin Kim
2012-04-19 1:36 ` Jaehoon Chung
0 siblings, 1 reply; 6+ messages in thread
From: Kukjin Kim @ 2012-04-19 0:12 UTC (permalink / raw)
To: Jaehoon Chung
Cc: linux-samsung-soc, 'kgene kim', Kyungmin Park,
Marek Szyprowski
Jaehoon Chung wrote:
> In dev-dwmci.c, IRQ_DWMCI is referenced.
> But there is no defined anywhere.
> This patch is added the missing definition for IRQ_DWMCI.
>
> Signed-off-by: Jaehoon Chung<jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park<Kyungmin.park@samsung.com>
> ---
> arch/arm/mach-exynos/include/mach/irqs.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/include/mach/irqs.h b/arch/arm/mach-exynos/include/mach/irqs.h
> index 1161675..ed2295f 100644
> --- a/arch/arm/mach-exynos/include/mach/irqs.h
> +++ b/arch/arm/mach-exynos/include/mach/irqs.h
> @@ -201,6 +201,7 @@
> #define IRQ_HSMMC1 EXYNOS4_IRQ_HSMMC1
> #define IRQ_HSMMC2 EXYNOS4_IRQ_HSMMC2
> #define IRQ_HSMMC3 EXYNOS4_IRQ_HSMMC3
> +#define IRQ_DWMCI EXYNOS4_IRQ_DWMCI
Yeah, we need fix it but I have no idea need re-mapping. Just following
can do it. If you're ok on following, let me pick this up.
---
diff --git a/arch/arm/mach-exynos/dev-dwmci.c
b/arch/arm/mach-exynos/dev-dwmci.c
index b025db4..c78daf2 100644
--- a/arch/arm/mach-exynos/dev-dwmci.c
+++ b/arch/arm/mach-exynos/dev-dwmci.c
@@ -33,16 +31,8 @@ static int exynos4_dwmci_init(u32 slot_id,
irq_handler_t handler, void *data)
}
static struct resource exynos4_dwmci_resource[] = {
- [0] = {
- .start = EXYNOS4_PA_DWMCI,
- .end = EXYNOS4_PA_DWMCI + SZ_4K - 1,
- .flags = IORESOURCE_MEM,
- },
- [1] = {
- .start = IRQ_DWMCI,
- .end = IRQ_DWMCI,
- .flags = IORESOURCE_IRQ,
- }
+ [0] = DEFINE_RES_MEM(EXYNOS4_PA_DWMCI, SZ_4K),
+ [1] = DEFINE_RES_IRQ(EXYNOS4_IRQ_DWMCI),
};
static struct dw_mci_board exynos4_dwci_pdata = {
--
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: EXYNOS: add the definition for IRQ_DWMCI
2012-04-19 0:12 ` Kukjin Kim
@ 2012-04-19 1:36 ` Jaehoon Chung
2012-04-19 2:31 ` Kukjin Kim
0 siblings, 1 reply; 6+ messages in thread
From: Jaehoon Chung @ 2012-04-19 1:36 UTC (permalink / raw)
To: Kukjin Kim; +Cc: linux-samsung-soc, Kyungmin Park, Marek Szyprowski
On 04/19/2012 09:12 AM, Kukjin Kim wrote:
> Jaehoon Chung wrote:
>> In dev-dwmci.c, IRQ_DWMCI is referenced.
>> But there is no defined anywhere.
>> This patch is added the missing definition for IRQ_DWMCI.
>>
>> Signed-off-by: Jaehoon Chung<jh80.chung@samsung.com>
>> Signed-off-by: Kyungmin Park<Kyungmin.park@samsung.com>
>> ---
>> arch/arm/mach-exynos/include/mach/irqs.h | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/include/mach/irqs.h b/arch/arm/mach-exynos/include/mach/irqs.h
>> index 1161675..ed2295f 100644
>> --- a/arch/arm/mach-exynos/include/mach/irqs.h
>> +++ b/arch/arm/mach-exynos/include/mach/irqs.h
>> @@ -201,6 +201,7 @@
>> #define IRQ_HSMMC1 EXYNOS4_IRQ_HSMMC1
>> #define IRQ_HSMMC2 EXYNOS4_IRQ_HSMMC2
>> #define IRQ_HSMMC3 EXYNOS4_IRQ_HSMMC3
>> +#define IRQ_DWMCI EXYNOS4_IRQ_DWMCI
>
> Yeah, we need fix it but I have no idea need re-mapping. Just following can do it. If you're ok on following, let me pick this up.
If it's working, i don't care..I didn't see the DEFINE_RES_MEM/DEFINE_RES_IRQ.
But if we can use them, it's more readable.
Thanks,
Jaehoon Chung
>
> ---
> diff --git a/arch/arm/mach-exynos/dev-dwmci.c b/arch/arm/mach-exynos/dev-dwmci.c
> index b025db4..c78daf2 100644
> --- a/arch/arm/mach-exynos/dev-dwmci.c
> +++ b/arch/arm/mach-exynos/dev-dwmci.c
> @@ -33,16 +31,8 @@ static int exynos4_dwmci_init(u32 slot_id, irq_handler_t handler, void *data)
> }
>
> static struct resource exynos4_dwmci_resource[] = {
> - [0] = {
> - .start = EXYNOS4_PA_DWMCI,
> - .end = EXYNOS4_PA_DWMCI + SZ_4K - 1,
> - .flags = IORESOURCE_MEM,
> - },
> - [1] = {
> - .start = IRQ_DWMCI,
> - .end = IRQ_DWMCI,
> - .flags = IORESOURCE_IRQ,
> - }
> + [0] = DEFINE_RES_MEM(EXYNOS4_PA_DWMCI, SZ_4K),
> + [1] = DEFINE_RES_IRQ(EXYNOS4_IRQ_DWMCI),
> };
>
> static struct dw_mci_board exynos4_dwci_pdata = {
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: EXYNOS: add the definition for IRQ_DWMCI
2012-04-19 1:36 ` Jaehoon Chung
@ 2012-04-19 2:31 ` Kukjin Kim
2012-04-25 0:20 ` Kukjin Kim
2012-04-25 4:49 ` Tushar Behera
0 siblings, 2 replies; 6+ messages in thread
From: Kukjin Kim @ 2012-04-19 2:31 UTC (permalink / raw)
To: Jaehoon Chung
Cc: Kukjin Kim, linux-samsung-soc, Kyungmin Park, Marek Szyprowski
Jaehoon Chung wroteh:
> On 04/19/2012 09:12 AM, Kukjin Kim wrote:
>
>> Jaehoon Chung wrote:
>>> In dev-dwmci.c, IRQ_DWMCI is referenced.
>>> But there is no defined anywhere.
>>> This patch is added the missing definition for IRQ_DWMCI.
>>>
>>> Signed-off-by: Jaehoon Chung<jh80.chung@samsung.com>
>>> Signed-off-by: Kyungmin Park<Kyungmin.park@samsung.com>
>>> ---
>>> arch/arm/mach-exynos/include/mach/irqs.h | 1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-exynos/include/mach/irqs.h b/arch/arm/mach-exynos/include/mach/irqs.h
>>> index 1161675..ed2295f 100644
>>> --- a/arch/arm/mach-exynos/include/mach/irqs.h
>>> +++ b/arch/arm/mach-exynos/include/mach/irqs.h
>>> @@ -201,6 +201,7 @@
>>> #define IRQ_HSMMC1 EXYNOS4_IRQ_HSMMC1
>>> #define IRQ_HSMMC2 EXYNOS4_IRQ_HSMMC2
>>> #define IRQ_HSMMC3 EXYNOS4_IRQ_HSMMC3
>>> +#define IRQ_DWMCI EXYNOS4_IRQ_DWMCI
>>
>> Yeah, we need fix it but I have no idea need re-mapping. Just following can do it. If you're ok on following, let me pick this up.
>
> If it's working, i don't care..I didn't see the DEFINE_RES_MEM/DEFINE_RES_IRQ.
> But if we can use them, it's more readable.
>
Yes, this should be working fine. And note, need inclusion of
<linux/ioport.h> for DEFINE_RES_{MEM,IRQ}.
If any problems, please let me know.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: EXYNOS: add the definition for IRQ_DWMCI
2012-04-19 2:31 ` Kukjin Kim
@ 2012-04-25 0:20 ` Kukjin Kim
2012-04-25 4:49 ` Tushar Behera
1 sibling, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2012-04-25 0:20 UTC (permalink / raw)
To: Kukjin Kim
Cc: Jaehoon Chung, linux-samsung-soc, Kyungmin Park, Marek Szyprowski
Should be EXYNOS4_IRQ_DWMCI instead of IRQ_DWMCI,
and use DEFINE_RES_{MEM,IRQ}.
Reported-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
arch/arm/mach-exynos/dev-dwmci.c | 13 +++----------
1 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/arch/arm/mach-exynos/dev-dwmci.c
b/arch/arm/mach-exynos/dev-dwmci.c
index b025db4..7903501 100644
--- a/arch/arm/mach-exynos/dev-dwmci.c
+++ b/arch/arm/mach-exynos/dev-dwmci.c
@@ -16,6 +16,7 @@
#include <linux/dma-mapping.h>
#include <linux/platform_device.h>
#include <linux/interrupt.h>
+#include <linux/ioport.h>
#include <linux/mmc/dw_mmc.h>
#include <plat/devs.h>
@@ -33,16 +34,8 @@ static int exynos4_dwmci_init(u32 slot_id,
irq_handler_t handler, void *data)
}
static struct resource exynos4_dwmci_resource[] = {
- [0] = {
- .start = EXYNOS4_PA_DWMCI,
- .end = EXYNOS4_PA_DWMCI + SZ_4K - 1,
- .flags = IORESOURCE_MEM,
- },
- [1] = {
- .start = IRQ_DWMCI,
- .end = IRQ_DWMCI,
- .flags = IORESOURCE_IRQ,
- }
+ [0] = DEFINE_RES_MEM(EXYNOS4_PA_DWMCI, SZ_4K),
+ [1] = DEFINE_RES_IRQ(EXYNOS4_IRQ_DWMCI),
};
static struct dw_mci_board exynos4_dwci_pdata = {
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: EXYNOS: add the definition for IRQ_DWMCI
2012-04-19 2:31 ` Kukjin Kim
2012-04-25 0:20 ` Kukjin Kim
@ 2012-04-25 4:49 ` Tushar Behera
1 sibling, 0 replies; 6+ messages in thread
From: Tushar Behera @ 2012-04-25 4:49 UTC (permalink / raw)
To: Kukjin Kim
Cc: Jaehoon Chung, linux-samsung-soc, Kyungmin Park, Marek Szyprowski
On 04/19/2012 08:01 AM, Kukjin Kim wrote:
> Jaehoon Chung wroteh:
>> On 04/19/2012 09:12 AM, Kukjin Kim wrote:
>>
>>> Jaehoon Chung wrote:
>>>> In dev-dwmci.c, IRQ_DWMCI is referenced.
>>>> But there is no defined anywhere.
>>>> This patch is added the missing definition for IRQ_DWMCI.
>>>>
>>>> Signed-off-by: Jaehoon Chung<jh80.chung@samsung.com>
>>>> Signed-off-by: Kyungmin Park<Kyungmin.park@samsung.com>
>>>> ---
>>>> arch/arm/mach-exynos/include/mach/irqs.h | 1 +
>>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/arch/arm/mach-exynos/include/mach/irqs.h
>>>> b/arch/arm/mach-exynos/include/mach/irqs.h
>>>> index 1161675..ed2295f 100644
>>>> --- a/arch/arm/mach-exynos/include/mach/irqs.h
>>>> +++ b/arch/arm/mach-exynos/include/mach/irqs.h
>>>> @@ -201,6 +201,7 @@
>>>> #define IRQ_HSMMC1 EXYNOS4_IRQ_HSMMC1
>>>> #define IRQ_HSMMC2 EXYNOS4_IRQ_HSMMC2
>>>> #define IRQ_HSMMC3 EXYNOS4_IRQ_HSMMC3
>>>> +#define IRQ_DWMCI EXYNOS4_IRQ_DWMCI
>>>
>>> Yeah, we need fix it but I have no idea need re-mapping. Just
>>> following can do it. If you're ok on following, let me pick this up.
>>
>> If it's working, i don't care..I didn't see the
>> DEFINE_RES_MEM/DEFINE_RES_IRQ.
>> But if we can use them, it's more readable.
>>
> Yes, this should be working fine. And note, need inclusion of
> <linux/ioport.h> for DEFINE_RES_{MEM,IRQ}.
>
We should not require explicit inclusion of <linux/ioport.h> here. The
definition of "struct resource {" and DEFINE_RES_{MEM,IRQ}" are in same
ioport.h file. Hence if "struct resource {" is accessible here,
"DEFINE_RES_{MEM,IRQ}" would also be accessible.
> If any problems, please let me know.
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Tushar Behera
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-04-25 4:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-18 4:16 [PATCH] ARM: EXYNOS: add the definition for IRQ_DWMCI Jaehoon Chung
2012-04-19 0:12 ` Kukjin Kim
2012-04-19 1:36 ` Jaehoon Chung
2012-04-19 2:31 ` Kukjin Kim
2012-04-25 0:20 ` Kukjin Kim
2012-04-25 4:49 ` Tushar Behera
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.