From: Tushar Behera <tushar.behera@linaro.org>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
linux-samsung-soc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] ARM: EXYNOS: add the definition for IRQ_DWMCI
Date: Wed, 25 Apr 2012 10:19:49 +0530 [thread overview]
Message-ID: <4F97826D.6010404@linaro.org> (raw)
In-Reply-To: <4F8F78EC.8030602@samsung.com>
On 04/19/2012 08:01 AM, Kukjin Kim wrote:
> Jaehoon Chung wroteh:
>> On 04/19/2012 09:12 AM, Kukjin Kim wrote:
>>
>>> Jaehoon Chung wrote:
>>>> In dev-dwmci.c, IRQ_DWMCI is referenced.
>>>> But there is no defined anywhere.
>>>> This patch is added the missing definition for IRQ_DWMCI.
>>>>
>>>> Signed-off-by: Jaehoon Chung<jh80.chung@samsung.com>
>>>> Signed-off-by: Kyungmin Park<Kyungmin.park@samsung.com>
>>>> ---
>>>> arch/arm/mach-exynos/include/mach/irqs.h | 1 +
>>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/arch/arm/mach-exynos/include/mach/irqs.h
>>>> b/arch/arm/mach-exynos/include/mach/irqs.h
>>>> index 1161675..ed2295f 100644
>>>> --- a/arch/arm/mach-exynos/include/mach/irqs.h
>>>> +++ b/arch/arm/mach-exynos/include/mach/irqs.h
>>>> @@ -201,6 +201,7 @@
>>>> #define IRQ_HSMMC1 EXYNOS4_IRQ_HSMMC1
>>>> #define IRQ_HSMMC2 EXYNOS4_IRQ_HSMMC2
>>>> #define IRQ_HSMMC3 EXYNOS4_IRQ_HSMMC3
>>>> +#define IRQ_DWMCI EXYNOS4_IRQ_DWMCI
>>>
>>> Yeah, we need fix it but I have no idea need re-mapping. Just
>>> following can do it. If you're ok on following, let me pick this up.
>>
>> If it's working, i don't care..I didn't see the
>> DEFINE_RES_MEM/DEFINE_RES_IRQ.
>> But if we can use them, it's more readable.
>>
> Yes, this should be working fine. And note, need inclusion of
> <linux/ioport.h> for DEFINE_RES_{MEM,IRQ}.
>
We should not require explicit inclusion of <linux/ioport.h> here. The
definition of "struct resource {" and DEFINE_RES_{MEM,IRQ}" are in same
ioport.h file. Hence if "struct resource {" is accessible here,
"DEFINE_RES_{MEM,IRQ}" would also be accessible.
> If any problems, please let me know.
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Tushar Behera
prev parent reply other threads:[~2012-04-25 4:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 4:16 [PATCH] ARM: EXYNOS: add the definition for IRQ_DWMCI Jaehoon Chung
2012-04-19 0:12 ` Kukjin Kim
2012-04-19 1:36 ` Jaehoon Chung
2012-04-19 2:31 ` Kukjin Kim
2012-04-25 0:20 ` Kukjin Kim
2012-04-25 4:49 ` Tushar Behera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F97826D.6010404@linaro.org \
--to=tushar.behera@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.