From: Suresh Jayaraman <sjayaraman-IBi9RG/b67k@public.gmane.org>
To: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
Cc: "Lars Müller" <lmuelle-IBi9RG/b67k@public.gmane.org>,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: uninitialized variables in the 5.4 release
Date: Fri, 20 Apr 2012 11:06:28 +0530 [thread overview]
Message-ID: <4F90F5DC.7070005@suse.com> (raw)
In-Reply-To: <20120419140144.7b435b50-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
On 04/19/2012 11:31 PM, Jeff Layton wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Thu, 19 Apr 2012 19:52:42 +0200
> Lars Müller <lmuelle-IBi9RG/b67k@public.gmane.org> wrote:
>
>> Hi,
>>
>> older gcc versions (4.3 in the case of SUSE Linux Enterprise 11 SP 1 and
>> SP 2) complain about uninitialized variables in the recent 5.4 release.
>>
>> The attached patch makes the build process a bit quieter.
>>
>> Cheers,
>>
>> Lars
>
> Looks reasonable if it silences the compiler warnings on older gcc,
> even if it's not really a bug per-se. I do wonder if there's some
> annotation you can add to silence that warning, but it's probably not
> worth worrying about.
Yes, annotation is perhaps not worth it. This patch and the other build
fixes from Lars looks good to me.
Acked-by: Suresh Jayaraman <sjayaraman-IBi9RG/b67k@public.gmane.org>
> I'll commit it in the next few days if no one objects...
next prev parent reply other threads:[~2012-04-20 5:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 17:52 uninitialized variables in the 5.4 release Lars Müller
[not found] ` <20120419175242.GR12994-aSaWmTCphX8QgCKCZH8Z8g@public.gmane.org>
2012-04-19 18:01 ` Jeff Layton
[not found] ` <20120419140144.7b435b50-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2012-04-20 5:36 ` Suresh Jayaraman [this message]
2012-04-20 15:47 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F90F5DC.7070005@suse.com \
--to=sjayaraman-ibi9rg/b67k@public.gmane.org \
--cc=jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lmuelle-IBi9RG/b67k@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.