uninitialized variables in the 5.4 release

uninitialized variables in the 5.4 release

[Lars Müller]

[-- Attachment #1.1: Type: text/plain, Size: 355 bytes --]

Hi,

older gcc versions (4.3 in the case of SUSE Linux Enterprise 11 SP 1 and
SP 2) complain about uninitialized variables in the recent 5.4 release.

The attached patch makes the build process a bit quieter.

Cheers,

Lars
-- 
Lars Müller [ˈlaː(r)z ˈmʏlɐ]
Samba Team + SUSE Labs
SUSE Linux, Maxfeldstraße 5, 90409 Nürnberg, Germany

[-- Attachment #1.2: bku-uid-gid-uninitialized.diff --]
[-- Type: text/x-patch, Size: 615 bytes --]

Author: Lars Mueller <lmuelle-IBi9RG/b67k@public.gmane.org>
Subject: cifs-utils build warns bkupuid and bkupgid may be used uninitialized
Bugzilla: na

Index: cifs-utils-5.4/mount.cifs.c
===================================================================
--- cifs-utils-5.4.orig/mount.cifs.c
+++ cifs-utils-5.4/mount.cifs.c
@@ -863,8 +863,8 @@ parse_options(const char *data, struct p
 	int got_uid = 0;
 	int got_cruid = 0;
 	int got_gid = 0;
-	uid_t uid, cruid = 0, bkupuid;
-	gid_t gid, bkupgid;
+	uid_t uid, cruid = 0, bkupuid = 0;
+	gid_t gid, bkupgid = 0;
 	char *ep;
 	struct passwd *pw;
 	struct group *gr;

[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]

Re: uninitialized variables in the 5.4 release

[Jeff Layton]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thu, 19 Apr 2012 19:52:42 +0200
Lars Müller <lmuelle@suse.com> wrote:

> Hi,
> 
> older gcc versions (4.3 in the case of SUSE Linux Enterprise 11 SP 1 and
> SP 2) complain about uninitialized variables in the recent 5.4 release.
> 
> The attached patch makes the build process a bit quieter.
> 
> Cheers,
> 
> Lars

Looks reasonable if it silences the compiler warnings on older gcc,
even if it's not really a bug per-se. I do wonder if there's some
annotation you can add to silence that warning, but it's probably not
worth worrying about.

I'll commit it in the next few days if no one objects... 
- -- 
Jeff Layton <jlayton@samba.org>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)

iQIcBAEBAgAGBQJPkFMIAAoJEAAOaEEZVoIVY7UP/jLd8GkmBaLHctZnT8Ez4+tT
RMNdI44fih+NC395ZNr5eCTW76XgH2AiPtPkmQsv7nkkagopCcBFYlKPmTYG7YOj
xaxmFmQbud/1QHD0vLSuhqYCMemmGN5LUrYEeEDXu69m5F3+CxwE7FMZXdQpTS+u
nv8x3nzAaqJFhV6nSvWxMDVLbz0GCysNjMPb7FN6zm7rED1vy4tUV4RnQdGKcRJw
WOpndRInkZCcdXfNCWSaOPrS9zjuvlChLrgYVJd1rg0SAW5e9+NtEByIpKFuSKDX
hMbudlHq6X9k+ryeb2ljsO0I/6LdZ3/gbxlhVZ70tPk8NJ/rqWfofu/JcsR4tR9O
0f7N73IaM7sazmpBdjmlM2qspLlWjyQb4HJObBgnbHVuItIJrYraEklqFHCiUDoy
XZFR9fzSCl9PAXHTlbJbtXF7Uc9j72gfnCcteYm2sNMWzPqLbGPBZ/i61XCzP8Hm
TTUyp57djM6NCKS91bNAHuYli8TkNK9tj7PMmV25bKK9WvkctfW3/D2OG7zaf/1e
w0uRO6z0uAJGW5uDfJZD2hSwvfpZI6Yu4NMx3JIusvULUCy4n7eaT62+Vtl0veUU
EGRPDFhuGbO6qLa/Yh7SSRzXMHOOfo3XcuQ/tFWWr7BcP6RWiz8H2bwKWlow9prU
NU6utu3iZXQmFLMpQfhk
=hroJ
-----END PGP SIGNATURE-----

Re: uninitialized variables in the 5.4 release

[Suresh Jayaraman]

On 04/19/2012 11:31 PM, Jeff Layton wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Thu, 19 Apr 2012 19:52:42 +0200
> Lars Müller <lmuelle-IBi9RG/b67k@public.gmane.org> wrote:
> 
>> Hi,
>>
>> older gcc versions (4.3 in the case of SUSE Linux Enterprise 11 SP 1 and
>> SP 2) complain about uninitialized variables in the recent 5.4 release.
>>
>> The attached patch makes the build process a bit quieter.
>>
>> Cheers,
>>
>> Lars
> 
> Looks reasonable if it silences the compiler warnings on older gcc,
> even if it's not really a bug per-se. I do wonder if there's some
> annotation you can add to silence that warning, but it's probably not
> worth worrying about.

Yes, annotation is perhaps not worth it. This patch and the other build
fixes from Lars looks good to me.

Acked-by: Suresh Jayaraman <sjayaraman-IBi9RG/b67k@public.gmane.org>

> I'll commit it in the next few days if no one objects... 

Re: uninitialized variables in the 5.4 release

[Jeff Layton]

On Thu, 19 Apr 2012 19:52:42 +0200
Lars Müller <lmuelle-IBi9RG/b67k@public.gmane.org> wrote:

> Hi,
> 
> older gcc versions (4.3 in the case of SUSE Linux Enterprise 11 SP 1 and
> SP 2) complain about uninitialized variables in the recent 5.4 release.
> 
> The attached patch makes the build process a bit quieter.
> 
> Cheers,
> 
> Lars

All 3 of Lars' patches are now merged.
-- 
Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>