All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, kgene.kim@samsung.com,
	linux@arm.linux.org.uk
Subject: Re: [RFC] ARM: SAMSUNG: devs: Use common macro to define resources
Date: Tue, 24 Apr 2012 17:01:07 -0700	[thread overview]
Message-ID: <4F973EC3.9010901@samsung.com> (raw)
In-Reply-To: <1335258206-5937-1-git-send-email-tushar.behera@linaro.org>

Tushar Behera wrote:
> CC: Kukjin Kim<kgene.kim@samsung.com>
> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
> ---
> I am not sure whether changes like this are accepted as independent patches,
> as they are not changing the behaviour of the code at all.
> 
Yeah, makes sense. will apply in my cleanup branch.

> I have a patchset doing similar clean up in various Samsung related arch files.
> If changes like this are acceptable, I will post the complete patchset.
> 
OK.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

>   arch/arm/plat-samsung/devs.c |   12 ++----------
>   1 files changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index db32ec5..1013a34 100644
> --- a/arch/arm/plat-samsung/devs.c
> +++ b/arch/arm/plat-samsung/devs.c
> @@ -272,16 +272,8 @@ struct platform_device s5p_device_fimc3 = {
> 
>   #ifdef CONFIG_S5P_DEV_G2D
>   static struct resource s5p_g2d_resource[] = {
> -	[0] = {
> -		.start	= S5P_PA_G2D,
> -		.end	= S5P_PA_G2D + SZ_4K - 1,
> -		.flags	= IORESOURCE_MEM,
> -	},
> -	[1] = {
> -		.start	= IRQ_2D,
> -		.end	= IRQ_2D,
> -		.flags	= IORESOURCE_IRQ,
> -	},
> +	[0] = DEFINE_RES_MEM(S5P_PA_G2D, SZ_4K),
> +	[1] = DEFINE_RES_IRQ(IRQ_2D),
>   };
> 
>   struct platform_device s5p_device_g2d = {

WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] ARM: SAMSUNG: devs: Use common macro to define resources
Date: Tue, 24 Apr 2012 17:01:07 -0700	[thread overview]
Message-ID: <4F973EC3.9010901@samsung.com> (raw)
In-Reply-To: <1335258206-5937-1-git-send-email-tushar.behera@linaro.org>

Tushar Behera wrote:
> CC: Kukjin Kim<kgene.kim@samsung.com>
> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
> ---
> I am not sure whether changes like this are accepted as independent patches,
> as they are not changing the behaviour of the code at all.
> 
Yeah, makes sense. will apply in my cleanup branch.

> I have a patchset doing similar clean up in various Samsung related arch files.
> If changes like this are acceptable, I will post the complete patchset.
> 
OK.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

>   arch/arm/plat-samsung/devs.c |   12 ++----------
>   1 files changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index db32ec5..1013a34 100644
> --- a/arch/arm/plat-samsung/devs.c
> +++ b/arch/arm/plat-samsung/devs.c
> @@ -272,16 +272,8 @@ struct platform_device s5p_device_fimc3 = {
> 
>   #ifdef CONFIG_S5P_DEV_G2D
>   static struct resource s5p_g2d_resource[] = {
> -	[0] = {
> -		.start	= S5P_PA_G2D,
> -		.end	= S5P_PA_G2D + SZ_4K - 1,
> -		.flags	= IORESOURCE_MEM,
> -	},
> -	[1] = {
> -		.start	= IRQ_2D,
> -		.end	= IRQ_2D,
> -		.flags	= IORESOURCE_IRQ,
> -	},
> +	[0] = DEFINE_RES_MEM(S5P_PA_G2D, SZ_4K),
> +	[1] = DEFINE_RES_IRQ(IRQ_2D),
>   };
> 
>   struct platform_device s5p_device_g2d = {

  reply	other threads:[~2012-04-25  0:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24  9:03 [RFC] ARM: SAMSUNG: devs: Use common macro to define resources Tushar Behera
2012-04-24  9:03 ` Tushar Behera
2012-04-25  0:01 ` Kukjin Kim [this message]
2012-04-25  0:01   ` Kukjin Kim
2012-04-25  4:14   ` Tushar Behera
2012-04-25  4:14     ` Tushar Behera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F973EC3.9010901@samsung.com \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=tushar.behera@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.