Re: [RFC] ARM: SAMSUNG: devs: Use common macro to define resources

[Tushar Behera <tushar.behera@linaro.org>]

On 04/25/2012 05:31 AM, Kukjin Kim wrote:
> Tushar Behera wrote:
>> CC: Kukjin Kim<kgene.kim@samsung.com>
>> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
>> ---
>> I am not sure whether changes like this are accepted as independent patches,
>> as they are not changing the behaviour of the code at all.
>>
> Yeah, makes sense. will apply in my cleanup branch.
> 
Thanks. I will post the complete patchset shortly.

>> I have a patchset doing similar clean up in various Samsung related arch files.
>> If changes like this are acceptable, I will post the complete patchset.
>>
> OK.
> 
> Thanks.
> 
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
> 
>>   arch/arm/plat-samsung/devs.c |   12 ++----------
>>   1 files changed, 2 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
>> index db32ec5..1013a34 100644
>> --- a/arch/arm/plat-samsung/devs.c
>> +++ b/arch/arm/plat-samsung/devs.c
>> @@ -272,16 +272,8 @@ struct platform_device s5p_device_fimc3 = {
>>
>>   #ifdef CONFIG_S5P_DEV_G2D
>>   static struct resource s5p_g2d_resource[] = {
>> -	[0] = {
>> -		.start	= S5P_PA_G2D,
>> -		.end	= S5P_PA_G2D + SZ_4K - 1,
>> -		.flags	= IORESOURCE_MEM,
>> -	},
>> -	[1] = {
>> -		.start	= IRQ_2D,
>> -		.end	= IRQ_2D,
>> -		.flags	= IORESOURCE_IRQ,
>> -	},
>> +	[0] = DEFINE_RES_MEM(S5P_PA_G2D, SZ_4K),
>> +	[1] = DEFINE_RES_IRQ(IRQ_2D),
>>   };
>>
>>   struct platform_device s5p_device_g2d = {


-- 
Tushar Behera