From: Kukjin Kim <kgene.kim@samsung.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>
Subject: Re: [PATCH for v3.4-rc3] ARM: Samsung: add missing MMC_CAP2_BROKEN_VOLTAGE capability
Date: Tue, 24 Apr 2012 17:33:12 -0700 [thread overview]
Message-ID: <4F974648.6020702@samsung.com> (raw)
In-Reply-To: <1334558025-26635-1-git-send-email-m.szyprowski@samsung.com>
Marek Szyprowski wrote:
> Commit 6e8201f57c935 "mmc: core: add the capability for broken voltage"
> introduced a new quirk to indicate that MMC core should ignore voltage
> change errors reported by the regulators core. This is required to get
> SDHCI working on UniversalC210, NURI and GONI boards again after commit
> ceb6143b2df81c ("mmc: sdhci: fix vmmc handling").
>
> Signed-off-by: Marek Szyprowski<m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> ---
> arch/arm/mach-exynos/mach-nuri.c | 1 +
> arch/arm/mach-exynos/mach-universal_c210.c | 1 +
> arch/arm/mach-s5pv210/mach-goni.c | 2 ++
> 3 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c
> index 91e5986..021dc68 100644
> --- a/arch/arm/mach-exynos/mach-nuri.c
> +++ b/arch/arm/mach-exynos/mach-nuri.c
> @@ -112,6 +112,7 @@ static struct s3c_sdhci_platdata nuri_hsmmc0_data __initdata = {
> .host_caps = (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA |
> MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED |
> MMC_CAP_ERASE),
> + .host_caps2 = MMC_CAP2_BROKEN_VOLTAGE,
> .cd_type = S3C_SDHCI_CD_PERMANENT,
> };
>
> diff --git a/arch/arm/mach-exynos/mach-universal_c210.c b/arch/arm/mach-exynos/mach-universal_c210.c
> index ef706e9..add55b4 100644
> --- a/arch/arm/mach-exynos/mach-universal_c210.c
> +++ b/arch/arm/mach-exynos/mach-universal_c210.c
> @@ -747,6 +747,7 @@ static struct s3c_sdhci_platdata universal_hsmmc0_data __initdata = {
> .max_width = 8,
> .host_caps = (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA |
> MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED),
> + .host_caps2 = MMC_CAP2_BROKEN_VOLTAGE,
> .cd_type = S3C_SDHCI_CD_PERMANENT,
> };
>
> diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c
> index a8933de..3239566 100644
> --- a/arch/arm/mach-s5pv210/mach-goni.c
> +++ b/arch/arm/mach-s5pv210/mach-goni.c
> @@ -25,6 +25,7 @@
> #include<linux/gpio_keys.h>
> #include<linux/input.h>
> #include<linux/gpio.h>
> +#include<linux/mmc/host.h>
> #include<linux/interrupt.h>
>
> #include<asm/hardware/vic.h>
> @@ -765,6 +766,7 @@ static void __init goni_pmic_init(void)
> /* MoviNAND */
> static struct s3c_sdhci_platdata goni_hsmmc0_data __initdata = {
> .max_width = 4,
> + .host_caps2 = MMC_CAP2_BROKEN_VOLTAGE,
> .cd_type = S3C_SDHCI_CD_PERMANENT,
> };
>
OK, will apply.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH for v3.4-rc3] ARM: Samsung: add missing MMC_CAP2_BROKEN_VOLTAGE capability
Date: Tue, 24 Apr 2012 17:33:12 -0700 [thread overview]
Message-ID: <4F974648.6020702@samsung.com> (raw)
In-Reply-To: <1334558025-26635-1-git-send-email-m.szyprowski@samsung.com>
Marek Szyprowski wrote:
> Commit 6e8201f57c935 "mmc: core: add the capability for broken voltage"
> introduced a new quirk to indicate that MMC core should ignore voltage
> change errors reported by the regulators core. This is required to get
> SDHCI working on UniversalC210, NURI and GONI boards again after commit
> ceb6143b2df81c ("mmc: sdhci: fix vmmc handling").
>
> Signed-off-by: Marek Szyprowski<m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> ---
> arch/arm/mach-exynos/mach-nuri.c | 1 +
> arch/arm/mach-exynos/mach-universal_c210.c | 1 +
> arch/arm/mach-s5pv210/mach-goni.c | 2 ++
> 3 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c
> index 91e5986..021dc68 100644
> --- a/arch/arm/mach-exynos/mach-nuri.c
> +++ b/arch/arm/mach-exynos/mach-nuri.c
> @@ -112,6 +112,7 @@ static struct s3c_sdhci_platdata nuri_hsmmc0_data __initdata = {
> .host_caps = (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA |
> MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED |
> MMC_CAP_ERASE),
> + .host_caps2 = MMC_CAP2_BROKEN_VOLTAGE,
> .cd_type = S3C_SDHCI_CD_PERMANENT,
> };
>
> diff --git a/arch/arm/mach-exynos/mach-universal_c210.c b/arch/arm/mach-exynos/mach-universal_c210.c
> index ef706e9..add55b4 100644
> --- a/arch/arm/mach-exynos/mach-universal_c210.c
> +++ b/arch/arm/mach-exynos/mach-universal_c210.c
> @@ -747,6 +747,7 @@ static struct s3c_sdhci_platdata universal_hsmmc0_data __initdata = {
> .max_width = 8,
> .host_caps = (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA |
> MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED),
> + .host_caps2 = MMC_CAP2_BROKEN_VOLTAGE,
> .cd_type = S3C_SDHCI_CD_PERMANENT,
> };
>
> diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c
> index a8933de..3239566 100644
> --- a/arch/arm/mach-s5pv210/mach-goni.c
> +++ b/arch/arm/mach-s5pv210/mach-goni.c
> @@ -25,6 +25,7 @@
> #include<linux/gpio_keys.h>
> #include<linux/input.h>
> #include<linux/gpio.h>
> +#include<linux/mmc/host.h>
> #include<linux/interrupt.h>
>
> #include<asm/hardware/vic.h>
> @@ -765,6 +766,7 @@ static void __init goni_pmic_init(void)
> /* MoviNAND */
> static struct s3c_sdhci_platdata goni_hsmmc0_data __initdata = {
> .max_width = 4,
> + .host_caps2 = MMC_CAP2_BROKEN_VOLTAGE,
> .cd_type = S3C_SDHCI_CD_PERMANENT,
> };
>
OK, will apply.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-04-25 0:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 6:33 [PATCH for v3.4-rc3] ARM: Samsung: add missing MMC_CAP2_BROKEN_VOLTAGE capability Marek Szyprowski
2012-04-16 6:33 ` Marek Szyprowski
2012-04-25 0:33 ` Kukjin Kim [this message]
2012-04-25 0:33 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F974648.6020702@samsung.com \
--to=kgene.kim@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.