From: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
To: Linux Kernel <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"
<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
"cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Frederic Weisbecker
<fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Han Ying <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
"Aneesh Kumar K.V"
<aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
kamezawa.hiroyuki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: [RFC][PATCH 0/7 v2] memcg: prevent failure in pre_destroy()
Date: Fri, 27 Apr 2012 14:45:30 +0900 [thread overview]
Message-ID: <4F9A327A.6050409@jp.fujitsu.com> (raw)
This is a v2 patch for preventing failure in memcg->pre_destroy().
With this patch, ->pre_destroy() will never return error code and
users will not see warning at rmdir(). And this work will simplify
memcg->pre_destroy(), largely.
This patch is based on linux-next + hugetlb memory control patches.
I post this as RFC because I'll have vacation in the next week and
hugetlb patches are not visible in linux-next yet.
So, I'm not in hurry. Please review when you have time.
I'll rebase this onto memcg-devel in the next post.
== BTW, memory cgroup's github is here ==
git://github.com/mstsxfx/memcg-devel.git
Since v1, Whole patch designs are changed. In this version, I didn't
remove ->pre_destroy() but make it succeed always. There are no
asynchronous operation and no big patches. But this introduces
2 changes to cgroup core.
After this series, if use_hierarchy==0, all resources will be moved
to root cgroup at rmdir() or force_empty().
Brief patch conents are
0001 : my version of compile-fix for linux-next, Aneesh will post his own version.
0002 : fix error code in hugetlb_force_memcg_empty
0003 : add res_counter_uncharge_until()
0004 : use res_counter_uncharge_until() at move_parent()
0005 : move charges to root cgroup at rmdir, if use_hierarchy=0
0006 : clean up mem_cgroup_move_account()
0007 : cgroup : avoid attaching task to cgroup where ->pre_destroy() is running.
0008 : cgroup : avoid creating a new cgroup under a cgroup where ->pre_destroy() is running.
0009 : remove -EINTR from memcg->pre_destroy().
Thanks,
-Kame
WARNING: multiple messages have this Message-ID (diff)
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Glauber Costa <glommer@parallels.com>, Tejun Heo <tj@kernel.org>,
Han Ying <yinghan@google.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
kamezawa.hiroyuki@gmail.com
Subject: [RFC][PATCH 0/7 v2] memcg: prevent failure in pre_destroy()
Date: Fri, 27 Apr 2012 14:45:30 +0900 [thread overview]
Message-ID: <4F9A327A.6050409@jp.fujitsu.com> (raw)
This is a v2 patch for preventing failure in memcg->pre_destroy().
With this patch, ->pre_destroy() will never return error code and
users will not see warning at rmdir(). And this work will simplify
memcg->pre_destroy(), largely.
This patch is based on linux-next + hugetlb memory control patches.
I post this as RFC because I'll have vacation in the next week and
hugetlb patches are not visible in linux-next yet.
So, I'm not in hurry. Please review when you have time.
I'll rebase this onto memcg-devel in the next post.
== BTW, memory cgroup's github is here ==
git://github.com/mstsxfx/memcg-devel.git
Since v1, Whole patch designs are changed. In this version, I didn't
remove ->pre_destroy() but make it succeed always. There are no
asynchronous operation and no big patches. But this introduces
2 changes to cgroup core.
After this series, if use_hierarchy==0, all resources will be moved
to root cgroup at rmdir() or force_empty().
Brief patch conents are
0001 : my version of compile-fix for linux-next, Aneesh will post his own version.
0002 : fix error code in hugetlb_force_memcg_empty
0003 : add res_counter_uncharge_until()
0004 : use res_counter_uncharge_until() at move_parent()
0005 : move charges to root cgroup at rmdir, if use_hierarchy=0
0006 : clean up mem_cgroup_move_account()
0007 : cgroup : avoid attaching task to cgroup where ->pre_destroy() is running.
0008 : cgroup : avoid creating a new cgroup under a cgroup where ->pre_destroy() is running.
0009 : remove -EINTR from memcg->pre_destroy().
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Glauber Costa <glommer@parallels.com>, Tejun Heo <tj@kernel.org>,
Han Ying <yinghan@google.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
kamezawa.hiroyuki@gmail.com
Subject: [RFC][PATCH 0/7 v2] memcg: prevent failure in pre_destroy()
Date: Fri, 27 Apr 2012 14:45:30 +0900 [thread overview]
Message-ID: <4F9A327A.6050409@jp.fujitsu.com> (raw)
This is a v2 patch for preventing failure in memcg->pre_destroy().
With this patch, ->pre_destroy() will never return error code and
users will not see warning at rmdir(). And this work will simplify
memcg->pre_destroy(), largely.
This patch is based on linux-next + hugetlb memory control patches.
I post this as RFC because I'll have vacation in the next week and
hugetlb patches are not visible in linux-next yet.
So, I'm not in hurry. Please review when you have time.
I'll rebase this onto memcg-devel in the next post.
== BTW, memory cgroup's github is here ==
git://github.com/mstsxfx/memcg-devel.git
Since v1, Whole patch designs are changed. In this version, I didn't
remove ->pre_destroy() but make it succeed always. There are no
asynchronous operation and no big patches. But this introduces
2 changes to cgroup core.
After this series, if use_hierarchy==0, all resources will be moved
to root cgroup at rmdir() or force_empty().
Brief patch conents are
0001 : my version of compile-fix for linux-next, Aneesh will post his own version.
0002 : fix error code in hugetlb_force_memcg_empty
0003 : add res_counter_uncharge_until()
0004 : use res_counter_uncharge_until() at move_parent()
0005 : move charges to root cgroup at rmdir, if use_hierarchy=0
0006 : clean up mem_cgroup_move_account()
0007 : cgroup : avoid attaching task to cgroup where ->pre_destroy() is running.
0008 : cgroup : avoid creating a new cgroup under a cgroup where ->pre_destroy() is running.
0009 : remove -EINTR from memcg->pre_destroy().
Thanks,
-Kame
next reply other threads:[~2012-04-27 5:45 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 5:45 KAMEZAWA Hiroyuki [this message]
2012-04-27 5:45 ` [RFC][PATCH 0/7 v2] memcg: prevent failure in pre_destroy() KAMEZAWA Hiroyuki
2012-04-27 5:45 ` KAMEZAWA Hiroyuki
[not found] ` <4F9A327A.6050409-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-27 5:49 ` [RFC][PATCH 1/7 v2] temporal compile-fix in linux-next KAMEZAWA Hiroyuki
2012-04-27 5:49 ` KAMEZAWA Hiroyuki
2012-04-27 5:49 ` KAMEZAWA Hiroyuki
[not found] ` <4F9A3364.4090009-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-30 8:47 ` Aneesh Kumar K.V
2012-04-30 8:47 ` Aneesh Kumar K.V
2012-04-30 8:47 ` Aneesh Kumar K.V
2012-04-27 5:53 ` [RFC][PATCH 3/7 v2] res_counter: add res_counter_uncharge_until() KAMEZAWA Hiroyuki
2012-04-27 5:53 ` KAMEZAWA Hiroyuki
2012-04-27 5:53 ` KAMEZAWA Hiroyuki
2012-04-27 17:08 ` Glauber Costa
[not found] ` <4F9AD28C.60508-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-04-27 23:51 ` Hiroyuki Kamezawa
2012-04-27 23:51 ` Hiroyuki Kamezawa
2012-04-27 23:51 ` Hiroyuki Kamezawa
[not found] ` <4F9A343F.7020409-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-27 18:18 ` Tejun Heo
2012-04-27 18:18 ` Tejun Heo
2012-04-27 18:18 ` Tejun Heo
[not found] ` <20120427181840.GH26595-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-04-27 23:51 ` Hiroyuki Kamezawa
2012-04-27 23:51 ` Hiroyuki Kamezawa
2012-04-27 23:51 ` Hiroyuki Kamezawa
2012-04-27 6:00 ` [RFC][PATCH 6/9 v2] memcg: don't uncharge in mem_cgroup_move_account KAMEZAWA Hiroyuki
2012-04-27 6:00 ` KAMEZAWA Hiroyuki
2012-04-27 6:00 ` KAMEZAWA Hiroyuki
2012-04-27 6:04 ` [RFC][PATCH 8/9 v2] cgroup: avoid creating new cgroup under a cgroup being destroyed KAMEZAWA Hiroyuki
2012-04-27 6:04 ` KAMEZAWA Hiroyuki
2012-04-27 6:04 ` KAMEZAWA Hiroyuki
2012-04-27 17:18 ` Glauber Costa
[not found] ` <4F9A36DE.30301-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-27 20:40 ` Tejun Heo
2012-04-27 20:40 ` Tejun Heo
2012-04-27 20:40 ` Tejun Heo
2012-04-27 20:41 ` Tejun Heo
2012-04-27 20:41 ` Tejun Heo
[not found] ` <20120427204035.GN26595-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-04-28 0:20 ` Hiroyuki Kamezawa
2012-04-28 0:20 ` Hiroyuki Kamezawa
2012-04-28 0:20 ` Hiroyuki Kamezawa
2012-04-28 2:00 ` Tejun Heo
2012-04-28 2:00 ` Tejun Heo
2012-04-28 9:31 ` Hiroyuki Kamezawa
2012-04-28 9:31 ` Hiroyuki Kamezawa
2012-04-28 21:31 ` Tejun Heo
2012-04-28 21:31 ` Tejun Heo
2012-04-28 21:31 ` Tejun Heo
2012-04-27 18:16 ` [RFC][PATCH 0/7 v2] memcg: prevent failure in pre_destroy() Tejun Heo
2012-04-27 18:16 ` Tejun Heo
2012-04-27 18:16 ` Tejun Heo
[not found] ` <20120427181642.GG26595-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-04-27 23:48 ` Hiroyuki Kamezawa
2012-04-27 23:48 ` Hiroyuki Kamezawa
2012-04-27 23:48 ` Hiroyuki Kamezawa
[not found] ` <CABEgKgrir3PBGqm_9FmYsZTiFqsZ=Cdt5iZDu5WcOHPtZuEbFg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-28 16:13 ` Michal Hocko
2012-04-28 16:13 ` Michal Hocko
2012-04-28 16:13 ` Michal Hocko
[not found] ` <20120428161358.GA13010-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2012-04-29 6:03 ` Michal Hocko
2012-04-29 6:03 ` Michal Hocko
2012-04-29 6:03 ` Michal Hocko
2012-04-27 5:51 ` [RFC][PATCH 2/7 v2] memcg: fix error code in hugetlb_force_memcg_empty() KAMEZAWA Hiroyuki
2012-04-27 5:51 ` KAMEZAWA Hiroyuki
2012-04-30 8:49 ` Aneesh Kumar K.V
2012-04-30 8:49 ` Aneesh Kumar K.V
2012-04-27 5:54 ` [RFC][PATCH 4/7 v2] memcg: use res_counter_uncharge_until in move_parent KAMEZAWA Hiroyuki
2012-04-27 5:54 ` KAMEZAWA Hiroyuki
2012-04-27 17:16 ` Glauber Costa
[not found] ` <4F9AD455.9030306-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-04-27 18:26 ` Ying Han
2012-04-27 18:26 ` Ying Han
2012-04-27 18:26 ` Ying Han
2012-04-27 20:11 ` Glauber Costa
2012-04-27 23:58 ` Hiroyuki Kamezawa
2012-04-27 23:58 ` Hiroyuki Kamezawa
2012-04-27 23:58 ` Hiroyuki Kamezawa
[not found] ` <4F9A34B2.8080103-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-27 18:20 ` Tejun Heo
2012-04-27 18:20 ` Tejun Heo
2012-04-27 18:20 ` Tejun Heo
2012-04-27 23:59 ` Hiroyuki Kamezawa
2012-04-27 23:59 ` Hiroyuki Kamezawa
2012-04-30 9:00 ` Aneesh Kumar K.V
2012-04-30 9:00 ` Aneesh Kumar K.V
2012-04-30 9:00 ` Aneesh Kumar K.V
2012-04-27 5:58 ` [RFC][PATCH 5/9 v2] move charges to root at rmdir if use_hierarchy is unset KAMEZAWA Hiroyuki
2012-04-27 5:58 ` KAMEZAWA Hiroyuki
[not found] ` <4F9A359C.10107-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-27 19:12 ` Ying Han
2012-04-27 19:12 ` Ying Han
2012-04-27 19:12 ` Ying Han
[not found] ` <CALWz4ixHGCqfWh1U+JyiJWTkGmCDtXQy1vbHRjrHaU_pOgGuBw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-28 0:01 ` Hiroyuki Kamezawa
2012-04-28 0:01 ` Hiroyuki Kamezawa
2012-04-28 0:01 ` Hiroyuki Kamezawa
2012-04-30 9:07 ` Aneesh Kumar K.V
2012-04-30 9:07 ` Aneesh Kumar K.V
2012-04-30 9:07 ` Aneesh Kumar K.V
2012-04-27 6:02 ` [RFC][PATCH 7/9 v2] cgroup: avoid attaching task to a cgroup under rmdir() KAMEZAWA Hiroyuki
2012-04-27 6:02 ` KAMEZAWA Hiroyuki
2012-04-27 10:39 ` Frederic Weisbecker
2012-04-27 10:39 ` Frederic Weisbecker
[not found] ` <20120427103927.GA3514-oHC15RC7JGTpAmv0O++HtFaTQe2KTcn/@public.gmane.org>
2012-04-28 0:06 ` Hiroyuki Kamezawa
2012-04-28 0:06 ` Hiroyuki Kamezawa
2012-04-28 0:06 ` Hiroyuki Kamezawa
[not found] ` <4F9A366E.9020307-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-27 20:31 ` Tejun Heo
2012-04-27 20:31 ` Tejun Heo
2012-04-27 20:31 ` Tejun Heo
[not found] ` <20120427203159.GL26595-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-04-27 20:33 ` Tejun Heo
2012-04-27 20:33 ` Tejun Heo
2012-04-27 20:33 ` Tejun Heo
2012-04-27 6:06 ` [RFC][PATCH 9/9 v2] memcg: never return error at pre_destroy() KAMEZAWA Hiroyuki
2012-04-27 6:06 ` KAMEZAWA Hiroyuki
2012-04-27 21:28 ` Ying Han
2012-04-27 21:28 ` Ying Han
[not found] ` <CALWz4iyiM-CFgVaHiE1Lgd1ZwJzHwY3tx9XX6HeDPUV_wVPAtQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-28 0:25 ` Hiroyuki Kamezawa
2012-04-28 0:25 ` Hiroyuki Kamezawa
2012-04-28 0:25 ` Hiroyuki Kamezawa
2012-04-30 17:02 ` Ying Han
2012-04-30 17:02 ` Ying Han
2012-05-01 22:28 ` Suleiman Souhlal
2012-05-01 22:28 ` Suleiman Souhlal
[not found] ` <CABCjUKBhNkGf2QHzONMod3HmHgS-HxB5hUxpfJFHUG-eBkYBRw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-02 3:34 ` Hiroyuki Kamezawa
2012-05-02 3:34 ` Hiroyuki Kamezawa
2012-05-02 3:34 ` Hiroyuki Kamezawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9A327A.6050409@jp.fujitsu.com \
--to=kamezawa.hiroyu-+cum20s59erqfuhtdcdx3a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kamezawa.hiroyuki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.