All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: Regression in 32-bit ppc kernel
Date: Sat, 28 Apr 2012 13:09:22 -0500	[thread overview]
Message-ID: <4F9C3252.7020508@lwfinger.net> (raw)
In-Reply-To: <1335573757.20866.12.camel@pasglop>

On 04/27/2012 07:42 PM, Benjamin Herrenschmidt wrote:
>
> Ok, so you do have a serial port, probably two even :-) One of them is
> connected to the infra red transceiver and the other one is probably
> connected to the internal modem.
>
> (The modem itself might not use it, some of these machines use an
> i2s/i2c modem, some use a usb modem, but the serial port is wired to the
> connector regardless).

I have done a little more debugging. The problem is definitely coming from 
drivers/tty/serial/pmac_zilog.c. I am getting ChanB interrupts while open, which 
causes the following code segment to return IRQ_NONE:

        if (r3 & (CHBEXT | CHBTxIP | CHBRxIP)) {
                if (!ZS_IS_OPEN(uap_a)) {
                        pmz_debug("ChanB interrupt while open !\n");
                        goto skip_b;
                }
                write_zsreg(uap_b, R0, RES_H_IUS);
                zssync(uap_b);
                if (r3 & CHBEXT)

When this section is entered, r3 == 0x2 (CHBTxIP).

Larry

WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: Regression in 32-bit ppc kernel
Date: Sat, 28 Apr 2012 13:09:22 -0500	[thread overview]
Message-ID: <4F9C3252.7020508@lwfinger.net> (raw)
In-Reply-To: <1335573757.20866.12.camel@pasglop>

On 04/27/2012 07:42 PM, Benjamin Herrenschmidt wrote:
>
> Ok, so you do have a serial port, probably two even :-) One of them is
> connected to the infra red transceiver and the other one is probably
> connected to the internal modem.
>
> (The modem itself might not use it, some of these machines use an
> i2s/i2c modem, some use a usb modem, but the serial port is wired to the
> connector regardless).

I have done a little more debugging. The problem is definitely coming from 
drivers/tty/serial/pmac_zilog.c. I am getting ChanB interrupts while open, which 
causes the following code segment to return IRQ_NONE:

        if (r3 & (CHBEXT | CHBTxIP | CHBRxIP)) {
                if (!ZS_IS_OPEN(uap_a)) {
                        pmz_debug("ChanB interrupt while open !\n");
                        goto skip_b;
                }
                write_zsreg(uap_b, R0, RES_H_IUS);
                zssync(uap_b);
                if (r3 & CHBEXT)

When this section is entered, r3 == 0x2 (CHBTxIP).

Larry

  reply	other threads:[~2012-04-28 18:09 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24 22:58 Regression in 32-bit ppc kernel Larry Finger
2012-04-24 23:53 ` Benjamin Herrenschmidt
2012-04-24 23:53   ` Benjamin Herrenschmidt
2012-04-25  2:37   ` Larry Finger
2012-04-25  2:37     ` Larry Finger
2012-04-25  4:11     ` Benjamin Herrenschmidt
2012-04-25  4:11       ` Benjamin Herrenschmidt
2012-04-25 15:00       ` Larry Finger
2012-04-25 15:00         ` Larry Finger
2012-04-25 21:44         ` Benjamin Herrenschmidt
2012-04-25 21:44           ` Benjamin Herrenschmidt
2012-04-27 15:38           ` Larry Finger
2012-04-27 15:38             ` Larry Finger
2012-04-27 22:26             ` Benjamin Herrenschmidt
2012-04-27 22:26               ` Benjamin Herrenschmidt
2012-04-28  0:02               ` Larry Finger
2012-04-28  0:02                 ` Larry Finger
2012-04-28  0:42                 ` Benjamin Herrenschmidt
2012-04-28  0:42                   ` Benjamin Herrenschmidt
2012-04-28 18:09                   ` Larry Finger [this message]
2012-04-28 18:09                     ` Larry Finger
2012-04-28 18:23                     ` Andreas Schwab
2012-04-28 18:23                       ` Andreas Schwab
2012-04-28 22:48                       ` Benjamin Herrenschmidt
2012-04-28 22:48                         ` Benjamin Herrenschmidt
2012-04-28 23:17                         ` Larry Finger
2012-04-28 23:17                           ` Larry Finger
2012-04-28 23:23                           ` Benjamin Herrenschmidt
2012-04-28 23:23                             ` Benjamin Herrenschmidt
2012-04-28 23:30                             ` Larry Finger
2012-04-28 23:30                               ` Larry Finger
2012-04-28 22:41                     ` Benjamin Herrenschmidt
2012-04-28 22:41                       ` Benjamin Herrenschmidt
2012-04-28 22:42                       ` Benjamin Herrenschmidt
2012-04-28 22:42                         ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F9C3252.7020508@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.