From: Larry Finger <Larry.Finger@lwfinger.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>,
Andreas Schwab <schwab@linux-m68k.org>,
linuxppc-dev@lists.ozlabs.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Regression in 32-bit ppc kernel
Date: Sat, 28 Apr 2012 18:17:34 -0500 [thread overview]
Message-ID: <4F9C7A8E.1020009@lwfinger.net> (raw)
In-Reply-To: <1335653288.20866.15.camel@pasglop>
On 04/28/2012 05:48 PM, Benjamin Herrenschmidt wrote:
> On Sat, 2012-04-28 at 20:23 +0200, Andreas Schwab wrote:
>> Larry Finger<Larry.Finger@lwfinger.net> writes:
>>
>>> I have done a little more debugging. The problem is definitely coming from
>>> drivers/tty/serial/pmac_zilog.c. I am getting ChanB interrupts while open,
>>> which causes the following code segment to return IRQ_NONE:
>>>
>>> if (r3& (CHBEXT | CHBTxIP | CHBRxIP)) {
>>> if (!ZS_IS_OPEN(uap_a)) {
>>
>> s/uap_a/uap_b/?
>
> Good catch... Let's see if that fixes it for Larry...
Yes, good catch by Andreas. That change does fix the problem.
Ben - Do you want to fix the typos for open/not open with the same patch?
Larry
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Regression in 32-bit ppc kernel
Date: Sat, 28 Apr 2012 18:17:34 -0500 [thread overview]
Message-ID: <4F9C7A8E.1020009@lwfinger.net> (raw)
In-Reply-To: <1335653288.20866.15.camel@pasglop>
On 04/28/2012 05:48 PM, Benjamin Herrenschmidt wrote:
> On Sat, 2012-04-28 at 20:23 +0200, Andreas Schwab wrote:
>> Larry Finger<Larry.Finger@lwfinger.net> writes:
>>
>>> I have done a little more debugging. The problem is definitely coming from
>>> drivers/tty/serial/pmac_zilog.c. I am getting ChanB interrupts while open,
>>> which causes the following code segment to return IRQ_NONE:
>>>
>>> if (r3& (CHBEXT | CHBTxIP | CHBRxIP)) {
>>> if (!ZS_IS_OPEN(uap_a)) {
>>
>> s/uap_a/uap_b/?
>
> Good catch... Let's see if that fixes it for Larry...
Yes, good catch by Andreas. That change does fix the problem.
Ben - Do you want to fix the typos for open/not open with the same patch?
Larry
next prev parent reply other threads:[~2012-04-28 23:17 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 22:58 Regression in 32-bit ppc kernel Larry Finger
2012-04-24 23:53 ` Benjamin Herrenschmidt
2012-04-24 23:53 ` Benjamin Herrenschmidt
2012-04-25 2:37 ` Larry Finger
2012-04-25 2:37 ` Larry Finger
2012-04-25 4:11 ` Benjamin Herrenschmidt
2012-04-25 4:11 ` Benjamin Herrenschmidt
2012-04-25 15:00 ` Larry Finger
2012-04-25 15:00 ` Larry Finger
2012-04-25 21:44 ` Benjamin Herrenschmidt
2012-04-25 21:44 ` Benjamin Herrenschmidt
2012-04-27 15:38 ` Larry Finger
2012-04-27 15:38 ` Larry Finger
2012-04-27 22:26 ` Benjamin Herrenschmidt
2012-04-27 22:26 ` Benjamin Herrenschmidt
2012-04-28 0:02 ` Larry Finger
2012-04-28 0:02 ` Larry Finger
2012-04-28 0:42 ` Benjamin Herrenschmidt
2012-04-28 0:42 ` Benjamin Herrenschmidt
2012-04-28 18:09 ` Larry Finger
2012-04-28 18:09 ` Larry Finger
2012-04-28 18:23 ` Andreas Schwab
2012-04-28 18:23 ` Andreas Schwab
2012-04-28 22:48 ` Benjamin Herrenschmidt
2012-04-28 22:48 ` Benjamin Herrenschmidt
2012-04-28 23:17 ` Larry Finger [this message]
2012-04-28 23:17 ` Larry Finger
2012-04-28 23:23 ` Benjamin Herrenschmidt
2012-04-28 23:23 ` Benjamin Herrenschmidt
2012-04-28 23:30 ` Larry Finger
2012-04-28 23:30 ` Larry Finger
2012-04-28 22:41 ` Benjamin Herrenschmidt
2012-04-28 22:41 ` Benjamin Herrenschmidt
2012-04-28 22:42 ` Benjamin Herrenschmidt
2012-04-28 22:42 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9C7A8E.1020009@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.