Re: [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Eric Nelson <eric.nelson@boundarydevices.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	u-boot@lists.denx.de, rylv50@freescale.com, marex@denx.de,
	vapier@gentoo.org
Subject: Re: [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line
Date: Thu, 03 May 2012 06:41:08 -0700	[thread overview]
Message-ID: <4FA28AF4.1000205@boundarydevices.com> (raw)
In-Reply-To: <1336017507.13866.2.camel@joe2Laptop>

Thanks Joe,

On 05/02/2012 08:58 PM, Joe Perches wrote:
> On Wed, 2012-05-02 at 20:32 -0700, Eric Nelson wrote:
>> This tests for a bad habits of mine like this:
>>
>> 	return 0 ;
>>
>> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
>> ---
>>   scripts/checkpatch.pl |    6 ++++++
>>   1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index a3b9782..0e6977e 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -3227,6 +3227,12 @@ sub process {
>>   			 "Statements terminations use 1 semicolon\n" . $herecurr);
>>   		}
>>
>> +# check for whitespace before semicolon - not allowed at end-of-line
>> +		if ($line =~ /\s+;$/) {
>
> 		if ($line =~ /\s+;\s*$/)
>
Won't the extra space at end of line be caught by other tests?

>> +		    WARN("SPACEBEFORE_SEMICOLON",
>
> 		WARN("SPACING",
>

WARNING: multiple messages have this Message-ID (diff)

From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line
Date: Thu, 03 May 2012 06:41:08 -0700	[thread overview]
Message-ID: <4FA28AF4.1000205@boundarydevices.com> (raw)
In-Reply-To: <1336017507.13866.2.camel@joe2Laptop>

Thanks Joe,

On 05/02/2012 08:58 PM, Joe Perches wrote:
> On Wed, 2012-05-02 at 20:32 -0700, Eric Nelson wrote:
>> This tests for a bad habits of mine like this:
>>
>> 	return 0 ;
>>
>> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
>> ---
>>   scripts/checkpatch.pl |    6 ++++++
>>   1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index a3b9782..0e6977e 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -3227,6 +3227,12 @@ sub process {
>>   			 "Statements terminations use 1 semicolon\n" . $herecurr);
>>   		}
>>
>> +# check for whitespace before semicolon - not allowed at end-of-line
>> +		if ($line =~ /\s+;$/) {
>
> 		if ($line =~ /\s+;\s*$/)
>
Won't the extra space at end of line be caught by other tests?

>> +		    WARN("SPACEBEFORE_SEMICOLON",
>
> 		WARN("SPACING",
>

next prev parent reply	other threads:[~2012-05-03 13:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <http://lists.denx.de/pipermail/u-boot/2012-May/123595.html>
2012-05-03  3:32 ` [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line Eric Nelson
2012-05-03  3:32   ` [U-Boot] " Eric Nelson
2012-05-03  3:58   ` Joe Perches
2012-05-03  3:58     ` [U-Boot] " Joe Perches
2012-05-03 13:41     ` Eric Nelson [this message]
2012-05-03 13:41       ` Eric Nelson
2012-05-03 15:52       ` Joe Perches
2012-05-03 15:52         ` [U-Boot] " Joe Perches
2012-06-21 19:30   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FA28AF4.1000205@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=joe@perches.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=rylv50@freescale.com \
    --cc=u-boot@lists.denx.de \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.