* [U-Boot] [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line
@ 2012-05-03 3:32 ` Eric Nelson
0 siblings, 0 replies; 9+ messages in thread
From: Eric Nelson @ 2012-05-03 3:32 UTC (permalink / raw)
To: u-boot
This tests for a bad habits of mine like this:
return 0 ;
Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
scripts/checkpatch.pl | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a3b9782..0e6977e 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3227,6 +3227,12 @@ sub process {
"Statements terminations use 1 semicolon\n" . $herecurr);
}
+# check for whitespace before semicolon - not allowed at end-of-line
+ if ($line =~ /\s+;$/) {
+ WARN("SPACEBEFORE_SEMICOLON",
+ "Whitespace before semicolon\n" . $herecurr);
+ }
+
# check for gcc specific __FUNCTION__
if ($line =~ /__FUNCTION__/) {
WARN("USE_FUNC",
--
1.7.9
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line
2012-05-03 3:32 ` [U-Boot] " Eric Nelson
@ 2012-05-03 3:58 ` Joe Perches
-1 siblings, 0 replies; 9+ messages in thread
From: Joe Perches @ 2012-05-03 3:58 UTC (permalink / raw)
To: Eric Nelson; +Cc: linux-kernel, linux-kbuild, u-boot, rylv50, marex, vapier
On Wed, 2012-05-02 at 20:32 -0700, Eric Nelson wrote:
> This tests for a bad habits of mine like this:
>
> return 0 ;
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
> scripts/checkpatch.pl | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a3b9782..0e6977e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3227,6 +3227,12 @@ sub process {
> "Statements terminations use 1 semicolon\n" . $herecurr);
> }
>
> +# check for whitespace before semicolon - not allowed at end-of-line
> + if ($line =~ /\s+;$/) {
if ($line =~ /\s+;\s*$/)
> + WARN("SPACEBEFORE_SEMICOLON",
WARN("SPACING",
> + "Whitespace before semicolon\n" . $herecurr);
> + }
> +
^ permalink raw reply [flat|nested] 9+ messages in thread* [U-Boot] [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line
@ 2012-05-03 3:58 ` Joe Perches
0 siblings, 0 replies; 9+ messages in thread
From: Joe Perches @ 2012-05-03 3:58 UTC (permalink / raw)
To: u-boot
On Wed, 2012-05-02 at 20:32 -0700, Eric Nelson wrote:
> This tests for a bad habits of mine like this:
>
> return 0 ;
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
> scripts/checkpatch.pl | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a3b9782..0e6977e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3227,6 +3227,12 @@ sub process {
> "Statements terminations use 1 semicolon\n" . $herecurr);
> }
>
> +# check for whitespace before semicolon - not allowed at end-of-line
> + if ($line =~ /\s+;$/) {
if ($line =~ /\s+;\s*$/)
> + WARN("SPACEBEFORE_SEMICOLON",
WARN("SPACING",
> + "Whitespace before semicolon\n" . $herecurr);
> + }
> +
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line
2012-05-03 3:58 ` [U-Boot] " Joe Perches
@ 2012-05-03 13:41 ` Eric Nelson
-1 siblings, 0 replies; 9+ messages in thread
From: Eric Nelson @ 2012-05-03 13:41 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-kernel, linux-kbuild, u-boot, rylv50, marex, vapier
Thanks Joe,
On 05/02/2012 08:58 PM, Joe Perches wrote:
> On Wed, 2012-05-02 at 20:32 -0700, Eric Nelson wrote:
>> This tests for a bad habits of mine like this:
>>
>> return 0 ;
>>
>> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
>> ---
>> scripts/checkpatch.pl | 6 ++++++
>> 1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index a3b9782..0e6977e 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -3227,6 +3227,12 @@ sub process {
>> "Statements terminations use 1 semicolon\n" . $herecurr);
>> }
>>
>> +# check for whitespace before semicolon - not allowed at end-of-line
>> + if ($line =~ /\s+;$/) {
>
> if ($line =~ /\s+;\s*$/)
>
Won't the extra space at end of line be caught by other tests?
>> + WARN("SPACEBEFORE_SEMICOLON",
>
> WARN("SPACING",
>
^ permalink raw reply [flat|nested] 9+ messages in thread* [U-Boot] [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line
@ 2012-05-03 13:41 ` Eric Nelson
0 siblings, 0 replies; 9+ messages in thread
From: Eric Nelson @ 2012-05-03 13:41 UTC (permalink / raw)
To: u-boot
Thanks Joe,
On 05/02/2012 08:58 PM, Joe Perches wrote:
> On Wed, 2012-05-02 at 20:32 -0700, Eric Nelson wrote:
>> This tests for a bad habits of mine like this:
>>
>> return 0 ;
>>
>> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
>> ---
>> scripts/checkpatch.pl | 6 ++++++
>> 1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index a3b9782..0e6977e 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -3227,6 +3227,12 @@ sub process {
>> "Statements terminations use 1 semicolon\n" . $herecurr);
>> }
>>
>> +# check for whitespace before semicolon - not allowed at end-of-line
>> + if ($line =~ /\s+;$/) {
>
> if ($line =~ /\s+;\s*$/)
>
Won't the extra space at end of line be caught by other tests?
>> + WARN("SPACEBEFORE_SEMICOLON",
>
> WARN("SPACING",
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line
2012-05-03 13:41 ` [U-Boot] " Eric Nelson
@ 2012-05-03 15:52 ` Joe Perches
-1 siblings, 0 replies; 9+ messages in thread
From: Joe Perches @ 2012-05-03 15:52 UTC (permalink / raw)
To: Eric Nelson; +Cc: linux-kernel, linux-kbuild, u-boot, rylv50, marex, vapier
On Thu, 2012-05-03 at 06:41 -0700, Eric Nelson wrote:
> >> +# check for whitespace before semicolon - not allowed at end-of-line
> >> + if ($line =~ /\s+;$/) {
> >
> > if ($line =~ /\s+;\s*$/)
> Won't the extra space at end of line be caught by other tests?
Yes it will.
You want the test to find the space before semicolon
whenever it exists.
^ permalink raw reply [flat|nested] 9+ messages in thread* [U-Boot] [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line
@ 2012-05-03 15:52 ` Joe Perches
0 siblings, 0 replies; 9+ messages in thread
From: Joe Perches @ 2012-05-03 15:52 UTC (permalink / raw)
To: u-boot
On Thu, 2012-05-03 at 06:41 -0700, Eric Nelson wrote:
> >> +# check for whitespace before semicolon - not allowed at end-of-line
> >> + if ($line =~ /\s+;$/) {
> >
> > if ($line =~ /\s+;\s*$/)
> Won't the extra space at end of line be caught by other tests?
Yes it will.
You want the test to find the space before semicolon
whenever it exists.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line
2012-05-03 3:32 ` [U-Boot] " Eric Nelson
(?)
(?)
@ 2012-06-21 19:30 ` Wolfgang Denk
-1 siblings, 0 replies; 9+ messages in thread
From: Wolfgang Denk @ 2012-06-21 19:30 UTC (permalink / raw)
To: u-boot
Dear Eric Nelson,
In message <1336015938-3174-1-git-send-email-eric.nelson@boundarydevices.com> you wrote:
> This tests for a bad habits of mine like this:
>
> return 0 ;
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
> scripts/checkpatch.pl | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
Applied to tools/checkpatch.pl, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The use of Microsoft crippleware systems is a sin that carries with
it its own punishment.
-- Tom Christiansen in <6bo3fr$pj8$5@csnews.cs.colorado.edu>
^ permalink raw reply [flat|nested] 9+ messages in thread