From: John Crispin <john@phrozen.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-mips@linux-mips.org, devicetree-discuss@lists.ozlabs.org,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 04/14] OF: pinctrl: MIPS: lantiq: implement lantiq/xway pinctrl support
Date: Tue, 08 May 2012 17:59:33 +0200 [thread overview]
Message-ID: <4FA942E5.20906@phrozen.org> (raw)
In-Reply-To: <4FA940F3.4090008@wwwdotorg.org>
>> How about we do the following.
>>
>> config LANTIQ
>> select PINCTRL
>>
>> config PINCTRL_LANTIQ
>> def_bool y
>> depends on LANTIQ
>>
>> config PINCTRL_LANTIQ_XWAY
>> def_bool y
>> depends on SOC_TYPE_XWAY
>>
>> This would auto select the right symbols, have all the dependency logic
>> in 1 place and reduce the size of arch/mips/lantiq/Kconfig
>
> Is it useful to build a kernel for XWAY without pinctrl, once the driver
> is there? That's the main difference between arch/mips/lantiq/Kconfig
> selecting PINCTRL_LANTIQ_XWAY vs that being a def_bool, and hence
> allowing the user to deselect it.
>
it would not make sense to build an image without.
config LANTIQ and config SOC_TYPE_XWAY should explicitly select the
symbols that they need.
WARNING: multiple messages have this Message-ID (diff)
From: John Crispin <john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
Subject: Re: [PATCH 04/14] OF: pinctrl: MIPS: lantiq: implement lantiq/xway pinctrl support
Date: Tue, 08 May 2012 17:59:33 +0200 [thread overview]
Message-ID: <4FA942E5.20906@phrozen.org> (raw)
In-Reply-To: <4FA940F3.4090008-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
>> How about we do the following.
>>
>> config LANTIQ
>> select PINCTRL
>>
>> config PINCTRL_LANTIQ
>> def_bool y
>> depends on LANTIQ
>>
>> config PINCTRL_LANTIQ_XWAY
>> def_bool y
>> depends on SOC_TYPE_XWAY
>>
>> This would auto select the right symbols, have all the dependency logic
>> in 1 place and reduce the size of arch/mips/lantiq/Kconfig
>
> Is it useful to build a kernel for XWAY without pinctrl, once the driver
> is there? That's the main difference between arch/mips/lantiq/Kconfig
> selecting PINCTRL_LANTIQ_XWAY vs that being a def_bool, and hence
> allowing the user to deselect it.
>
it would not make sense to build an image without.
config LANTIQ and config SOC_TYPE_XWAY should explicitly select the
symbols that they need.
next prev parent reply other threads:[~2012-05-08 16:01 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 12:18 [PATCH 01/14] MIPS: lantiq: drop mips_machine support John Crispin
2012-05-04 12:18 ` [PATCH 02/14] OF: MIPS: lantiq: implement OF support John Crispin
2012-05-04 12:18 ` John Crispin
2012-05-12 0:47 ` Grant Likely
2012-05-12 0:47 ` Grant Likely
2012-05-04 12:18 ` [PATCH 03/14] OF: MIPS: lantiq: implement irq_domain support John Crispin
2012-05-04 12:18 ` John Crispin
2012-05-08 17:53 ` Grant Likely
2012-05-08 17:53 ` Grant Likely
2012-05-08 18:05 ` John Crispin
2012-05-08 18:05 ` John Crispin
2012-05-04 12:18 ` [PATCH 04/14] OF: pinctrl: MIPS: lantiq: implement lantiq/xway pinctrl support John Crispin
2012-05-04 12:18 ` John Crispin
2012-05-04 20:57 ` Stephen Warren
[not found] ` <4FA442B6.1020501-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-05-04 21:29 ` John Crispin
2012-05-08 13:21 ` Linus Walleij
2012-05-08 13:21 ` Linus Walleij
2012-05-08 14:12 ` John Crispin
2012-05-08 14:12 ` John Crispin
2012-05-08 15:28 ` Stephen Warren
2012-05-08 15:28 ` Stephen Warren
2012-05-08 15:39 ` John Crispin
2012-05-08 15:39 ` John Crispin
2012-05-08 15:51 ` Stephen Warren
2012-05-08 15:51 ` Stephen Warren
2012-05-08 15:59 ` John Crispin [this message]
2012-05-08 15:59 ` John Crispin
2012-05-04 12:18 ` [PATCH 05/14] MIPS: lantiq: implement support for clkdev api John Crispin
2012-05-04 12:18 ` [PATCH 06/14] MIPS: lantiq: convert dma to platform driver John Crispin
2012-05-04 12:18 ` [PATCH 07/14] MIPS: pci: convert lantiq driver to OF John Crispin
2012-05-04 12:18 ` [PATCH 08/14] GPIO: MIPS: lantiq: convert gpio-stp to OF and move it to subsystem John Crispin
2012-05-04 12:18 ` [PATCH 09/14] GPIO: MIPS: lantiq: convert gpio-ebu " John Crispin
2012-05-04 12:18 ` [PATCH 10/14] SERIAL: MIPS: lantiq: implement OF support John Crispin
2012-05-04 12:18 ` [PATCH 11/14] watchdog: MIPS: lantiq: implement OF support and minor fixes John Crispin
2012-05-04 13:22 ` Wim Van Sebroeck
2012-05-04 12:18 ` [PATCH 12/14] MTD: MIPS: lantiq: implement OF support John Crispin
2012-05-04 12:18 ` John Crispin
2012-05-11 14:06 ` Artem Bityutskiy
2012-05-11 14:06 ` Artem Bityutskiy
2012-05-11 14:04 ` John Crispin
2012-05-11 14:04 ` John Crispin
2012-05-11 14:16 ` Artem Bityutskiy
2012-05-11 14:16 ` Artem Bityutskiy
2012-05-14 12:21 ` Artem Bityutskiy
2012-05-14 12:21 ` Artem Bityutskiy
2012-05-14 12:31 ` John Crispin
2012-05-04 12:18 ` [PATCH 13/14] NET: MIPS: lantiq: implement OF support inside the etop driver John Crispin
2012-05-04 12:18 ` [PATCH 14/14] MIPS: lantiq: remove orphaned code John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA942E5.20906@phrozen.org \
--to=john@phrozen.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linus.walleij@linaro.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.