* [PATCH] x86/irq: fix locking for c/s 24707:96987c324a4f debugging code
@ 2012-05-10 9:21 Jan Beulich
2012-05-10 9:26 ` Andrew Cooper
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2012-05-10 9:21 UTC (permalink / raw)
To: xen-devel; +Cc: andrew.cooper3
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
Without this, dump_irqs() may try to acquire the lock the caller is
currently holding.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -668,6 +668,7 @@ void irq_move_cleanup_interrupt(struct c
{
if ( unlikely(!test_bit(vector, desc->arch.used_vectors)) )
{
+ spin_unlock(&desc->lock);
bitmap_scnlistprintf(keyhandler_scratch,
sizeof(keyhandler_scratch),
desc->arch.used_vectors->_bits,
[-- Attachment #2: x86-24707-locking.patch --]
[-- Type: text/plain, Size: 692 bytes --]
x86/irq: fix locking for c/s 24707:96987c324a4f debugging code
Without this, dump_irqs() may try to acquire the lock the caller is
currently holding.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -668,6 +668,7 @@ void irq_move_cleanup_interrupt(struct c
{
if ( unlikely(!test_bit(vector, desc->arch.used_vectors)) )
{
+ spin_unlock(&desc->lock);
bitmap_scnlistprintf(keyhandler_scratch,
sizeof(keyhandler_scratch),
desc->arch.used_vectors->_bits,
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/irq: fix locking for c/s 24707:96987c324a4f debugging code
2012-05-10 9:21 [PATCH] x86/irq: fix locking for c/s 24707:96987c324a4f debugging code Jan Beulich
@ 2012-05-10 9:26 ` Andrew Cooper
2012-05-10 9:33 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cooper @ 2012-05-10 9:26 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel
On 10/05/12 10:21, Jan Beulich wrote:
> Without this, dump_irqs() may try to acquire the lock the caller is
> currently holding.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
With the proviso that this is patch will disappear when all (3 so far)
of these debugging patches disappear.
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/arch/x86/irq.c
> +++ b/xen/arch/x86/irq.c
> @@ -668,6 +668,7 @@ void irq_move_cleanup_interrupt(struct c
> {
> if ( unlikely(!test_bit(vector, desc->arch.used_vectors)) )
> {
> + spin_unlock(&desc->lock);
> bitmap_scnlistprintf(keyhandler_scratch,
> sizeof(keyhandler_scratch),
> desc->arch.used_vectors->_bits,
>
>
>
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/irq: fix locking for c/s 24707:96987c324a4f debugging code
2012-05-10 9:26 ` Andrew Cooper
@ 2012-05-10 9:33 ` Jan Beulich
0 siblings, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2012-05-10 9:33 UTC (permalink / raw)
To: Andrew Cooper; +Cc: xen-devel
>>> On 10.05.12 at 11:26, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> On 10/05/12 10:21, Jan Beulich wrote:
>> Without this, dump_irqs() may try to acquire the lock the caller is
>> currently holding.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> With the proviso that this is patch will disappear when all (3 so far)
> of these debugging patches disappear.
That must be the goal, sure.
Jan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-10 9:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-10 9:21 [PATCH] x86/irq: fix locking for c/s 24707:96987c324a4f debugging code Jan Beulich
2012-05-10 9:26 ` Andrew Cooper
2012-05-10 9:33 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.