All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-xfs@oss.sgi.com, sandeen@sandeen.net,
	Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>,
	Tejun Heo <tj@kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	Kent Overstreet <kent.overstreet@gmail.com>
Subject: Re: [PATCH] bio allocation failure due to bio_get_nr_vecs()
Date: Fri, 11 May 2012 16:36:04 +0200	[thread overview]
Message-ID: <4FAD23D4.2070405@kernel.dk> (raw)
In-Reply-To: <x49sjf6vml5.fsf@segfault.boston.devel.redhat.com>

On 05/11/2012 04:06 PM, Jeff Moyer wrote:
> Bernd Schubert <bernd.schubert@itwm.fraunhofer.de> writes:
> 
>> diff --git a/fs/bio.c b/fs/bio.c
>> index e453924..84da885 100644
>> --- a/fs/bio.c
>> +++ b/fs/bio.c
>> @@ -505,9 +505,14 @@ EXPORT_SYMBOL(bio_clone);
>>  int bio_get_nr_vecs(struct block_device *bdev)
>>  {
>>  	struct request_queue *q = bdev_get_queue(bdev);
>> -	return min_t(unsigned,
>> +	int nr_pages;
> 
> Looks like a corrupt patch.

It's fine, I think you are misreading the added and removed lines :-)

-- 
Jens Axboe

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	linux-xfs@oss.sgi.com, sandeen@sandeen.net,
	Kent Overstreet <kent.overstreet@gmail.com>,
	Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] bio allocation failure due to bio_get_nr_vecs()
Date: Fri, 11 May 2012 16:36:04 +0200	[thread overview]
Message-ID: <4FAD23D4.2070405@kernel.dk> (raw)
In-Reply-To: <x49sjf6vml5.fsf@segfault.boston.devel.redhat.com>

On 05/11/2012 04:06 PM, Jeff Moyer wrote:
> Bernd Schubert <bernd.schubert@itwm.fraunhofer.de> writes:
> 
>> diff --git a/fs/bio.c b/fs/bio.c
>> index e453924..84da885 100644
>> --- a/fs/bio.c
>> +++ b/fs/bio.c
>> @@ -505,9 +505,14 @@ EXPORT_SYMBOL(bio_clone);
>>  int bio_get_nr_vecs(struct block_device *bdev)
>>  {
>>  	struct request_queue *q = bdev_get_queue(bdev);
>> -	return min_t(unsigned,
>> +	int nr_pages;
> 
> Looks like a corrupt patch.

It's fine, I think you are misreading the added and removed lines :-)

-- 
Jens Axboe


  parent reply	other threads:[~2012-05-11 14:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10 15:45 kernel panic / NULL pointer dereference Bernd Schubert
2012-05-10 16:17 ` Eric Sandeen
2012-05-10 16:43 ` Bernd Schubert
2012-05-10 16:43   ` Bernd Schubert
2012-05-11 13:49   ` [PATCH] bio allocation failure due to bio_get_nr_vecs() Bernd Schubert
2012-05-11 13:49     ` Bernd Schubert
2012-05-11 14:06     ` Jeff Moyer
2012-05-11 14:06       ` Jeff Moyer
2012-05-11 14:31       ` Bernd Schubert
2012-05-11 14:31         ` Bernd Schubert
2012-05-11 14:36       ` Jens Axboe [this message]
2012-05-11 14:36         ` Jens Axboe
2012-05-11 16:29         ` Jeff Moyer
2012-05-11 16:29           ` Jeff Moyer
2012-05-11 14:36     ` Jens Axboe
2012-05-11 14:36       ` Jens Axboe
2012-05-11 14:44       ` Bernd Schubert
2012-05-11 14:44         ` Bernd Schubert
2012-05-11 14:45         ` Jens Axboe
2012-05-11 14:45           ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FAD23D4.2070405@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=bernd.schubert@itwm.fraunhofer.de \
    --cc=jmoyer@redhat.com \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@oss.sgi.com \
    --cc=sandeen@sandeen.net \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.