All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Ceuleers <jan.ceuleers@computer.org>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, b06378@freescale.com,
	linuxppc-dev@lists.ozlabs.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH] gianfar:don't add FCB length to hard_header_len
Date: Thu, 24 May 2012 20:03:13 +0200	[thread overview]
Message-ID: <4FBE77E1.4010103@computer.org> (raw)
In-Reply-To: <1337876210.5070.4.camel@joe2Laptop>

On 05/24/2012 06:16 PM, Joe Perches wrote:
> On Thu, 2012-05-24 at 17:04 +0200, Jan Ceuleers wrote:
>> On 05/22/2012 09:18 PM, David Miller wrote:
>>> Someone needs to go through this driver when net-next opens up
>>> and fix all of the indentation in this driver.
>>
>> May I give that a go?
> 
> I have scripts that automate most of this.
> I don't have the card though.
> 
> Maybe this is a starting point?
> It doesn't fix most 80 column warnings.

Thanks Joe.

I also don't have the card; the kinds of changes I was proposing to make
are code-neutral, whose correctness I was intending to prove by a binary
compare of the before-and-after .o.

Still happy to do that taking your contribution as a starting point.

Thanks, Jan

WARNING: multiple messages have this Message-ID (diff)
From: Jan Ceuleers <jan.ceuleers@computer.org>
To: Joe Perches <joe@perches.com>
Cc: David Miller <davem@davemloft.net>,
	b06378@freescale.com, netdev@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] gianfar:don't add FCB length to hard_header_len
Date: Thu, 24 May 2012 20:03:13 +0200	[thread overview]
Message-ID: <4FBE77E1.4010103@computer.org> (raw)
In-Reply-To: <1337876210.5070.4.camel@joe2Laptop>

On 05/24/2012 06:16 PM, Joe Perches wrote:
> On Thu, 2012-05-24 at 17:04 +0200, Jan Ceuleers wrote:
>> On 05/22/2012 09:18 PM, David Miller wrote:
>>> Someone needs to go through this driver when net-next opens up
>>> and fix all of the indentation in this driver.
>>
>> May I give that a go?
> 
> I have scripts that automate most of this.
> I don't have the card though.
> 
> Maybe this is a starting point?
> It doesn't fix most 80 column warnings.

Thanks Joe.

I also don't have the card; the kinds of changes I was proposing to make
are code-neutral, whose correctness I was intending to prove by a binary
compare of the before-and-after .o.

Still happy to do that taking your contribution as a starting point.

Thanks, Jan

  reply	other threads:[~2012-05-24 18:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22  9:00 [PATCH] gianfar:don't add FCB length to hard_header_len Jiajun Wu
2012-05-22  9:00 ` Jiajun Wu
2012-05-22 19:18 ` David Miller
2012-05-24 15:04   ` Jan Ceuleers
2012-05-24 15:04     ` Jan Ceuleers
2012-05-24 16:16     ` Joe Perches
2012-05-24 16:16       ` Joe Perches
2012-05-24 18:03       ` Jan Ceuleers [this message]
2012-05-24 18:03         ` Jan Ceuleers
2012-05-25 15:58       ` Paul Gortmaker
2012-05-25 15:58         ` Paul Gortmaker
2012-05-25 19:51         ` Joe Perches
2012-05-25 19:51           ` Joe Perches
2012-05-25 20:04           ` Paul Gortmaker
2012-05-25 20:04             ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBE77E1.4010103@computer.org \
    --to=jan.ceuleers@computer.org \
    --cc=b06378@freescale.com \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.