From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, b06378@freescale.com,
linuxppc-dev@lists.ozlabs.org, David Miller <davem@davemloft.net>,
Jan Ceuleers <jan.ceuleers@computer.org>
Subject: Re: [PATCH] gianfar:don't add FCB length to hard_header_len
Date: Fri, 25 May 2012 16:04:51 -0400 [thread overview]
Message-ID: <4FBFE5E3.6080600@windriver.com> (raw)
In-Reply-To: <1337975465.30100.4.camel@joe2Laptop>
On 12-05-25 03:51 PM, Joe Perches wrote:
> On Fri, 2012-05-25 at 11:58 -0400, Paul Gortmaker wrote:
>> But you really shouldn't need the hardware to validate this kind of
>> patch anyways -- aside from your code flow change in the irq routine of
>> gianfar_ptp, you should have been simply able to check for object file
>> equivalence before and after your change.
>
> No cross compiler either, and I'm lazy 'bout that...
Can't get much easier than using one of these:
http://www.kernel.org/pub/tools/crosstool/
Just untar, export PATH ARCH CROSS_COMPILE and go.
Can't get much lazier than that. Great to have around.
Paul.
>
> cheers, Joe
>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Joe Perches <joe@perches.com>
Cc: Jan Ceuleers <jan.ceuleers@computer.org>,
David Miller <davem@davemloft.net>, <b06378@freescale.com>,
<netdev@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] gianfar:don't add FCB length to hard_header_len
Date: Fri, 25 May 2012 16:04:51 -0400 [thread overview]
Message-ID: <4FBFE5E3.6080600@windriver.com> (raw)
In-Reply-To: <1337975465.30100.4.camel@joe2Laptop>
On 12-05-25 03:51 PM, Joe Perches wrote:
> On Fri, 2012-05-25 at 11:58 -0400, Paul Gortmaker wrote:
>> But you really shouldn't need the hardware to validate this kind of
>> patch anyways -- aside from your code flow change in the irq routine of
>> gianfar_ptp, you should have been simply able to check for object file
>> equivalence before and after your change.
>
> No cross compiler either, and I'm lazy 'bout that...
Can't get much easier than using one of these:
http://www.kernel.org/pub/tools/crosstool/
Just untar, export PATH ARCH CROSS_COMPILE and go.
Can't get much lazier than that. Great to have around.
Paul.
>
> cheers, Joe
>
next prev parent reply other threads:[~2012-05-25 20:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 9:00 [PATCH] gianfar:don't add FCB length to hard_header_len Jiajun Wu
2012-05-22 9:00 ` Jiajun Wu
2012-05-22 19:18 ` David Miller
2012-05-24 15:04 ` Jan Ceuleers
2012-05-24 15:04 ` Jan Ceuleers
2012-05-24 16:16 ` Joe Perches
2012-05-24 16:16 ` Joe Perches
2012-05-24 18:03 ` Jan Ceuleers
2012-05-24 18:03 ` Jan Ceuleers
2012-05-25 15:58 ` Paul Gortmaker
2012-05-25 15:58 ` Paul Gortmaker
2012-05-25 19:51 ` Joe Perches
2012-05-25 19:51 ` Joe Perches
2012-05-25 20:04 ` Paul Gortmaker [this message]
2012-05-25 20:04 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBFE5E3.6080600@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=b06378@freescale.com \
--cc=davem@davemloft.net \
--cc=jan.ceuleers@computer.org \
--cc=joe@perches.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.