All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Hunter <jon-hunter@ti.com>
To: jgq516@gmail.com
Cc: linux@arm.linux.org.uk, b-cousson@ti.com,
	rob.herring@calxeda.com, grant.likely@secretlab.ca,
	rnayak@ti.com, tony@atomide.com, wim@iguana.be,
	devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 2/3] OMAP: avoid build wdt platform device if with dt support
Date: Tue, 29 May 2012 12:53:38 -0500	[thread overview]
Message-ID: <4FC50D22.4090409@ti.com> (raw)
In-Reply-To: <1337942552-28218-3-git-send-email-jgq516@gmail.com>



On 05/25/2012 05:42 AM, jgq516@gmail.com wrote:
> From: Xiao Jiang <jgq516@gmail.com>
> 
> If provided dt support, then skip add wdt platform device as usual.
> 
> Signed-off-by: Xiao Jiang <jgq516@gmail.com>
> ---
>  arch/arm/mach-omap2/devices.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index ae62ece..80d7e3f 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -759,7 +759,7 @@ static int __init omap_init_wdt(void)
>  	char *oh_name = "wd_timer2";
>  	char *dev_name = "omap_wdt";
>  
> -	if (!cpu_class_is_omap2())
> +	if (!cpu_class_is_omap2() || of_have_populated_dt())
>  		return 0;
>  
>  	oh = omap_hwmod_lookup(oh_name);

Reviewed-by: Jon Hunter <jon-hunter@ti.com>

Cheers
Jon

WARNING: multiple messages have this Message-ID (diff)
From: Jon Hunter <jon-hunter@ti.com>
To: <jgq516@gmail.com>
Cc: <linux@arm.linux.org.uk>, <b-cousson@ti.com>,
	<rob.herring@calxeda.com>, <grant.likely@secretlab.ca>,
	<rnayak@ti.com>, <tony@atomide.com>, <wim@iguana.be>,
	<devicetree-discuss@lists.ozlabs.org>,
	<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH 2/3] OMAP: avoid build wdt platform device if with dt support
Date: Tue, 29 May 2012 12:53:38 -0500	[thread overview]
Message-ID: <4FC50D22.4090409@ti.com> (raw)
In-Reply-To: <1337942552-28218-3-git-send-email-jgq516@gmail.com>



On 05/25/2012 05:42 AM, jgq516@gmail.com wrote:
> From: Xiao Jiang <jgq516@gmail.com>
> 
> If provided dt support, then skip add wdt platform device as usual.
> 
> Signed-off-by: Xiao Jiang <jgq516@gmail.com>
> ---
>  arch/arm/mach-omap2/devices.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index ae62ece..80d7e3f 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -759,7 +759,7 @@ static int __init omap_init_wdt(void)
>  	char *oh_name = "wd_timer2";
>  	char *dev_name = "omap_wdt";
>  
> -	if (!cpu_class_is_omap2())
> +	if (!cpu_class_is_omap2() || of_have_populated_dt())
>  		return 0;
>  
>  	oh = omap_hwmod_lookup(oh_name);

Reviewed-by: Jon Hunter <jon-hunter@ti.com>

Cheers
Jon

WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] OMAP: avoid build wdt platform device if with dt support
Date: Tue, 29 May 2012 12:53:38 -0500	[thread overview]
Message-ID: <4FC50D22.4090409@ti.com> (raw)
In-Reply-To: <1337942552-28218-3-git-send-email-jgq516@gmail.com>



On 05/25/2012 05:42 AM, jgq516 at gmail.com wrote:
> From: Xiao Jiang <jgq516@gmail.com>
> 
> If provided dt support, then skip add wdt platform device as usual.
> 
> Signed-off-by: Xiao Jiang <jgq516@gmail.com>
> ---
>  arch/arm/mach-omap2/devices.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index ae62ece..80d7e3f 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -759,7 +759,7 @@ static int __init omap_init_wdt(void)
>  	char *oh_name = "wd_timer2";
>  	char *dev_name = "omap_wdt";
>  
> -	if (!cpu_class_is_omap2())
> +	if (!cpu_class_is_omap2() || of_have_populated_dt())
>  		return 0;
>  
>  	oh = omap_hwmod_lookup(oh_name);

Reviewed-by: Jon Hunter <jon-hunter@ti.com>

Cheers
Jon

  reply	other threads:[~2012-05-29 17:53 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-25 10:42 [PATCH 0/3] omap3/omap4: add device tree support for wdt jgq516
2012-05-25 10:42 ` jgq516 at gmail.com
2012-05-25 10:42 ` jgq516
2012-05-25 10:42 ` [PATCH 1/3] arm/dts: add wdt node for omap3 and omap4 jgq516
2012-05-25 10:42   ` jgq516 at gmail.com
2012-05-25 10:42   ` jgq516
2012-05-29 17:52   ` Jon Hunter
2012-05-29 17:52     ` Jon Hunter
2012-05-29 17:52     ` Jon Hunter
2012-05-30  3:19     ` Xiao Jiang
2012-05-30  3:19       ` Xiao Jiang
2012-05-30 14:42       ` Jon Hunter
2012-05-30 14:42         ` Jon Hunter
2012-05-30 14:42         ` Jon Hunter
2012-05-31  5:51         ` Xiao Jiang
2012-05-31  5:51           ` Xiao Jiang
2012-05-31  5:51           ` Xiao Jiang
2012-05-31 14:55           ` Jon Hunter
2012-05-31 14:55             ` Jon Hunter
2012-05-31 14:55             ` Jon Hunter
2012-05-31 20:59             ` Cousson, Benoit
2012-05-31 20:59               ` Cousson, Benoit
2012-05-31 20:59               ` Cousson, Benoit
2012-05-25 10:42 ` [PATCH 2/3] OMAP: avoid build wdt platform device if with dt support jgq516
2012-05-25 10:42   ` jgq516 at gmail.com
2012-05-25 10:42   ` jgq516
2012-05-29 17:53   ` Jon Hunter [this message]
2012-05-29 17:53     ` Jon Hunter
2012-05-29 17:53     ` Jon Hunter
2012-05-25 10:42 ` [PATCH 3/3] watchdog: omap_wdt: add device tree support jgq516
2012-05-25 10:42   ` jgq516 at gmail.com
2012-05-25 10:42   ` jgq516
2012-05-29 18:06   ` Jon Hunter
2012-05-29 18:06     ` Jon Hunter
2012-05-29 18:06     ` Jon Hunter
2012-05-30  3:18     ` Xiao Jiang
2012-05-30  3:18       ` Xiao Jiang
2012-05-30  7:54       ` Cousson, Benoit
2012-05-30  7:54         ` Cousson, Benoit
2012-05-30  7:54         ` Cousson, Benoit
2012-05-30 10:14         ` Xiao Jiang
2012-05-30 10:14           ` Xiao Jiang
2012-05-30 10:14           ` Xiao Jiang
2012-05-30 10:31           ` Xiao Jiang
2012-05-30 10:31             ` Xiao Jiang
2012-05-30 15:03         ` Jon Hunter
2012-05-30 15:03           ` Jon Hunter
2012-05-30 15:03           ` Jon Hunter
2012-05-30 15:30           ` Cousson, Benoit
2012-05-30 15:30             ` Cousson, Benoit
2012-05-30 15:30             ` Cousson, Benoit
2012-05-30 16:12             ` Jon Hunter
2012-05-30 16:12               ` Jon Hunter
2012-05-30 16:12               ` Jon Hunter
2012-05-29 17:47 ` [PATCH 0/3] omap3/omap4: add device tree support for wdt Jon Hunter
2012-05-29 17:47   ` Jon Hunter
2012-05-29 17:47   ` Jon Hunter
2012-05-30 10:14   ` Xiao Jiang
2012-05-30 10:14     ` Xiao Jiang
2012-05-30 10:14     ` Xiao Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC50D22.4090409@ti.com \
    --to=jon-hunter@ti.com \
    --cc=b-cousson@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jgq516@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=rnayak@ti.com \
    --cc=rob.herring@calxeda.com \
    --cc=tony@atomide.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.