From: Ryan Mallon <rmallon@gmail.com>
To: Rafal Prylowski <prylowski@metasoft.pl>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"bzolnier@gmail.com" <bzolnier@gmail.com>,
Sergei Shtylyov <sshtylyov@mvista.com>,
hsweeten@visionengravers.com,
"joao.ramos@inov.pt" <joao.ramos@inov.pt>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 2/3] ep93xx: IDE driver platform support code
Date: Mon, 04 Jun 2012 15:00:38 +1000 [thread overview]
Message-ID: <4FCC40F6.7040400@gmail.com> (raw)
In-Reply-To: <4F86C714.4090605@metasoft.pl>
On 12/04/12 22:14, Rafal Prylowski wrote:
>
> Add IDE driver platform support code for ep93xx.
>
> Signed-off-by: Rafal Prylowski <prylowski@metasoft.pl>
> Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ryan Mallon <rmallon@gmail.com>
Applied to ep93xx-devel. Sorry for the delay.
~Ryan
> ---
> arch/arm/mach-ep93xx/core.c | 96 +++++++++++++++++
> arch/arm/mach-ep93xx/include/mach/platform.h | 3
> arch/arm/mach-ep93xx/soc.h | 1
>
> Index: linux-2.6/arch/arm/mach-ep93xx/soc.h
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-ep93xx/soc.h
> +++ linux-2.6/arch/arm/mach-ep93xx/soc.h
> @@ -69,6 +69,7 @@
>
> #define EP93XX_BOOT_ROM_BASE EP93XX_AHB_IOMEM(0x00090000)
>
> +#define EP93XX_IDE_PHYS_BASE EP93XX_AHB_PHYS(0x000a0000)
> #define EP93XX_IDE_BASE EP93XX_AHB_IOMEM(0x000a0000)
>
> #define EP93XX_VIC1_BASE EP93XX_AHB_IOMEM(0x000b0000)
> Index: linux-2.6/arch/arm/mach-ep93xx/core.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-ep93xx/core.c
> +++ linux-2.6/arch/arm/mach-ep93xx/core.c
> @@ -868,6 +868,102 @@ static struct platform_device ep93xx_wdt
> .resource = ep93xx_wdt_resources,
> };
>
> +/*************************************************************************
> + * EP93xx IDE
> + *************************************************************************/
> +static struct resource ep93xx_ide_resources[] = {
> + DEFINE_RES_MEM(EP93XX_IDE_PHYS_BASE, 0x38),
> + DEFINE_RES_IRQ(IRQ_EP93XX_EXT3),
> +};
> +
> +static struct platform_device ep93xx_ide_device = {
> + .name = "ep93xx-ide",
> + .id = -1,
> + .dev = {
> + .dma_mask = &ep93xx_ide_device.dev.coherent_dma_mask,
> + .coherent_dma_mask = DMA_BIT_MASK(32),
> + },
> + .num_resources = ARRAY_SIZE(ep93xx_ide_resources),
> + .resource = ep93xx_ide_resources,
> +};
> +
> +void __init ep93xx_register_ide(void)
> +{
> + platform_device_register(&ep93xx_ide_device);
> +}
> +
> +int ep93xx_ide_acquire_gpio(struct platform_device *pdev)
> +{
> + int err;
> + int i;
> +
> + err = gpio_request(EP93XX_GPIO_LINE_EGPIO2, dev_name(&pdev->dev));
> + if (err)
> + return err;
> + err = gpio_request(EP93XX_GPIO_LINE_EGPIO15, dev_name(&pdev->dev));
> + if (err)
> + goto fail_egpio15;
> + for (i = 2; i < 8; i++) {
> + err = gpio_request(EP93XX_GPIO_LINE_E(i), dev_name(&pdev->dev));
> + if (err)
> + goto fail_gpio_e;
> + }
> + for (i = 4; i < 8; i++) {
> + err = gpio_request(EP93XX_GPIO_LINE_G(i), dev_name(&pdev->dev));
> + if (err)
> + goto fail_gpio_g;
> + }
> + for (i = 0; i < 8; i++) {
> + err = gpio_request(EP93XX_GPIO_LINE_H(i), dev_name(&pdev->dev));
> + if (err)
> + goto fail_gpio_h;
> + }
> +
> + /* GPIO ports E[7:2], G[7:4] and H used by IDE */
> + ep93xx_devcfg_clear_bits(EP93XX_SYSCON_DEVCFG_EONIDE |
> + EP93XX_SYSCON_DEVCFG_GONIDE |
> + EP93XX_SYSCON_DEVCFG_HONIDE);
> + return 0;
> +
> +fail_gpio_h:
> + for (--i; i >= 0; --i)
> + gpio_free(EP93XX_GPIO_LINE_H(i));
> + i = 8;
> +fail_gpio_g:
> + for (--i; i >= 4; --i)
> + gpio_free(EP93XX_GPIO_LINE_G(i));
> + i = 8;
> +fail_gpio_e:
> + for (--i; i >= 2; --i)
> + gpio_free(EP93XX_GPIO_LINE_E(i));
> + gpio_free(EP93XX_GPIO_LINE_EGPIO15);
> +fail_egpio15:
> + gpio_free(EP93XX_GPIO_LINE_EGPIO2);
> + return err;
> +}
> +EXPORT_SYMBOL(ep93xx_ide_acquire_gpio);
> +
> +void ep93xx_ide_release_gpio(struct platform_device *pdev)
> +{
> + int i;
> +
> + for (i = 2; i < 8; i++)
> + gpio_free(EP93XX_GPIO_LINE_E(i));
> + for (i = 4; i < 8; i++)
> + gpio_free(EP93XX_GPIO_LINE_G(i));
> + for (i = 0; i < 8; i++)
> + gpio_free(EP93XX_GPIO_LINE_H(i));
> + gpio_free(EP93XX_GPIO_LINE_EGPIO15);
> + gpio_free(EP93XX_GPIO_LINE_EGPIO2);
> +
> +
> + /* GPIO ports E[7:2], G[7:4] and H used by GPIO */
> + ep93xx_devcfg_set_bits(EP93XX_SYSCON_DEVCFG_EONIDE |
> + EP93XX_SYSCON_DEVCFG_GONIDE |
> + EP93XX_SYSCON_DEVCFG_HONIDE);
> +}
> +EXPORT_SYMBOL(ep93xx_ide_release_gpio);
> +
> void __init ep93xx_init_devices(void)
> {
> /* Disallow access to MaverickCrunch initially */
> Index: linux-2.6/arch/arm/mach-ep93xx/include/mach/platform.h
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-ep93xx/include/mach/platform.h
> +++ linux-2.6/arch/arm/mach-ep93xx/include/mach/platform.h
> @@ -48,6 +48,9 @@ void ep93xx_register_i2s(void);
> int ep93xx_i2s_acquire(void);
> void ep93xx_i2s_release(void);
> void ep93xx_register_ac97(void);
> +void ep93xx_register_ide(void);
> +int ep93xx_ide_acquire_gpio(struct platform_device *pdev);
> +void ep93xx_ide_release_gpio(struct platform_device *pdev);
>
> void ep93xx_init_devices(void);
> extern struct sys_timer ep93xx_timer;
WARNING: multiple messages have this Message-ID (diff)
From: rmallon@gmail.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/3] ep93xx: IDE driver platform support code
Date: Mon, 04 Jun 2012 15:00:38 +1000 [thread overview]
Message-ID: <4FCC40F6.7040400@gmail.com> (raw)
In-Reply-To: <4F86C714.4090605@metasoft.pl>
On 12/04/12 22:14, Rafal Prylowski wrote:
>
> Add IDE driver platform support code for ep93xx.
>
> Signed-off-by: Rafal Prylowski <prylowski@metasoft.pl>
> Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ryan Mallon <rmallon@gmail.com>
Applied to ep93xx-devel. Sorry for the delay.
~Ryan
> ---
> arch/arm/mach-ep93xx/core.c | 96 +++++++++++++++++
> arch/arm/mach-ep93xx/include/mach/platform.h | 3
> arch/arm/mach-ep93xx/soc.h | 1
>
> Index: linux-2.6/arch/arm/mach-ep93xx/soc.h
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-ep93xx/soc.h
> +++ linux-2.6/arch/arm/mach-ep93xx/soc.h
> @@ -69,6 +69,7 @@
>
> #define EP93XX_BOOT_ROM_BASE EP93XX_AHB_IOMEM(0x00090000)
>
> +#define EP93XX_IDE_PHYS_BASE EP93XX_AHB_PHYS(0x000a0000)
> #define EP93XX_IDE_BASE EP93XX_AHB_IOMEM(0x000a0000)
>
> #define EP93XX_VIC1_BASE EP93XX_AHB_IOMEM(0x000b0000)
> Index: linux-2.6/arch/arm/mach-ep93xx/core.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-ep93xx/core.c
> +++ linux-2.6/arch/arm/mach-ep93xx/core.c
> @@ -868,6 +868,102 @@ static struct platform_device ep93xx_wdt
> .resource = ep93xx_wdt_resources,
> };
>
> +/*************************************************************************
> + * EP93xx IDE
> + *************************************************************************/
> +static struct resource ep93xx_ide_resources[] = {
> + DEFINE_RES_MEM(EP93XX_IDE_PHYS_BASE, 0x38),
> + DEFINE_RES_IRQ(IRQ_EP93XX_EXT3),
> +};
> +
> +static struct platform_device ep93xx_ide_device = {
> + .name = "ep93xx-ide",
> + .id = -1,
> + .dev = {
> + .dma_mask = &ep93xx_ide_device.dev.coherent_dma_mask,
> + .coherent_dma_mask = DMA_BIT_MASK(32),
> + },
> + .num_resources = ARRAY_SIZE(ep93xx_ide_resources),
> + .resource = ep93xx_ide_resources,
> +};
> +
> +void __init ep93xx_register_ide(void)
> +{
> + platform_device_register(&ep93xx_ide_device);
> +}
> +
> +int ep93xx_ide_acquire_gpio(struct platform_device *pdev)
> +{
> + int err;
> + int i;
> +
> + err = gpio_request(EP93XX_GPIO_LINE_EGPIO2, dev_name(&pdev->dev));
> + if (err)
> + return err;
> + err = gpio_request(EP93XX_GPIO_LINE_EGPIO15, dev_name(&pdev->dev));
> + if (err)
> + goto fail_egpio15;
> + for (i = 2; i < 8; i++) {
> + err = gpio_request(EP93XX_GPIO_LINE_E(i), dev_name(&pdev->dev));
> + if (err)
> + goto fail_gpio_e;
> + }
> + for (i = 4; i < 8; i++) {
> + err = gpio_request(EP93XX_GPIO_LINE_G(i), dev_name(&pdev->dev));
> + if (err)
> + goto fail_gpio_g;
> + }
> + for (i = 0; i < 8; i++) {
> + err = gpio_request(EP93XX_GPIO_LINE_H(i), dev_name(&pdev->dev));
> + if (err)
> + goto fail_gpio_h;
> + }
> +
> + /* GPIO ports E[7:2], G[7:4] and H used by IDE */
> + ep93xx_devcfg_clear_bits(EP93XX_SYSCON_DEVCFG_EONIDE |
> + EP93XX_SYSCON_DEVCFG_GONIDE |
> + EP93XX_SYSCON_DEVCFG_HONIDE);
> + return 0;
> +
> +fail_gpio_h:
> + for (--i; i >= 0; --i)
> + gpio_free(EP93XX_GPIO_LINE_H(i));
> + i = 8;
> +fail_gpio_g:
> + for (--i; i >= 4; --i)
> + gpio_free(EP93XX_GPIO_LINE_G(i));
> + i = 8;
> +fail_gpio_e:
> + for (--i; i >= 2; --i)
> + gpio_free(EP93XX_GPIO_LINE_E(i));
> + gpio_free(EP93XX_GPIO_LINE_EGPIO15);
> +fail_egpio15:
> + gpio_free(EP93XX_GPIO_LINE_EGPIO2);
> + return err;
> +}
> +EXPORT_SYMBOL(ep93xx_ide_acquire_gpio);
> +
> +void ep93xx_ide_release_gpio(struct platform_device *pdev)
> +{
> + int i;
> +
> + for (i = 2; i < 8; i++)
> + gpio_free(EP93XX_GPIO_LINE_E(i));
> + for (i = 4; i < 8; i++)
> + gpio_free(EP93XX_GPIO_LINE_G(i));
> + for (i = 0; i < 8; i++)
> + gpio_free(EP93XX_GPIO_LINE_H(i));
> + gpio_free(EP93XX_GPIO_LINE_EGPIO15);
> + gpio_free(EP93XX_GPIO_LINE_EGPIO2);
> +
> +
> + /* GPIO ports E[7:2], G[7:4] and H used by GPIO */
> + ep93xx_devcfg_set_bits(EP93XX_SYSCON_DEVCFG_EONIDE |
> + EP93XX_SYSCON_DEVCFG_GONIDE |
> + EP93XX_SYSCON_DEVCFG_HONIDE);
> +}
> +EXPORT_SYMBOL(ep93xx_ide_release_gpio);
> +
> void __init ep93xx_init_devices(void)
> {
> /* Disallow access to MaverickCrunch initially */
> Index: linux-2.6/arch/arm/mach-ep93xx/include/mach/platform.h
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-ep93xx/include/mach/platform.h
> +++ linux-2.6/arch/arm/mach-ep93xx/include/mach/platform.h
> @@ -48,6 +48,9 @@ void ep93xx_register_i2s(void);
> int ep93xx_i2s_acquire(void);
> void ep93xx_i2s_release(void);
> void ep93xx_register_ac97(void);
> +void ep93xx_register_ide(void);
> +int ep93xx_ide_acquire_gpio(struct platform_device *pdev);
> +void ep93xx_ide_release_gpio(struct platform_device *pdev);
>
> void ep93xx_init_devices(void);
> extern struct sys_timer ep93xx_timer;
next prev parent reply other threads:[~2012-06-04 5:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 12:10 [PATCH v3 0/3] Add PATA host controller support for Cirrus Logic EP93xx CPU Rafal Prylowski
2012-04-12 12:10 ` Rafal Prylowski
2012-04-12 12:13 ` [PATCH v3 1/3] PATA host controller driver for ep93xx Rafal Prylowski
2012-04-12 12:13 ` Rafal Prylowski
2012-05-22 20:05 ` Jeff Garzik
2012-05-22 20:05 ` Jeff Garzik
2012-04-12 12:14 ` [PATCH v3 2/3] ep93xx: IDE driver platform support code Rafal Prylowski
2012-04-12 12:14 ` Rafal Prylowski
2012-04-12 17:09 ` H Hartley Sweeten
2012-04-12 17:09 ` H Hartley Sweeten
2012-06-04 5:00 ` Ryan Mallon [this message]
2012-06-04 5:00 ` Ryan Mallon
2012-04-12 12:15 ` [PATCH v3 3/3] ep93xx: Add IDE support to edb93xx boards Rafal Prylowski
2012-04-12 12:15 ` Rafal Prylowski
2012-06-04 5:01 ` Ryan Mallon
2012-06-04 5:01 ` Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCC40F6.7040400@gmail.com \
--to=rmallon@gmail.com \
--cc=bzolnier@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=joao.ramos@inov.pt \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=prylowski@metasoft.pl \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.