From: Ryan Mallon <rmallon@gmail.com>
To: Rafal Prylowski <prylowski@metasoft.pl>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"bzolnier@gmail.com" <bzolnier@gmail.com>,
Sergei Shtylyov <sshtylyov@mvista.com>,
hsweeten@visionengravers.com,
"joao.ramos@inov.pt" <joao.ramos@inov.pt>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 3/3] ep93xx: Add IDE support to edb93xx boards
Date: Mon, 04 Jun 2012 15:01:52 +1000 [thread overview]
Message-ID: <4FCC4140.6000500@gmail.com> (raw)
In-Reply-To: <4F86C753.3020200@metasoft.pl>
On 12/04/12 22:15, Rafal Prylowski wrote:
>
> Add IDE support to edb93xx boards.
>
> Signed-off-by: Rafal Prylowski <prylowski@metasoft.pl>
> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ryan Mallon <rmallon@gmail.com>
Applied to ep93xx-devel. Sorry for the delay. Note, I fixed a minor
build error, see below.
~Ryan
> ---
> arch/arm/mach-ep93xx/edb93xx.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> Index: linux-2.6/arch/arm/mach-ep93xx/edb93xx.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-ep93xx/edb93xx.c
> +++ linux-2.6/arch/arm/mach-ep93xx/edb93xx.c
> @@ -233,6 +233,29 @@ static void __init edb93xx_register_fb(v
> }
>
>
> +/*************************************************************************
> + * EDB93xx IDE
> + *************************************************************************/
> +static int __init edb93xx_has_ide(void)
> +{
> + /*
> + * Although EDB9312 and EDB9315 do have IDE capability, they have
> + * INTRQ line wired as pull-up, which makes using IDE interface
> + * problematic.
> + */
> + return machine_is_edb9312() || machine_is_edb9315 ||
machine_is_edb9315()
> + machine_is_edb9315a();
> +}
> +
> +static void __init edb93xx_register_ide(void)
> +{
> + if (!edb93xx_has_ide())
> + return;
> +
> + ep93xx_register_ide();
> +}
> +
> +
> static void __init edb93xx_init_machine(void)
> {
> ep93xx_init_devices();
> @@ -243,6 +266,7 @@ static void __init edb93xx_init_machine(
> edb93xx_register_i2s();
> edb93xx_register_pwm();
> edb93xx_register_fb();
> + edb93xx_register_ide();
> }
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: rmallon@gmail.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/3] ep93xx: Add IDE support to edb93xx boards
Date: Mon, 04 Jun 2012 15:01:52 +1000 [thread overview]
Message-ID: <4FCC4140.6000500@gmail.com> (raw)
In-Reply-To: <4F86C753.3020200@metasoft.pl>
On 12/04/12 22:15, Rafal Prylowski wrote:
>
> Add IDE support to edb93xx boards.
>
> Signed-off-by: Rafal Prylowski <prylowski@metasoft.pl>
> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ryan Mallon <rmallon@gmail.com>
Applied to ep93xx-devel. Sorry for the delay. Note, I fixed a minor
build error, see below.
~Ryan
> ---
> arch/arm/mach-ep93xx/edb93xx.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> Index: linux-2.6/arch/arm/mach-ep93xx/edb93xx.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-ep93xx/edb93xx.c
> +++ linux-2.6/arch/arm/mach-ep93xx/edb93xx.c
> @@ -233,6 +233,29 @@ static void __init edb93xx_register_fb(v
> }
>
>
> +/*************************************************************************
> + * EDB93xx IDE
> + *************************************************************************/
> +static int __init edb93xx_has_ide(void)
> +{
> + /*
> + * Although EDB9312 and EDB9315 do have IDE capability, they have
> + * INTRQ line wired as pull-up, which makes using IDE interface
> + * problematic.
> + */
> + return machine_is_edb9312() || machine_is_edb9315 ||
machine_is_edb9315()
> + machine_is_edb9315a();
> +}
> +
> +static void __init edb93xx_register_ide(void)
> +{
> + if (!edb93xx_has_ide())
> + return;
> +
> + ep93xx_register_ide();
> +}
> +
> +
> static void __init edb93xx_init_machine(void)
> {
> ep93xx_init_devices();
> @@ -243,6 +266,7 @@ static void __init edb93xx_init_machine(
> edb93xx_register_i2s();
> edb93xx_register_pwm();
> edb93xx_register_fb();
> + edb93xx_register_ide();
> }
>
>
>
next prev parent reply other threads:[~2012-06-04 5:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 12:10 [PATCH v3 0/3] Add PATA host controller support for Cirrus Logic EP93xx CPU Rafal Prylowski
2012-04-12 12:10 ` Rafal Prylowski
2012-04-12 12:13 ` [PATCH v3 1/3] PATA host controller driver for ep93xx Rafal Prylowski
2012-04-12 12:13 ` Rafal Prylowski
2012-05-22 20:05 ` Jeff Garzik
2012-05-22 20:05 ` Jeff Garzik
2012-04-12 12:14 ` [PATCH v3 2/3] ep93xx: IDE driver platform support code Rafal Prylowski
2012-04-12 12:14 ` Rafal Prylowski
2012-04-12 17:09 ` H Hartley Sweeten
2012-04-12 17:09 ` H Hartley Sweeten
2012-06-04 5:00 ` Ryan Mallon
2012-06-04 5:00 ` Ryan Mallon
2012-04-12 12:15 ` [PATCH v3 3/3] ep93xx: Add IDE support to edb93xx boards Rafal Prylowski
2012-04-12 12:15 ` Rafal Prylowski
2012-06-04 5:01 ` Ryan Mallon [this message]
2012-06-04 5:01 ` Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCC4140.6000500@gmail.com \
--to=rmallon@gmail.com \
--cc=bzolnier@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=joao.ramos@inov.pt \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=prylowski@metasoft.pl \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.