From: Shubhrajyoti <shubhrajyoti@ti.com>
To: Roland Stigge <stigge@antcom.de>
Cc: dmitry.torokhov@gmail.com, axel.lin@gmail.com, riyer@nvidia.com,
michael.hennerich@analog.com, grant.likely@secretlab.ca,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kevin.wells@nxp.com,
srinivas.bakki@nxp.com, devicetree-discuss@lists.ozlabs.org,
rob.herring@calxeda.com
Subject: Re: [PATCH RESEND v4] input: keyboard: Add keys driver for the LPC32xx SoC
Date: Tue, 12 Jun 2012 10:58:01 +0530 [thread overview]
Message-ID: <4FD6D361.2020305@ti.com> (raw)
In-Reply-To: <1339443891-15197-1-git-send-email-stigge@antcom.de>
On Tuesday 12 June 2012 01:14 AM, Roland Stigge wrote:
> +
> +struct lpc32xx_kscan_drv {
> + struct input_dev *input;
> + struct lpc32xx_kscan_cfg *kscancfg;
> + struct clk *clk;
> + void __iomem *kscan_base;
> + int irq;
Do you really need this irq field? It is used in the probe and remove only.
> + u8 lastkeystates[8];
> + u32 io_p_start;
> + u32 io_p_size;
> +};
WARNING: multiple messages have this Message-ID (diff)
From: shubhrajyoti@ti.com (Shubhrajyoti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v4] input: keyboard: Add keys driver for the LPC32xx SoC
Date: Tue, 12 Jun 2012 10:58:01 +0530 [thread overview]
Message-ID: <4FD6D361.2020305@ti.com> (raw)
In-Reply-To: <1339443891-15197-1-git-send-email-stigge@antcom.de>
On Tuesday 12 June 2012 01:14 AM, Roland Stigge wrote:
> +
> +struct lpc32xx_kscan_drv {
> + struct input_dev *input;
> + struct lpc32xx_kscan_cfg *kscancfg;
> + struct clk *clk;
> + void __iomem *kscan_base;
> + int irq;
Do you really need this irq field? It is used in the probe and remove only.
> + u8 lastkeystates[8];
> + u32 io_p_start;
> + u32 io_p_size;
> +};
next prev parent reply other threads:[~2012-06-12 5:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 19:44 [PATCH RESEND v4] input: keyboard: Add keys driver for the LPC32xx SoC Roland Stigge
2012-06-11 19:44 ` Roland Stigge
2012-06-12 5:28 ` Shubhrajyoti [this message]
2012-06-12 5:28 ` Shubhrajyoti
2012-06-21 8:56 ` Dmitry Torokhov
2012-06-21 8:56 ` Dmitry Torokhov
2012-06-24 14:42 ` Roland Stigge
2012-06-24 14:42 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD6D361.2020305@ti.com \
--to=shubhrajyoti@ti.com \
--cc=axel.lin@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=kevin.wells@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=riyer@nvidia.com \
--cc=rob.herring@calxeda.com \
--cc=srinivas.bakki@nxp.com \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.