All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Stigge <stigge@antcom.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: axel.lin@gmail.com, riyer@nvidia.com,
	michael.hennerich@analog.com, grant.likely@secretlab.ca,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, kevin.wells@nxp.com,
	srinivas.bakki@nxp.com, devicetree-discuss@lists.ozlabs.org,
	rob.herring@calxeda.com
Subject: Re: [PATCH RESEND v4] input: keyboard: Add keys driver for the LPC32xx SoC
Date: Sun, 24 Jun 2012 16:42:28 +0200	[thread overview]
Message-ID: <4FE72754.2000706@antcom.de> (raw)
In-Reply-To: <20120621085623.GF2193@core.coreip.homeip.net>

On 21/06/12 10:56, Dmitry Torokhov wrote:
> On Mon, Jun 11, 2012 at 09:44:51PM +0200, Roland Stigge wrote:
>> This patch adds a driver for the key scan interface of the LPC32xx SoC
>>
>> Signed-off-by: Roland Stigge <stigge@antcom.de>
>> For the DT binding: Acked-by: Rob Herring <rob.herring@calxeda.con>
> 
> Not a real review, just a quick question - if th driver is DT-only now
> do we need to have the platform data or it would make more sense to read
> DT-bindings and fill the main device structure directly?

And:

>> +
>> +	matrix_keypad_build_keymap(NULL, NULL, kscandat->kscancfg->matrix_sz,
>> +				   kscandat->kscancfg->matrix_sz,
>> +				   kscandat->kscancfg->keymap, kscandat->input);
> 
> This function may fail now.

I'm addressing both issues in a updated patch.

Thanks for the feedback,

Roland

WARNING: multiple messages have this Message-ID (diff)
From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v4] input: keyboard: Add keys driver for the LPC32xx SoC
Date: Sun, 24 Jun 2012 16:42:28 +0200	[thread overview]
Message-ID: <4FE72754.2000706@antcom.de> (raw)
In-Reply-To: <20120621085623.GF2193@core.coreip.homeip.net>

On 21/06/12 10:56, Dmitry Torokhov wrote:
> On Mon, Jun 11, 2012 at 09:44:51PM +0200, Roland Stigge wrote:
>> This patch adds a driver for the key scan interface of the LPC32xx SoC
>>
>> Signed-off-by: Roland Stigge <stigge@antcom.de>
>> For the DT binding: Acked-by: Rob Herring <rob.herring@calxeda.con>
> 
> Not a real review, just a quick question - if th driver is DT-only now
> do we need to have the platform data or it would make more sense to read
> DT-bindings and fill the main device structure directly?

And:

>> +
>> +	matrix_keypad_build_keymap(NULL, NULL, kscandat->kscancfg->matrix_sz,
>> +				   kscandat->kscancfg->matrix_sz,
>> +				   kscandat->kscancfg->keymap, kscandat->input);
> 
> This function may fail now.

I'm addressing both issues in a updated patch.

Thanks for the feedback,

Roland

  reply	other threads:[~2012-06-24 14:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-11 19:44 [PATCH RESEND v4] input: keyboard: Add keys driver for the LPC32xx SoC Roland Stigge
2012-06-11 19:44 ` Roland Stigge
2012-06-12  5:28 ` Shubhrajyoti
2012-06-12  5:28   ` Shubhrajyoti
2012-06-21  8:56 ` Dmitry Torokhov
2012-06-21  8:56   ` Dmitry Torokhov
2012-06-24 14:42   ` Roland Stigge [this message]
2012-06-24 14:42     ` Roland Stigge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE72754.2000706@antcom.de \
    --to=stigge@antcom.de \
    --cc=axel.lin@gmail.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=kevin.wells@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=riyer@nvidia.com \
    --cc=rob.herring@calxeda.com \
    --cc=srinivas.bakki@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.